From 85052bc9bca0ecb8c5bbd159a02f4db5e5d3bf48 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Fri, 17 Feb 2023 17:29:48 +0100 Subject: [PATCH] Bugfix/fix buying power calculation with emergency fund tag (#1713) * Fix buying power calculation * Update changelog --- CHANGELOG.md | 4 ++++ apps/api/src/app/portfolio/portfolio.service.ts | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4eceeb924..d045aff6c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Beautified the ETF names in the asset profile +### Fixed + +- Fixed the buying power calculation if no emergency fund is set but an activity is tagged as _Emergency Fund_ + ## 1.235.0 - 2023-02-16 ### Changed diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 6700eda99..2564d1d49 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -1550,7 +1550,10 @@ export class PortfolioService { userCurrency }).toNumber(); const emergencyFund = new Big( - (user.Settings?.settings as UserSettings)?.emergencyFund ?? 0 + Math.max( + emergencyFundPositionsValueInBaseCurrency, + (user.Settings?.settings as UserSettings)?.emergencyFund ?? 0 + ) ); const fees = this.getFees({ activities, userCurrency }).toNumber(); const firstOrderDate = activities[0]?.date;