From 9b1e9397a8f5d6c6d0dce853109f4cde149704f6 Mon Sep 17 00:00:00 2001
From: Valentin Zickner <valentin.zickner@flowable.com>
Date: Tue, 27 Jul 2021 23:05:39 +0200
Subject: [PATCH] add errors in case gross performance is not set

---
 apps/api/src/app/portfolio/portfolio.service.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index 6c701cbe5..b99b05537 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -474,16 +474,18 @@ export class PortfolioService {
         new Big(currentPosition.marketPrice).mul(currentPosition.quantity)
       );
       if (currentPosition.grossPerformance) {
-        hasErrors = true;
         grossPerformance = grossPerformance.plus(
           currentPosition.grossPerformance
         );
+      } else {
+        hasErrors = true;
       }
       if (currentPosition.grossPerformancePercentage) {
-        hasErrors = true;
         grossPerformancePercentage = grossPerformancePercentage.mul(
           currentPosition.grossPerformancePercentage.plus(1)
         );
+      } else {
+        hasErrors = true;
       }
     }