From a59f9fa037f514505a6c77b5e65b29b66e66bbd1 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sat, 21 Oct 2023 09:41:07 +0200
Subject: [PATCH] Feature/remove version from client (#2522)

* Remove version

* Update changelog
---
 CHANGELOG.md                                                   | 1 +
 apps/client/src/app/app.component.html                         | 1 -
 apps/client/src/app/app.component.ts                           | 2 --
 .../app/components/admin-overview/admin-overview.component.ts  | 1 -
 .../app/pages/about/overview/about-overview-page.component.ts  | 2 --
 .../src/app/pages/about/overview/about-overview-page.html      | 3 ---
 apps/client/src/environments/environment.prod.ts               | 3 +--
 apps/client/src/environments/environment.ts                    | 3 +--
 8 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4c0c70bb6..27f5aaedc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Improved the error message in the activities import for `csv` files
+- Removed the application version from the client
 - Allowed to edit today’s historical market data in the asset profile details dialog of the admin control panel
 
 ### Fixed
diff --git a/apps/client/src/app/app.component.html b/apps/client/src/app/app.component.html
index a52261969..e792598a7 100644
--- a/apps/client/src/app/app.component.html
+++ b/apps/client/src/app/app.component.html
@@ -165,7 +165,6 @@
     <div class="row text-center">
       <div class="col">
         © 2021 - {{ currentYear }} <a href="https://ghostfol.io">Ghostfolio</a>
-        {{ version }}
       </div>
     </div>
 
diff --git a/apps/client/src/app/app.component.ts b/apps/client/src/app/app.component.ts
index d1d9529ce..2317279b1 100644
--- a/apps/client/src/app/app.component.ts
+++ b/apps/client/src/app/app.component.ts
@@ -17,7 +17,6 @@ import { DeviceDetectorService } from 'ngx-device-detector';
 import { Subject } from 'rxjs';
 import { filter, takeUntil } from 'rxjs/operators';
 
-import { environment } from '../environments/environment';
 import { DataService } from './services/data.service';
 import { TokenStorageService } from './services/token-storage.service';
 import { UserService } from './services/user/user.service';
@@ -60,7 +59,6 @@ export class AppComponent implements OnDestroy, OnInit {
   public routerLinkResources = ['/' + $localize`resources`];
   public showFooter = false;
   public user: User;
-  public version = environment.version;
 
   private unsubscribeSubject = new Subject<void>();
 
diff --git a/apps/client/src/app/components/admin-overview/admin-overview.component.ts b/apps/client/src/app/components/admin-overview/admin-overview.component.ts
index b1e91dfc9..97573cdbe 100644
--- a/apps/client/src/app/components/admin-overview/admin-overview.component.ts
+++ b/apps/client/src/app/components/admin-overview/admin-overview.component.ts
@@ -1,6 +1,5 @@
 import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
 import { MatCheckboxChange } from '@angular/material/checkbox';
-import { environment } from '@ghostfolio/client/../environments/environment';
 import { AdminService } from '@ghostfolio/client/services/admin.service';
 import { CacheService } from '@ghostfolio/client/services/cache.service';
 import { DataService } from '@ghostfolio/client/services/data.service';
diff --git a/apps/client/src/app/pages/about/overview/about-overview-page.component.ts b/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
index 471874dc2..4c15f73b0 100644
--- a/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
+++ b/apps/client/src/app/pages/about/overview/about-overview-page.component.ts
@@ -1,5 +1,4 @@
 import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
-import { environment } from '@ghostfolio/client/../environments/environment';
 import { DataService } from '@ghostfolio/client/services/data.service';
 import { UserService } from '@ghostfolio/client/services/user/user.service';
 import { User } from '@ghostfolio/common/interfaces';
@@ -20,7 +19,6 @@ export class AboutOverviewPageComponent implements OnDestroy, OnInit {
   public routerLinkFaq = ['/' + $localize`faq`];
   public routerLinkFeatures = ['/' + $localize`features`];
   public user: User;
-  public version = environment.version;
 
   private unsubscribeSubject = new Subject<void>();
 
diff --git a/apps/client/src/app/pages/about/overview/about-overview-page.html b/apps/client/src/app/pages/about/overview/about-overview-page.html
index a9bada763..4dc9fbf78 100644
--- a/apps/client/src/app/pages/about/overview/about-overview-page.html
+++ b/apps/client/src/app/pages/about/overview/about-overview-page.html
@@ -35,9 +35,6 @@
             title="Contributors to Ghostfolio"
             >contributors</a
           >.
-          <ng-container *ngIf="version">
-            This instance is running Ghostfolio {{ version }}.
-          </ng-container>
           <ng-container *ngIf="hasPermissionForSubscription"
             >Check the system status at
             <a href="https://status.ghostfol.io" title="Ghostfolio Status"
diff --git a/apps/client/src/environments/environment.prod.ts b/apps/client/src/environments/environment.prod.ts
index 66b0c6745..6f1d6b92d 100644
--- a/apps/client/src/environments/environment.prod.ts
+++ b/apps/client/src/environments/environment.prod.ts
@@ -1,6 +1,5 @@
 export const environment = {
   lastPublish: '{BUILD_TIMESTAMP}',
   production: true,
-  stripePublicKey: '',
-  version: `v${require('../../../../package.json').version}`
+  stripePublicKey: ''
 };
diff --git a/apps/client/src/environments/environment.ts b/apps/client/src/environments/environment.ts
index 58a0fe1cf..0a4d51d98 100644
--- a/apps/client/src/environments/environment.ts
+++ b/apps/client/src/environments/environment.ts
@@ -5,8 +5,7 @@
 export const environment = {
   lastPublish: null,
   production: false,
-  stripePublicKey: '',
-  version: 'dev'
+  stripePublicKey: ''
 };
 
 /*