diff --git a/CHANGELOG.md b/CHANGELOG.md index 6974ddf5f..b9645b9d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Split the environment variable `DATA_SOURCE_PRIMARY` in `DATA_SOURCE_EXCHANGE_RATES` and `DATA_SOURCE_IMPORT` +### Fixed + +- Fixed the exception on the accounts page + ## 1.262.0 - 2023-04-29 ### Added diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 1b839977b..3536169f2 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -466,9 +466,10 @@ export class PortfolioService { cashDetails.balanceInBaseCurrency ); - const isFilteredByAccount = filters.some((filter) => { - return filter.type === 'ACCOUNT'; - }); + const isFilteredByAccount = + filters?.some((filter) => { + return filter.type === 'ACCOUNT'; + }) ?? false; let filteredValueInBaseCurrency = isFilteredByAccount ? totalValueInBaseCurrency @@ -571,11 +572,11 @@ export class PortfolioService { }; } - const isFilteredByCash = filters.some((filter) => { + const isFilteredByCash = filters?.some((filter) => { return filter.type === 'ASSET_CLASS' && filter.id === 'CASH'; }); - if (filters.length === 0 || isFilteredByCash || isFilteredByAccount) { + if (filters?.length === 0 || isFilteredByAccount || isFilteredByCash) { const cashPositions = await this.getCashPositions({ cashDetails, userCurrency,