From a8c65cf3c2923b38ff46b488185944403450a6fa Mon Sep 17 00:00:00 2001
From: Thomas <4159106+dtslvr@users.noreply.github.com>
Date: Fri, 16 Apr 2021 12:02:05 +0200
Subject: [PATCH] Feature/migrate links to router link (#2)

* Migrate links to RouterLink
* Add i18n
---
 apps/client/src/app/components/header/header.module.ts        | 4 ++--
 .../no-transactions-info/no-transactions-info.component.html  | 2 +-
 .../no-transactions-info/no-transactions-info.module.ts       | 3 ++-
 apps/client/src/app/pages/login/login-page.html               | 4 +++-
 apps/client/src/app/pages/login/login-page.module.ts          | 2 ++
 5 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/apps/client/src/app/components/header/header.module.ts b/apps/client/src/app/components/header/header.module.ts
index 73d54a059..44b492e78 100644
--- a/apps/client/src/app/components/header/header.module.ts
+++ b/apps/client/src/app/components/header/header.module.ts
@@ -3,11 +3,11 @@ import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatButtonModule } from '@angular/material/button';
 import { MatMenuModule } from '@angular/material/menu';
 import { MatToolbarModule } from '@angular/material/toolbar';
+import { RouterModule } from '@angular/router';
 
 import { LoginWithAccessTokenDialogModule } from '../../pages/login/login-with-access-token-dialog/login-with-access-token-dialog.module';
 import { GfLogoModule } from '../logo/logo.module';
 import { HeaderComponent } from './header.component';
-import { RouterModule } from '@angular/router';
 
 @NgModule({
   declarations: [HeaderComponent],
@@ -19,7 +19,7 @@ import { RouterModule } from '@angular/router';
     MatButtonModule,
     MatMenuModule,
     MatToolbarModule,
-    RouterModule,
+    RouterModule
   ],
   providers: [],
   schemas: [CUSTOM_ELEMENTS_SCHEMA]
diff --git a/apps/client/src/app/components/no-transactions-info/no-transactions-info.component.html b/apps/client/src/app/components/no-transactions-info/no-transactions-info.component.html
index 17ab58e47..bc0879dcf 100644
--- a/apps/client/src/app/components/no-transactions-info/no-transactions-info.component.html
+++ b/apps/client/src/app/components/no-transactions-info/no-transactions-info.component.html
@@ -1,7 +1,7 @@
 <a
   class="align-items-center justify-content-center"
   color="primary"
-  href="/transactions"
+  [routerLink]="['/transactions']"
   mat-button
 >
   <ion-icon class="mr-1" name="time-outline" size="large"></ion-icon>
diff --git a/apps/client/src/app/components/no-transactions-info/no-transactions-info.module.ts b/apps/client/src/app/components/no-transactions-info/no-transactions-info.module.ts
index 318286a18..e6aa10deb 100644
--- a/apps/client/src/app/components/no-transactions-info/no-transactions-info.module.ts
+++ b/apps/client/src/app/components/no-transactions-info/no-transactions-info.module.ts
@@ -1,13 +1,14 @@
 import { CommonModule } from '@angular/common';
 import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatButtonModule } from '@angular/material/button';
+import { RouterModule } from '@angular/router';
 
 import { NoTransactionsInfoComponent } from './no-transactions-info.component';
 
 @NgModule({
   declarations: [NoTransactionsInfoComponent],
   exports: [NoTransactionsInfoComponent],
-  imports: [CommonModule, MatButtonModule],
+  imports: [CommonModule, MatButtonModule, RouterModule],
   providers: [],
   schemas: [CUSTOM_ELEMENTS_SCHEMA]
 })
diff --git a/apps/client/src/app/pages/login/login-page.html b/apps/client/src/app/pages/login/login-page.html
index 92f37ed48..81768ab19 100644
--- a/apps/client/src/app/pages/login/login-page.html
+++ b/apps/client/src/app/pages/login/login-page.html
@@ -105,7 +105,9 @@
         </li>
       </ul>
       <div class="mt-4 text-center">
-        <a href="/about" mat-stroked-button>Learn more about Ghostfolio</a>
+        <a [routerLink]="['/about']" i18n mat-stroked-button
+          >Learn more about Ghostfolio</a
+        >
       </div>
     </div>
   </div>
diff --git a/apps/client/src/app/pages/login/login-page.module.ts b/apps/client/src/app/pages/login/login-page.module.ts
index 823f7ca91..5eb16eaaa 100644
--- a/apps/client/src/app/pages/login/login-page.module.ts
+++ b/apps/client/src/app/pages/login/login-page.module.ts
@@ -1,6 +1,7 @@
 import { CommonModule } from '@angular/common';
 import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatButtonModule } from '@angular/material/button';
+import { RouterModule } from '@angular/router';
 
 import { GfLineChartModule } from '../../components/line-chart/line-chart.module';
 import { GfLogoModule } from '../../components/logo/logo.module';
@@ -17,6 +18,7 @@ import { ShowAccessTokenDialogModule } from './show-access-token-dialog/show-acc
     GfLogoModule,
     LoginPageRoutingModule,
     MatButtonModule,
+    RouterModule,
     ShowAccessTokenDialogModule
   ],
   providers: [],