From bf816c3b899e483f9c9877c33bc0ef72330d60d0 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 15 Oct 2023 10:02:55 +0200
Subject: [PATCH] Bugfix/show transfer balance button based on permission
 (#2489)

* Show button depending on permission

* Update changelog
---
 CHANGELOG.md                                                | 6 ++++++
 .../components/accounts-table/accounts-table.component.html | 2 +-
 .../src/app/pages/accounts/accounts-page.component.ts       | 6 +++---
 apps/client/src/app/pages/accounts/accounts-page.html       | 2 +-
 4 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 63d566f7d..dcdffbf53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Fixed
+
+- Displayed the transfer cash balance button based on a permission
+
 ## 2.11.0 - 2023-10-14
 
 ### Added
diff --git a/apps/client/src/app/components/accounts-table/accounts-table.component.html b/apps/client/src/app/components/accounts-table/accounts-table.component.html
index a4548c1b9..bfe5a667a 100644
--- a/apps/client/src/app/components/accounts-table/accounts-table.component.html
+++ b/apps/client/src/app/components/accounts-table/accounts-table.component.html
@@ -1,4 +1,4 @@
-<div class="d-flex justify-content-end">
+<div *ngIf="showActions" class="d-flex justify-content-end">
   <button
     class="align-items-center d-flex"
     mat-stroked-button
diff --git a/apps/client/src/app/pages/accounts/accounts-page.component.ts b/apps/client/src/app/pages/accounts/accounts-page.component.ts
index 882f9b3f6..61db47577 100644
--- a/apps/client/src/app/pages/accounts/accounts-page.component.ts
+++ b/apps/client/src/app/pages/accounts/accounts-page.component.ts
@@ -30,7 +30,7 @@ export class AccountsPageComponent implements OnDestroy, OnInit {
   public deviceType: string;
   public hasImpersonationId: boolean;
   public hasPermissionToCreateAccount: boolean;
-  public hasPermissionToDeleteAccount: boolean;
+  public hasPermissionToUpdateAccount: boolean;
   public routeQueryParams: Subscription;
   public totalBalanceInBaseCurrency = 0;
   public totalValueInBaseCurrency = 0;
@@ -95,9 +95,9 @@ export class AccountsPageComponent implements OnDestroy, OnInit {
             this.user.permissions,
             permissions.createAccount
           );
-          this.hasPermissionToDeleteAccount = hasPermission(
+          this.hasPermissionToUpdateAccount = hasPermission(
             this.user.permissions,
-            permissions.deleteAccount
+            permissions.updateAccount
           );
 
           this.changeDetectorRef.markForCheck();
diff --git a/apps/client/src/app/pages/accounts/accounts-page.html b/apps/client/src/app/pages/accounts/accounts-page.html
index a7d5901bb..c67323b1a 100644
--- a/apps/client/src/app/pages/accounts/accounts-page.html
+++ b/apps/client/src/app/pages/accounts/accounts-page.html
@@ -8,7 +8,7 @@
           [baseCurrency]="user?.settings?.baseCurrency"
           [deviceType]="deviceType"
           [locale]="user?.settings?.locale"
-          [showActions]="!hasImpersonationId && hasPermissionToDeleteAccount && !user.settings.isRestrictedView"
+          [showActions]="!hasImpersonationId && hasPermissionToUpdateAccount && !user.settings.isRestrictedView"
           [totalBalanceInBaseCurrency]="totalBalanceInBaseCurrency"
           [totalValueInBaseCurrency]="totalValueInBaseCurrency"
           [transactionCount]="transactionCount"