Bugfix/fix symbol validation in Yahoo Finance service (#4472)

* Fix symbol validation * Add test cases
4 weeks ago · c467c946d4
parent a6952a0e37
commit c467c946d4
3 changed files with 5 additions and 1 deletions
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@ -170,7 +170,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
            symbol = quotes[0].symbol;
          }
        } catch {}
-      } else if (symbol?.includes('-')) {
+      } else if (symbol?.endsWith(`-${DEFAULT_CURRENCY}`)) {
        throw new Error(`${symbol} is not valid`);
      } else {
        symbol = this.convertToYahooFinanceSymbol(symbol);
--- a/test/import/invalid-symbol-btc-usd.csv
+++ b/test/import/invalid-symbol-btc-usd.csv
@ -0,0 +1,2 @@
+Date,Code,Currency,Price,Quantity,Action,Fee
+12/12/2021,BTC-USD,USD,44558.42,1,buy,0
--- a/test/import/ok-btcusd.csv
+++ b/test/import/ok-btcusd.csv
@ -0,0 +1,2 @@
+Date,Code,Currency,Price,Quantity,Action,Fee
+12/12/2021,BTCUSD,USD,44558.42,1,buy,0