From c47578bd3e9c8b9e804290806b9e3d187171db8c Mon Sep 17 00:00:00 2001 From: Thomas <4159106+dtslvr@users.noreply.github.com> Date: Sun, 1 Aug 2021 00:09:27 +0200 Subject: [PATCH] Clean up --- apps/api/src/app/core/current-rate.service.ts | 4 ++-- apps/api/src/app/core/portfolio-calculator.ts | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/api/src/app/core/current-rate.service.ts b/apps/api/src/app/core/current-rate.service.ts index 6e7a0e202..7cab79808 100644 --- a/apps/api/src/app/core/current-rate.service.ts +++ b/apps/api/src/app/core/current-rate.service.ts @@ -79,13 +79,13 @@ export class CurrentRateService { const result = []; for (const symbol of symbols) { result.push({ + symbol, date: today, marketPrice: this.exchangeRateDataService.toCurrency( dataResultProvider?.[symbol]?.marketPrice ?? 0, dataResultProvider?.[symbol]?.currency, userCurrency - ), - symbol: symbol + ) }); } return result; diff --git a/apps/api/src/app/core/portfolio-calculator.ts b/apps/api/src/app/core/portfolio-calculator.ts index ebfbc3803..de62ec597 100644 --- a/apps/api/src/app/core/portfolio-calculator.ts +++ b/apps/api/src/app/core/portfolio-calculator.ts @@ -300,8 +300,8 @@ export class PortfolioCalculator { return { ...overall, - hasErrors: hasErrors || overall.hasErrors, - positions + positions, + hasErrors: hasErrors || overall.hasErrors }; } @@ -426,11 +426,11 @@ export class PortfolioCalculator { } return { currentValue, - totalInvestment, grossPerformance, + hasErrors, + totalInvestment, grossPerformancePercentage: - grossPerformancePercentage.div(completeInitialValue), - hasErrors + grossPerformancePercentage.div(completeInitialValue) }; }