From c4a62dfd689900197833c1d9ed97d36d0cb17ca6 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 30 Jul 2023 19:36:06 +0200 Subject: [PATCH] Bugfix/remove stay signed in setting from local storage on sign in with fingerprint activation (#2196) * Remove staySignedIn from local storage * Update changelog --- CHANGELOG.md | 4 +++ .../pages/account/account-page.component.ts | 7 ++++ .../src/app/pages/account/account-page.html | 7 +++- apps/client/src/locales/messages.de.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.es.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.fr.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.it.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.nl.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.pt.xlf | 36 +++++++++++-------- apps/client/src/locales/messages.xlf | 33 ++++++++++------- 10 files changed, 169 insertions(+), 98 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 606cc970a..846f9c433 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added a step by step introduction for new users +### Fixed + +- Removed the _Stay signed in_ setting on _Sign in with fingerprint_ activation + ## 1.294.0 - 2023-07-29 ### Changed diff --git a/apps/client/src/app/pages/account/account-page.component.ts b/apps/client/src/app/pages/account/account-page.component.ts index 8f039b177..5ab140265 100644 --- a/apps/client/src/app/pages/account/account-page.component.ts +++ b/apps/client/src/app/pages/account/account-page.component.ts @@ -15,6 +15,10 @@ import { import { ActivatedRoute, Router } from '@angular/router'; import { CreateAccessDto } from '@ghostfolio/api/app/access/create-access.dto'; import { DataService } from '@ghostfolio/client/services/data.service'; +import { + STAY_SIGNED_IN, + SettingsStorageService +} from '@ghostfolio/client/services/settings-storage.service'; import { UserService } from '@ghostfolio/client/services/user/user.service'; import { WebAuthnService } from '@ghostfolio/client/services/web-authn.service'; import { getDateFormatString } from '@ghostfolio/common/helper'; @@ -80,6 +84,7 @@ export class AccountPageComponent implements OnDestroy, OnInit { private snackBar: MatSnackBar, private route: ActivatedRoute, private router: Router, + private settingsStorageService: SettingsStorageService, private stripeService: StripeService, private userService: UserService, public webAuthnService: WebAuthnService @@ -397,6 +402,8 @@ export class AccountPageComponent implements OnDestroy, OnInit { }) ) .subscribe(() => { + this.settingsStorageService.removeSetting(STAY_SIGNED_IN); + this.update(); }); } diff --git a/apps/client/src/app/pages/account/account-page.html b/apps/client/src/app/pages/account/account-page.html index 7f9fb57a5..fbf14544a 100644 --- a/apps/client/src/app/pages/account/account-page.html +++ b/apps/client/src/app/pages/account/account-page.html @@ -235,7 +235,12 @@
-
Sign in with fingerprint
+
+
Biometric Authentication
+
+ Sign in with fingerprint +
+
Bitte gebe deinen Gutscheincode ein: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1578,7 +1578,7 @@ Gutscheincode konnte nicht eingelöst werden apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1586,7 +1586,7 @@ Gutscheincode wurde eingelöst apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1594,7 +1594,7 @@ Neu laden apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1602,7 +1602,7 @@ Möchtest du diese Anmeldemethode wirklich löschen? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -1705,12 +1705,12 @@ 193 - - Sign in with fingerprint - Einloggen mit Fingerabdruck + + Sign in with fingerprint + Einloggen mit Fingerabdruck apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -1718,7 +1718,7 @@ Benutzer ID apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -1726,7 +1726,7 @@ Zugangsberechtigung apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -2830,7 +2830,7 @@ Experimentelle Funktionen apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2878,7 +2878,7 @@ Automatisch apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -3450,7 +3450,7 @@ Vorschau auf kommende Funktionalität apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7173,6 +7173,14 @@ 50 + + Biometric Authentication + Biometrische Authentifizierung + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.es.xlf b/apps/client/src/locales/messages.es.xlf index ece061931..ae328a258 100644 --- a/apps/client/src/locales/messages.es.xlf +++ b/apps/client/src/locales/messages.es.xlf @@ -1571,7 +1571,7 @@ Por favor, ingresa tu código de cupón: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1579,7 +1579,7 @@ No se puede canjear este código de cupón apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1587,7 +1587,7 @@ El codigo de cupón ha sido canjeado apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1595,7 +1595,7 @@ Refrescar apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1603,7 +1603,7 @@ ¿Estás seguro de eliminar este método de acceso? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -1706,12 +1706,12 @@ 193 - - Sign in with fingerprint - Accede con huella digital + + Sign in with fingerprint + Accede con huella digital apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -1719,7 +1719,7 @@ ID usuario apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -1727,7 +1727,7 @@ Acceso concedido apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -2831,7 +2831,7 @@ Funcionalidades experimentales apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2879,7 +2879,7 @@ Automático apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -3451,7 +3451,7 @@ Sneak peek at upcoming functionality apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7174,6 +7174,14 @@ 50 + + Biometric Authentication + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.fr.xlf b/apps/client/src/locales/messages.fr.xlf index 9e6fa9956..9e180d3c3 100644 --- a/apps/client/src/locales/messages.fr.xlf +++ b/apps/client/src/locales/messages.fr.xlf @@ -1854,7 +1854,7 @@ Auto apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -1862,7 +1862,7 @@ Veuillez entrer votre code promotionnel : apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1870,7 +1870,7 @@ Le code promotionnel n'a pas pu être appliqué apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1878,7 +1878,7 @@ Le code promotionnel a été appliqué apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1886,7 +1886,7 @@ Rafraîchir apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1894,7 +1894,7 @@ Voulez-vous vraiment supprimer cette méthode de connexion ? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -2069,12 +2069,12 @@ 193 - - Sign in with fingerprint - Se connecter avec empreinte + + Sign in with fingerprint + Se connecter avec empreinte apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -2082,7 +2082,7 @@ Fonctionnalités expérimentales apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2090,7 +2090,7 @@ ID d'utilisateur apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -2098,7 +2098,7 @@ Accès donné apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -3450,7 +3450,7 @@ Avant-première de fonctionnalités futures apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7173,6 +7173,14 @@ 50 + + Biometric Authentication + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.it.xlf b/apps/client/src/locales/messages.it.xlf index ab025a78d..fe6790a6b 100644 --- a/apps/client/src/locales/messages.it.xlf +++ b/apps/client/src/locales/messages.it.xlf @@ -1571,7 +1571,7 @@ Inserisci il tuo codice del buono: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1579,7 +1579,7 @@ Impossibile riscattare il codice del buono apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1587,7 +1587,7 @@ Il codice del buono è stato riscattato apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1595,7 +1595,7 @@ Ricarica apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1603,7 +1603,7 @@ Vuoi davvero rimuovere questo metodo di accesso? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -1706,12 +1706,12 @@ 193 - - Sign in with fingerprint - Accesso con impronta digitale + + Sign in with fingerprint + Accesso con impronta digitale apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -1719,7 +1719,7 @@ ID utente apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -1727,7 +1727,7 @@ Accesso concesso apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -2831,7 +2831,7 @@ Funzionalità sperimentali apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2879,7 +2879,7 @@ Auto apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -3451,7 +3451,7 @@ Sneak peek at upcoming functionality apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7174,6 +7174,14 @@ 50 + + Biometric Authentication + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.nl.xlf b/apps/client/src/locales/messages.nl.xlf index 890ccd76b..0828e4feb 100644 --- a/apps/client/src/locales/messages.nl.xlf +++ b/apps/client/src/locales/messages.nl.xlf @@ -1570,7 +1570,7 @@ Voer uw couponcode in: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1578,7 +1578,7 @@ Kon kortingscode niet inwisselen apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1586,7 +1586,7 @@ Couponcode is ingewisseld apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1594,7 +1594,7 @@ Herladen apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1602,7 +1602,7 @@ Wilt u deze aanmeldingsmethode echt verwijderen? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -1705,12 +1705,12 @@ 193 - - Sign in with fingerprint - Aanmelden met vingerafdruk + + Sign in with fingerprint + Aanmelden met vingerafdruk apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -1718,7 +1718,7 @@ Gebruikers-ID apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -1726,7 +1726,7 @@ Verleende toegang apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -2830,7 +2830,7 @@ Experimentele functies apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2878,7 +2878,7 @@ Auto apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -3450,7 +3450,7 @@ Sneak peek at upcoming functionality apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7173,6 +7173,14 @@ 50 + + Biometric Authentication + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.pt.xlf b/apps/client/src/locales/messages.pt.xlf index c1e52204e..20230a94d 100644 --- a/apps/client/src/locales/messages.pt.xlf +++ b/apps/client/src/locales/messages.pt.xlf @@ -1838,7 +1838,7 @@ Auto apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -1846,7 +1846,7 @@ Por favor, insira o seu código de cupão: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 @@ -1854,7 +1854,7 @@ Não foi possível resgatar o código de cupão apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 @@ -1862,7 +1862,7 @@ Código de cupão foi resgatado apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 @@ -1870,7 +1870,7 @@ Atualizar apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 @@ -1878,7 +1878,7 @@ Deseja realmente remover este método de início de sessão? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -2033,12 +2033,12 @@ 214 - - Sign in with fingerprint - Iniciar sessão com impressão digital + + Sign in with fingerprint + Iniciar sessão com impressão digital apps/client/src/app/pages/account/account-page.html - 238 + 240,242 @@ -2046,7 +2046,7 @@ Funcionalidades Experimentais apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2054,7 +2054,7 @@ ID do Utilizador apps/client/src/app/pages/account/account-page.html - 268 + 273 @@ -2062,7 +2062,7 @@ Acesso Concedido apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -3450,7 +3450,7 @@ Acesso antecipado a funcionalidades futuras apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -7173,6 +7173,14 @@ 50 + + Biometric Authentication + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + + diff --git a/apps/client/src/locales/messages.xlf b/apps/client/src/locales/messages.xlf index 5c20aba99..a2745271d 100644 --- a/apps/client/src/locales/messages.xlf +++ b/apps/client/src/locales/messages.xlf @@ -1447,35 +1447,35 @@ Please enter your coupon code: apps/client/src/app/pages/account/account-page.component.ts - 236 + 241 Could not redeem coupon code apps/client/src/app/pages/account/account-page.component.ts - 246 + 251 Coupon code has been redeemed apps/client/src/app/pages/account/account-page.component.ts - 258 + 263 Reload apps/client/src/app/pages/account/account-page.component.ts - 259 + 264 Do you really want to remove this sign in method? apps/client/src/app/pages/account/account-page.component.ts - 305 + 310 @@ -1567,25 +1567,25 @@ 193 - - Sign in with fingerprint + + Sign in with fingerprint apps/client/src/app/pages/account/account-page.html - 238 + 240,242 User ID apps/client/src/app/pages/account/account-page.html - 268 + 273 Granted Access apps/client/src/app/pages/account/account-page.html - 277 + 282 @@ -2579,7 +2579,7 @@ Experimental Features apps/client/src/app/pages/account/account-page.html - 253 + 258 @@ -2628,7 +2628,7 @@ Auto apps/client/src/app/pages/account/account-page.component.ts - 42 + 46 @@ -3129,7 +3129,7 @@ Sneak peek at upcoming functionality apps/client/src/app/pages/account/account-page.html - 254,256 + 259,261 @@ -6722,6 +6722,13 @@ 50 + + Biometric Authentication + + apps/client/src/app/pages/account/account-page.html + 239 + +