From d4afa0350593fa74b1b375cfed5ec41e6fd43b7c Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 3 Feb 2024 09:42:50 +0100 Subject: [PATCH] Bugfix/fix rendering issue with date range selector of assistant (#2950) * Improve click handling * Improve locales * Update changelog --- CHANGELOG.md | 1 + apps/client/src/locales/messages.de.xlf | 34 +- apps/client/src/locales/messages.es.xlf | 34 +- apps/client/src/locales/messages.fr.xlf | 34 +- apps/client/src/locales/messages.it.xlf | 34 +- apps/client/src/locales/messages.nl.xlf | 34 +- apps/client/src/locales/messages.pl.xlf | 34 +- apps/client/src/locales/messages.pt.xlf | 34 +- apps/client/src/locales/messages.tr.xlf | 34 +- apps/client/src/locales/messages.xlf | 32 +- .../src/lib/assistant/assistant.component.ts | 7 +- libs/ui/src/lib/assistant/assistant.html | 306 +++++++++--------- 12 files changed, 382 insertions(+), 236 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cea3ec2f..34b6234b9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Fixed a rendering issue caused by the date range selector in the assistant (experimental) - Fixed an issue with the currency conversion in the investment timeline - Fixed the export in the lazy-loaded activities table on the portfolio activities page (experimental) diff --git a/apps/client/src/locales/messages.de.xlf b/apps/client/src/locales/messages.de.xlf index 2e3e20ed3..a9d6f5bb3 100644 --- a/apps/client/src/locales/messages.de.xlf +++ b/apps/client/src/locales/messages.de.xlf @@ -862,7 +862,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1556,7 +1556,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1644,7 +1644,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1656,7 +1656,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13356,7 +13356,7 @@ Finde Position... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14624,7 +14624,7 @@ Kein Tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14772,7 +14772,7 @@ Kein Konto libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14783,12 +14783,28 @@ 57 - + Reset Filters Filter zurücksetzen libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + Jahr + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + Jahre + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.es.xlf b/apps/client/src/locales/messages.es.xlf index a684f8b91..fb5ace3a9 100644 --- a/apps/client/src/locales/messages.es.xlf +++ b/apps/client/src/locales/messages.es.xlf @@ -863,7 +863,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1554,7 +1554,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1642,7 +1642,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1654,7 +1654,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13354,7 +13354,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14622,7 +14622,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14770,7 +14770,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14781,12 +14781,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.fr.xlf b/apps/client/src/locales/messages.fr.xlf index e845aca1e..769a57597 100644 --- a/apps/client/src/locales/messages.fr.xlf +++ b/apps/client/src/locales/messages.fr.xlf @@ -962,7 +962,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1078,7 +1078,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1981,7 +1981,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1993,7 +1993,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13353,7 +13353,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14621,7 +14621,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14769,7 +14769,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14780,12 +14780,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.it.xlf b/apps/client/src/locales/messages.it.xlf index 5f6fcfb33..2e5e86c11 100644 --- a/apps/client/src/locales/messages.it.xlf +++ b/apps/client/src/locales/messages.it.xlf @@ -863,7 +863,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1554,7 +1554,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1642,7 +1642,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1654,7 +1654,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13354,7 +13354,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14622,7 +14622,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14770,7 +14770,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14781,12 +14781,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.nl.xlf b/apps/client/src/locales/messages.nl.xlf index df9529d35..28d9fee9a 100644 --- a/apps/client/src/locales/messages.nl.xlf +++ b/apps/client/src/locales/messages.nl.xlf @@ -862,7 +862,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1553,7 +1553,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1641,7 +1641,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1653,7 +1653,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13353,7 +13353,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14621,7 +14621,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14769,7 +14769,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14780,12 +14780,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.pl.xlf b/apps/client/src/locales/messages.pl.xlf index 48ffb51e2..e733ffdb4 100644 --- a/apps/client/src/locales/messages.pl.xlf +++ b/apps/client/src/locales/messages.pl.xlf @@ -2662,7 +2662,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -2714,7 +2714,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -3704,7 +3704,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -3716,7 +3716,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13144,7 +13144,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14624,7 +14624,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14772,7 +14772,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14783,12 +14783,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.pt.xlf b/apps/client/src/locales/messages.pt.xlf index 4e56ab8dd..07bbb65a5 100644 --- a/apps/client/src/locales/messages.pt.xlf +++ b/apps/client/src/locales/messages.pt.xlf @@ -946,7 +946,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -1885,7 +1885,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -1957,7 +1957,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -1969,7 +1969,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13353,7 +13353,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14621,7 +14621,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14769,7 +14769,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14780,12 +14780,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.tr.xlf b/apps/client/src/locales/messages.tr.xlf index bb32d62c5..0e6702cee 100644 --- a/apps/client/src/locales/messages.tr.xlf +++ b/apps/client/src/locales/messages.tr.xlf @@ -2462,7 +2462,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -2574,7 +2574,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -3545,7 +3545,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -3557,7 +3557,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13353,7 +13353,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14621,7 +14621,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14769,7 +14769,7 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 @@ -14780,12 +14780,28 @@ 57 - + Reset Filters Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 + + + + year + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 diff --git a/apps/client/src/locales/messages.xlf b/apps/client/src/locales/messages.xlf index bfcf44305..d5d9efca4 100644 --- a/apps/client/src/locales/messages.xlf +++ b/apps/client/src/locales/messages.xlf @@ -2564,7 +2564,7 @@ libs/ui/src/lib/assistant/assistant.html - 118 + 117 @@ -2611,7 +2611,7 @@ libs/ui/src/lib/assistant/assistant.html - 139 + 138 @@ -3501,7 +3501,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 111 + 112 @@ -3512,7 +3512,7 @@ libs/ui/src/lib/assistant/assistant.component.ts - 112 + 115 @@ -13443,7 +13443,7 @@ Find holding... libs/ui/src/lib/assistant/assistant.component.ts - 120 + 123 @@ -14027,7 +14027,7 @@ No tag libs/ui/src/lib/assistant/assistant.html - 145 + 144 @@ -14158,14 +14158,14 @@ No account libs/ui/src/lib/assistant/assistant.html - 124 + 123 - + Reset Filters libs/ui/src/lib/assistant/assistant.html - 164 + 163 @@ -14175,6 +14175,20 @@ 57 + + year + + libs/ui/src/lib/assistant/assistant.component.ts + 110 + + + + years + + libs/ui/src/lib/assistant/assistant.component.ts + 112 + + diff --git a/libs/ui/src/lib/assistant/assistant.component.ts b/libs/ui/src/lib/assistant/assistant.component.ts index 65c9e37fc..0996d90e6 100644 --- a/libs/ui/src/lib/assistant/assistant.component.ts +++ b/libs/ui/src/lib/assistant/assistant.component.ts @@ -107,8 +107,11 @@ export class AssistantComponent implements OnChanges, OnDestroy, OnInit { label: $localize`Year to date` + ' (' + $localize`YTD` + ')', value: 'ytd' }, - { label: $localize`1Y`, value: '1y' }, - { label: $localize`5Y`, value: '5y' }, + { label: '1 ' + $localize`year` + ' (' + $localize`1Y` + ')', value: '1y' }, + { + label: '5 ' + $localize`years` + ' (' + $localize`5Y` + ')', + value: '5y' + }, { label: $localize`Max`, value: 'max' } ]; public filterForm = this.formBuilder.group({ diff --git a/libs/ui/src/lib/assistant/assistant.html b/libs/ui/src/lib/assistant/assistant.html index 682d2227e..51070a642 100644 --- a/libs/ui/src/lib/assistant/assistant.html +++ b/libs/ui/src/lib/assistant/assistant.html @@ -1,169 +1,169 @@ -
-
- - -
- / -
- - -
+
-
-
Holdings
- + + - - + / +
+ + +
+
+
+
Holdings
+ + + +
No entries...
+
+
+
+
Asset Profiles
+ -
No entries...
- -
-
-
Asset Profiles
- - - + -
No entries...
-
+ /> +
No entries...
+ +
-
-
-
-
- - Date Range - - @for (range of dateRangeOptions; track range) { - {{ range.label }} - } - - -
- +
- - Accounts -
- - No account - @for (account of accounts; track account.id) { - {{ account.name }} - } - -
-
- - Tags -
- - No tag - @for (tag of tags; track tag.id) { - {{ tag.name }} +
+ + Date Range + + @for (range of dateRangeOptions; track range) { + {{ range.label }} } - -
- - -
-
+ - Reset Filters - + + Accounts +
+ + No account + @for (account of accounts; track account.id) { + {{ account.name }} + } + +
+
+ + Tags +
+ + No tag + @for (tag of tags; track tag.id) { + {{ tag.name }} + } + +
+
+
+
+ +
-
- + +