Feature/switch typescript-eslint no-unused-expressions rule to error (#3872)

* Switch @typescript-eslint/no-unused-expressions to error (remove from eslint configuration)

.eslintrc.json

@@ -107,7 +107,6 @@
         "@typescript-eslint/no-unsafe-argument": "warn",
         "@typescript-eslint/no-unsafe-assignment": "warn",
         "@typescript-eslint/no-unsafe-enum-comparison": "warn",
-        "@typescript-eslint/no-unused-expressions": "warn",
         "@typescript-eslint/no-unsafe-member-access": "warn",
         "@typescript-eslint/no-unsafe-return": "warn",
         "@typescript-eslint/no-unused-vars": "warn",

libs/ui/src/lib/activities-table/activities-table.component.ts

@@ -269,9 +269,13 @@ export class GfActivitiesTableComponent
   }
 
   public toggleAllRows() {
-    this.areAllRowsSelected()
-      ? this.selectedRows.clear()
-      : this.dataSource.data.forEach((row) => this.selectedRows.select(row));
+    if (this.areAllRowsSelected()) {
+      this.selectedRows.clear();
+    } else {
+      this.dataSource.data.forEach((row) => {
+        this.selectedRows.select(row);
+      });
+    }
 
     this.selectedActivities.emit(this.selectedRows.selected);
   }