From aedce941e310499709f08e5a125377d90fd424f0 Mon Sep 17 00:00:00 2001 From: she11sh0cked <22623152+she11sh0cked@users.noreply.github.com> Date: Wed, 20 Mar 2024 15:09:55 +0100 Subject: [PATCH] fix(logging): add error log when getting services from Docker server Not raising an error when a server fails to get services from Docker could lead to confusion when the server does not appear to be functioning correctly. This commit adds an error log when a server fails to get services from Docker. --- src/utils/config/service-helpers.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/utils/config/service-helpers.js b/src/utils/config/service-helpers.js index de129f577..c4ca2a65b 100644 --- a/src/utils/config/service-helpers.js +++ b/src/utils/config/service-helpers.js @@ -117,6 +117,8 @@ export async function servicesFromDocker() { return { server: serverName, services: discovered.filter((filteredService) => filteredService) }; } catch (e) { + logger.error("Error getting services from Docker server '%s': %s", serverName, e); + // a server failed, but others may succeed return { server: serverName, services: [] }; }