From ec1cf2f3ca36b8403864c75191aa06e789081c57 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Fri, 15 Sep 2023 08:00:08 -0700 Subject: [PATCH] Resolve bad setState warning in tabprovider (#1993) --- src/pages/index.jsx | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/pages/index.jsx b/src/pages/index.jsx index 0263c5531..e6d4a70dc 100644 --- a/src/pages/index.jsx +++ b/src/pages/index.jsx @@ -244,14 +244,16 @@ function Home({ initialSettings }) { ) ], [settings.layout]); - if (!activeTab) { - const initialTab = decodeURI(asPath.substring(asPath.indexOf("#") + 1)); - if (initialTab !== '/') { - setActiveTab(initialTab) - } else { - setActiveTab(tabs['0'] ?? false) + useEffect(() => { + if (!activeTab) { + const initialTab = decodeURI(asPath.substring(asPath.indexOf("#") + 1)); + if (initialTab !== '/') { + setActiveTab(initialTab) + } else { + setActiveTab(tabs['0'] ?? false) + } } - } + }) const servicesAndBookmarksGroups = useMemo(() => { const tabGroupFilter = g => g && [activeTab, undefined].includes(settings.layout?.[g.name]?.tab);