Merge pull request #184 from Bond-009/warnings

[WIP] Remove warnings

DvdLib/Ifo/ProgramChain.cs

@@ -35,7 +35,6 @@ namespace DvdLib.Ifo
         private ushort _goupProgramNumber;
         public readonly ProgramChain Goup; // ?? maybe Group
 
-        private byte _playbackMode;
         public ProgramPlaybackMode PlaybackMode { get; private set; }
         public uint ProgramCount { get; private set; }
 

Emby.IsoMounting/IsoMounter/LinuxIsoManager.cs

@@ -144,24 +144,17 @@ namespace IsoMounter
             return Task.FromResult(false);
         }
 
-        public async Task<IIsoMount> Mount(string isoPath, CancellationToken cancellationToken)
+        public Task<IIsoMount> Mount(string isoPath, CancellationToken cancellationToken)
         {
-
-            LinuxMount mountedISO;
-
-            if (MountISO(isoPath, out mountedISO)) {
-
-                return mountedISO;
-
-            }else{
-                
+            if (MountISO(isoPath, out LinuxMount mountedISO)) {
+                return Task.FromResult<IIsoMount>(mountedISO);
+            }
+            else {
                 throw new IOException(String.Format(
                     "An error occurred trying to mount image [$0].",
                     isoPath
                 ));
-
             }
-
         }
 
         #endregion

Emby.IsoMounting/IsoMounter/LinuxMount.cs

@@ -1,8 +1,5 @@
 using System;
-using MediaBrowser.Model.Diagnostics;
 using MediaBrowser.Model.IO;
-using MediaBrowser.Model.Logging;
-using MediaBrowser.Model.System;
 
 namespace IsoMounter
 {

Emby.Server.Implementations/Library/LibraryManager.cs

@@ -3179,4 +3179,4 @@ namespace Emby.Server.Implementations.Library
             CollectionFolder.SaveLibraryOptions(virtualFolderPath, libraryOptions);
         }
     }
-}
+}

Mono.Nat/Pmp/PmpNatDevice.cs

@@ -109,7 +109,7 @@ namespace Mono.Nat.Pmp
 
                         if (attempt == 0)
                         {
-                            Task.Run(() => CreatePortMapListen(udpClient, mapping, cancellationTokenSource.Token));
+                            await Task.Run(() => CreatePortMapListen(udpClient, mapping, cancellationTokenSource.Token));
                         }
 
                         attempt++;
@@ -214,4 +214,4 @@ namespace Mono.Nat.Pmp
                 this.localAddress, this.publicAddress, this.LastSeen);
         }
     }
-}
+}

RSSDP/DiscoveredSsdpDevice.cs

@@ -17,7 +17,6 @@ namespace Rssdp
 
 		#region Fields
 
-		private SsdpRootDevice _Device;
 		private DateTimeOffset _AsAt;
 
 		#endregion
@@ -55,7 +54,6 @@ namespace Rssdp
 				if (_AsAt != value)
 				{
 					_AsAt = value;
-					_Device = null;
 				}
 			}
 		}
@@ -93,4 +91,4 @@ namespace Rssdp
 
 		#endregion
 	}
-}
+}

RSSDP/SsdpDeviceLocator.cs

@@ -124,7 +124,7 @@ namespace Rssdp.Infrastructure
             {
                 await SearchAsync(CancellationToken.None).ConfigureAwait(false);
             }
-            catch (Exception ex)
+            catch (Exception)
             {
 
             }
@@ -621,4 +621,4 @@ namespace Rssdp.Infrastructure
         #endregion
 
     }
-}
+}

RSSDP/SsdpDevicePublisher.cs

@@ -310,11 +310,16 @@ namespace Rssdp.Infrastructure
 
             try
             {
-                await _CommsServer.SendMessage(System.Text.Encoding.UTF8.GetBytes(message), endPoint, receivedOnlocalIpAddress, cancellationToken).ConfigureAwait(false);
+                await _CommsServer.SendMessage(
+                        System.Text.Encoding.UTF8.GetBytes(message),
+                        endPoint,
+                        receivedOnlocalIpAddress,
+                        cancellationToken)
+                    .ConfigureAwait(false);
             }
-            catch (Exception ex)
+            catch (Exception)
             {
-                
+
             }
 
             //WriteTrace(String.Format("Sent search response to " + endPoint.ToString()), device);
@@ -558,4 +563,4 @@ namespace Rssdp.Infrastructure
             }
         }
     }
-}
+}

SocketHttpListener/Net/HttpListenerContext.cs

@@ -1,19 +1,13 @@
 using System;
 using System.Net;
 using System.Security.Principal;
-using MediaBrowser.Model.Cryptography;
-using MediaBrowser.Model.IO;
-using MediaBrowser.Model.Logging;
-using MediaBrowser.Model.Text;
 using SocketHttpListener.Net.WebSockets;
-using SocketHttpListener.Primitives;
 using System.Threading.Tasks;
 
 namespace SocketHttpListener.Net
 {
     public sealed unsafe partial class HttpListenerContext
     {
-        internal HttpListener _listener;
         private HttpListenerResponse _response;
         private IPrincipal _user;
 

SocketHttpListener/Net/HttpListenerRequestUriBuilder.cs

@@ -253,7 +253,7 @@ namespace SocketHttpListener.Net
                 //if (NetEventSource.IsEnabled)
                 //    NetEventSource.Error(this, SR.Format(SR.net_log_listener_cant_convert_percent_value, codePoint));
             }
-            catch (EncoderFallbackException e)
+            catch (EncoderFallbackException)
             {
                 // If utf8Encoding.GetBytes() fails
                 //if (NetEventSource.IsEnabled) NetEventSource.Error(this, SR.Format(SR.net_log_listener_cant_convert_to_utf8, unicodeString, e.Message));
@@ -303,11 +303,11 @@ namespace SocketHttpListener.Net
 
                 return true;
             }
-            catch (DecoderFallbackException e)
+            catch (DecoderFallbackException)
             {
                 //if (NetEventSource.IsEnabled) NetEventSource.Error(this, SR.Format(SR.net_log_listener_cant_convert_bytes, GetOctetsAsString(_rawOctets), e.Message));
             }
-            catch (EncoderFallbackException e)
+            catch (EncoderFallbackException)
             {
                 // If utf8Encoding.GetBytes() fails
                 //if (NetEventSource.IsEnabled) NetEventSource.Error(this, SR.Format(SR.net_log_listener_cant_convert_to_utf8, decodedString, e.Message));

SocketHttpListener/WebSocket.cs

@@ -299,7 +299,7 @@ namespace SocketHttpListener
                 }
                 OnError.Emit(this, new ErrorEventArgs(message));
             }
-            catch (Exception ex)
+            catch (Exception)
             {
             }
         }
@@ -310,7 +310,7 @@ namespace SocketHttpListener
             {
                 OnError.Emit(this, new ErrorEventArgs(message));
             }
-            catch (Exception ex)
+            catch (Exception)
             {
             }
         }
@@ -423,8 +423,6 @@ namespace SocketHttpListener
 
         private bool processPingFrame(WebSocketFrame frame)
         {
-            var mask = Mask.Unmask;
-
             return true;
         }
 
@@ -796,4 +794,4 @@ namespace SocketHttpListener
 
         #endregion
     }
-}
+}