From 13152bf09dcadf8807e1240be7ca84662d2ed397 Mon Sep 17 00:00:00 2001
From: Bond_009 <bond.009@outlook.com>
Date: Fri, 21 Apr 2023 14:05:27 +0200
Subject: [PATCH] Change number of read connections based on # of threads and
 add comments

---
 .../Data/ConnectionPool.cs                    | 19 +++++++++++++++++--
 .../Data/SqliteItemRepository.cs              |  2 +-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/Emby.Server.Implementations/Data/ConnectionPool.cs b/Emby.Server.Implementations/Data/ConnectionPool.cs
index 091a1b74f3..6d28a5e43d 100644
--- a/Emby.Server.Implementations/Data/ConnectionPool.cs
+++ b/Emby.Server.Implementations/Data/ConnectionPool.cs
@@ -1,16 +1,22 @@
-#pragma warning disable CS1591
-
 using System;
 using System.Collections.Concurrent;
 using SQLitePCL.pretty;
 
 namespace Emby.Server.Implementations.Data;
 
+/// <summary>
+/// A pool of SQLite Database connections.
+/// </summary>
 public sealed class ConnectionPool : IDisposable
 {
     private readonly BlockingCollection<SQLiteDatabaseConnection> _connections = new();
     private bool _disposed;
 
+    /// <summary>
+    /// Initializes a new instance of the <see cref="ConnectionPool" /> class.
+    /// </summary>
+    /// <param name="count">The number of database connection to create.</param>
+    /// <param name="factory">Factory function to create the database connections.</param>
     public ConnectionPool(int count, Func<SQLiteDatabaseConnection> factory)
     {
         for (int i = 0; i < count; i++)
@@ -19,6 +25,10 @@ public sealed class ConnectionPool : IDisposable
         }
     }
 
+    /// <summary>
+    /// Gets a database connection from the pool if one is available, otherwise blocks.
+    /// </summary>
+    /// <returns>A database connection.</returns>
     public ManagedConnection GetConnection()
     {
         if (_disposed)
@@ -34,6 +44,10 @@ public sealed class ConnectionPool : IDisposable
         }
     }
 
+    /// <summary>
+    /// Return a database connection to the pool.
+    /// </summary>
+    /// <param name="connection">The database connection to return.</param>
     public void Return(SQLiteDatabaseConnection connection)
     {
         if (_disposed)
@@ -45,6 +59,7 @@ public sealed class ConnectionPool : IDisposable
         _connections.Add(connection);
     }
 
+    /// <inheritdoc />
     public void Dispose()
     {
         if (_disposed)
diff --git a/Emby.Server.Implementations/Data/SqliteItemRepository.cs b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
index 33466c34b0..22d485d335 100644
--- a/Emby.Server.Implementations/Data/SqliteItemRepository.cs
+++ b/Emby.Server.Implementations/Data/SqliteItemRepository.cs
@@ -336,7 +336,7 @@ namespace Emby.Server.Implementations.Data
             _jsonOptions = JsonDefaults.Options;
 
             DbFilePath = Path.Combine(_config.ApplicationPaths.DataPath, "library.db");
-            ReadConnectionsCount = 5;
+            ReadConnectionsCount = Environment.ProcessorCount * 2;
         }
 
         /// <inheritdoc />