From fdb489ae477bfac2ad738227e9d5ea657f4fc395 Mon Sep 17 00:00:00 2001 From: reuterma24 Date: Sun, 12 Jan 2025 18:54:19 +0100 Subject: [PATCH 1/2] improve parameter documentation for ContainsContainer method in ContainerHelper class --- MediaBrowser.Model/Extensions/ContainerHelper.cs | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/MediaBrowser.Model/Extensions/ContainerHelper.cs b/MediaBrowser.Model/Extensions/ContainerHelper.cs index c86328ba68..39e5358bac 100644 --- a/MediaBrowser.Model/Extensions/ContainerHelper.cs +++ b/MediaBrowser.Model/Extensions/ContainerHelper.cs @@ -14,7 +14,8 @@ public static class ContainerHelper /// in . /// /// The comma-delimited string being searched. - /// If the parameter begins with the - character, the operation is reversed. + /// If the parameter begins with the - character, the operation is reversed. + /// If the parameter is empty or null, all containers in will be accepted. /// The comma-delimited string being matched. /// The result of the operation. public static bool ContainsContainer(string? profileContainers, string? inputContainer) @@ -34,7 +35,8 @@ public static class ContainerHelper /// in . /// /// The comma-delimited string being searched. - /// If the parameter begins with the - character, the operation is reversed. + /// If the parameter begins with the - character, the operation is reversed. + /// If the parameter is empty or null, all containers in will be accepted. /// The comma-delimited string being matched. /// The result of the operation. public static bool ContainsContainer(string? profileContainers, ReadOnlySpan inputContainer) @@ -53,7 +55,8 @@ public static class ContainerHelper /// Compares two containers, returning if an item in /// does not exist in . /// - /// The comma-delimited string being searched. + /// The comma-delimited string being searched. + /// If the parameter is empty or null, all containers in will be accepted. /// The boolean result to return if a match is not found. /// The comma-delimited string being matched. /// The result of the operation. @@ -71,7 +74,8 @@ public static class ContainerHelper /// Compares two containers, returning if an item in /// does not exist in . /// - /// The comma-delimited string being searched. + /// The comma-delimited string being searched. + /// If the parameter is empty or null, all containers in will be accepted. /// The boolean result to return if a match is not found. /// The comma-delimited string being matched. /// The result of the operation. @@ -106,7 +110,8 @@ public static class ContainerHelper /// Compares two containers, returning if an item in /// does not exist in . /// - /// The profile containers being matched searched. + /// The profile containers being matched searched. + /// If the parameter is empty or null, all containers in will be accepted. /// The boolean result to return if a match is not found. /// The comma-delimited string being matched. /// The result of the operation. From 5a02ea4a31cbefd877baf5351fe6a4e545ed24ce Mon Sep 17 00:00:00 2001 From: reuterma24 Date: Sun, 12 Jan 2025 18:57:29 +0100 Subject: [PATCH 2/2] added myself to CONTRIBUTORS.md --- CONTRIBUTORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index eccc3b0ceb..ae1a2fd71e 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -268,3 +268,4 @@ - [0x25CBFC4F](https://github.com/0x25CBFC4F) - [Robert Lützner](https://github.com/rluetzner) - [Nathan McCrina](https://github.com/nfmccrina) + - [Martin Reuter](https://github.com/reuterma24)