From 7cbff8d3f13382cef5942ad79f929ab41288cf46 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Thu, 10 Jan 2019 23:20:58 -0500 Subject: [PATCH 01/10] Update issue templates Adds issue templates for Bugs, Features, and Enhancements. --- .github/ISSUE_TEMPLATE/bug_report.md | 32 +++++++++++++++++++ .github/ISSUE_TEMPLATE/enhancement-request.md | 20 ++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 14 ++++++++ 3 files changed, 66 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/enhancement-request.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000000..c6d2b4bb38 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,32 @@ +--- +name: Bug report +about: Create a bug report +title: '' +labels: bug +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Go to '...' +2. Click on '....' +3. Scroll down to '....' +4. See error + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots** +If applicable, add screenshots to help explain your problem. + +**System (please complete the following information):** + - OS: [e.g. Docker, Debian, Windows] + - Browser [e.g. Firefox, Chrome, Safari] + - Version [e.g. 10.0.1] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/enhancement-request.md b/.github/ISSUE_TEMPLATE/enhancement-request.md new file mode 100644 index 0000000000..57c0d4cae2 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/enhancement-request.md @@ -0,0 +1,20 @@ +--- +name: Enhancement request +about: Suggest an modification to an existing feature +title: '' +labels: enhancement +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000000..a2ce072452 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,14 @@ +--- +name: Feature request +about: Suggest a new feature +title: '' +labels: feature +assignees: '' + +--- + +**Describe the feature you'd like** +A clear and concise description of what you want to happen. + +**Additional context** +Add any other context or screenshots about the feature request here. From 2e39a80c634b53a46edff784bdbb9d8306f81e41 Mon Sep 17 00:00:00 2001 From: Joshua Boniface Date: Thu, 10 Jan 2019 23:25:58 -0500 Subject: [PATCH 02/10] Update pull request template --- .github/pull_request_template.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..0edc492187 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,6 @@ +**Changes** +Describe your changes here in 1-5 sentences. + +**Issues** +Tag any issues that this PR solves here. +Fixes # From 54e2feabba5b871e36edee730dbc4fc440e8d489 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Thu, 10 Jan 2019 23:41:40 -0500 Subject: [PATCH 03/10] Update bug_report.md Add section about log files. --- .github/ISSUE_TEMPLATE/bug_report.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index c6d2b4bb38..e5210b1c4e 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -20,6 +20,9 @@ Steps to reproduce the behavior: **Expected behavior** A clear and concise description of what you expected to happen. +**Logs** +Please paste any log errors. + **Screenshots** If applicable, add screenshots to help explain your problem. From 2f31f9a38257bffcf09033d840b160445e002ec0 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Thu, 10 Jan 2019 23:42:56 -0500 Subject: [PATCH 04/10] Consistent formatting for System fields --- .github/ISSUE_TEMPLATE/bug_report.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index e5210b1c4e..b4e340d39c 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -28,8 +28,8 @@ If applicable, add screenshots to help explain your problem. **System (please complete the following information):** - OS: [e.g. Docker, Debian, Windows] - - Browser [e.g. Firefox, Chrome, Safari] - - Version [e.g. 10.0.1] + - Browser: [e.g. Firefox, Chrome, Safari] + - Version: [e.g. 10.0.1] **Additional context** Add any other context about the problem here. From fa4c6ee8b24bfd1e150083229f9d8d4b9c1a283c Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Fri, 11 Jan 2019 10:40:14 -0500 Subject: [PATCH 05/10] Add blurb about title --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0edc492187..9a0cde9be9 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,5 @@ +Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). + **Changes** Describe your changes here in 1-5 sentences. From b1406d33f15b75ff7ba791f514d1f6e922a81f36 Mon Sep 17 00:00:00 2001 From: Vasily Date: Fri, 11 Jan 2019 22:05:27 -0500 Subject: [PATCH 06/10] Be explcit about what the version is Co-Authored-By: joshuaboniface --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index b4e340d39c..4abd39cfc5 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -29,7 +29,7 @@ If applicable, add screenshots to help explain your problem. **System (please complete the following information):** - OS: [e.g. Docker, Debian, Windows] - Browser: [e.g. Firefox, Chrome, Safari] - - Version: [e.g. 10.0.1] + - Jellyfin Version: [e.g. 10.0.1] **Additional context** Add any other context about the problem here. From 7a3b01da1baa0ee0f503353f21f36c4904c981a3 Mon Sep 17 00:00:00 2001 From: Vasily Date: Fri, 11 Jan 2019 23:02:51 -0500 Subject: [PATCH 07/10] Add link to writing good messages article Co-Authored-By: joshuaboniface --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9a0cde9be9..ac1ddcb3ef 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,5 @@ Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). +For a good inspiration of what to write in commit messages and PR have a look at https://chris.beams.io/posts/git-commit/ **Changes** Describe your changes here in 1-5 sentences. From 53b8aa52e11c5d993aa57a9eb9f00838d7fdd1c8 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Fri, 11 Jan 2019 23:05:38 -0500 Subject: [PATCH 08/10] Add link to our contributing docs as well --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ac1ddcb3ef..b2b3cf241e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,5 +1,5 @@ Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). -For a good inspiration of what to write in commit messages and PR have a look at https://chris.beams.io/posts/git-commit/ +For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our https://jellyfin.readthedocs.io/en/latest/developer-docs/contributing/ page. **Changes** Describe your changes here in 1-5 sentences. From 2d9cf14a72ed38279381f112cf4273814c628758 Mon Sep 17 00:00:00 2001 From: Joshua Boniface Date: Fri, 11 Jan 2019 23:12:28 -0500 Subject: [PATCH 09/10] Add Master codeowners In conjunction with branch protection rules, this will require approval from the Org owners (myself or @nvllsvm) before a merge can be accepted. --- .github/CODEOWNERS | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..7185aa7321 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,4 @@ +# Jellyfin CODEOWNERS file (`master` branch) + +# Require org owner approvals for all files, when merging to master +* @joshuaboniface @nvllsvm From 36e09949be6add7b54038e460796aca7fd865468 Mon Sep 17 00:00:00 2001 From: Bond-009 Date: Sat, 12 Jan 2019 20:31:22 +0100 Subject: [PATCH 10/10] Revert "Add Master codeowners" --- .github/CODEOWNERS | 4 ---- 1 file changed, 4 deletions(-) delete mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index 7185aa7321..0000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,4 +0,0 @@ -# Jellyfin CODEOWNERS file (`master` branch) - -# Require org owner approvals for all files, when merging to master -* @joshuaboniface @nvllsvm