Reworked plugin loading to allow on the fly .dll replacement

pull/702/head
LukePulverenti Luke Pulverenti luke pulverenti 12 years ago
parent 8d0fede236
commit 77e81432f7

@ -96,8 +96,11 @@ namespace MediaBrowser.Common.Kernel
Directory.CreateDirectory(PluginsPath);
}
var catalog = new AggregateCatalog(Directory.GetDirectories(PluginsPath, "*", SearchOption.TopDirectoryOnly).Select(f => new DirectoryCatalog(f)));
// Gets all plugin assemblies by first reading all bytes of the .dll and calling Assembly.Load against that
// This will prevent the .dll file from getting locked, and allow us to replace it when needed
IEnumerable<Assembly> pluginAssemblies = Directory.GetFiles(PluginsPath, "*.dll", SearchOption.AllDirectories).Select(f => Assembly.Load(File.ReadAllBytes((f))));
var catalog = new AggregateCatalog(pluginAssemblies.Select(a => new AssemblyCatalog(a)));
//catalog.Catalogs.Add(new AssemblyCatalog(Assembly.GetExecutingAssembly()));
//catalog.Catalogs.Add(new AssemblyCatalog(GetType().Assembly));
@ -130,6 +133,12 @@ namespace MediaBrowser.Common.Kernel
{
foreach (BasePlugin plugin in Plugins)
{
Assembly assembly = plugin.GetType().Assembly;
AssemblyName assemblyName = assembly.GetName();
plugin.Version = assemblyName.Version;
plugin.Path = Path.Combine(PluginsPath, assemblyName.Name);
plugin.ReloadConfiguration();
if (plugin.Enabled)

@ -44,21 +44,9 @@ namespace MediaBrowser.Common.Plugins
{
public abstract string Name { get; }
public string Path
{
get
{
return System.IO.Path.GetDirectoryName(GetType().Assembly.Location);
}
}
public string Path { get; set; }
public Version Version
{
get
{
return GetType().Assembly.GetName().Version;
}
}
public Version Version { get; set; }
public BasePluginConfiguration Configuration { get; protected set; }

Loading…
Cancel
Save