Don't call tostring twice

4 years ago · bde8c00306
parent e337756428
commit bde8c00306
1 changed files with 3 additions and 2 deletions
--- a/MediaBrowser.Common/Extensions/HttpContextExtensions.cs
+++ b/MediaBrowser.Common/Extensions/HttpContextExtensions.cs
@ -28,9 +28,10 @@ namespace MediaBrowser.Common.Extensions
        /// <returns>The remote caller IP address.</returns>
        public static string RemoteIp(this HttpRequest request)
        {
-            if (string.IsNullOrEmpty(request.HttpContext.Items["RemoteIp"].ToString()))
+            var cachedRemoteIp = request.HttpContext.Items["RemoteIp"].ToString();
+            if (string.IsNullOrEmpty(cachedRemoteIp))
            {
-                return request.HttpContext.Items["RemoteIp"].ToString();
+                return cachedRemoteIp;
            }

            IPAddress ip;