From cb990ae97313507fc26384d395c22dd3b253ef31 Mon Sep 17 00:00:00 2001 From: Rich Lander Date: Mon, 9 Aug 2021 18:52:33 -0700 Subject: [PATCH] Update per feedback --- .../Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs | 2 +- MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs | 2 +- MediaBrowser.Providers/Subtitles/SubtitleManager.cs | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs b/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs index 2e1748c464..c97affdbf2 100644 --- a/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs +++ b/MediaBrowser.Providers/Plugins/MusicBrainz/MusicBrainzAlbumProvider.cs @@ -600,7 +600,7 @@ namespace MediaBrowser.Providers.Music } } - /// IDisposable implementation. + /// public void Dispose() { Dispose(true); diff --git a/MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs b/MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs index efba459146..4de4bf4db6 100644 --- a/MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs +++ b/MediaBrowser.Providers/Plugins/Tmdb/TmdbClientManager.cs @@ -533,7 +533,7 @@ namespace MediaBrowser.Providers.Plugins.Tmdb return !_tmDbClient.HasConfig ? _tmDbClient.GetConfigAsync() : Task.CompletedTask; } - /// Dispose method. + /// public void Dispose() { Dispose(true); diff --git a/MediaBrowser.Providers/Subtitles/SubtitleManager.cs b/MediaBrowser.Providers/Subtitles/SubtitleManager.cs index 160c64c846..0c791a2fee 100644 --- a/MediaBrowser.Providers/Subtitles/SubtitleManager.cs +++ b/MediaBrowser.Providers/Subtitles/SubtitleManager.cs @@ -252,6 +252,7 @@ namespace MediaBrowser.Providers.Subtitles } catch (Exception ex) { +// Bug in analyzer -- https://github.com/dotnet/roslyn-analyzers/issues/5160 #pragma warning disable CA1508 exs ??= new List() {