Applied review comments

pull/12798/head
JPVenson 3 months ago
parent dcfbf55794
commit d716a53ec2

@ -41,8 +41,8 @@ using BaseItemEntity = Jellyfin.Data.Entities.BaseItemEntity;
namespace Jellyfin.Server.Implementations.Item;
/*
All queries in this class and all other nullable enabled EFCore repository classes will make libraral use of the null-forgiving operator "!".
This is done as the code isn't actually executed client side, but only the expressions are interpretet and the compiler cannot know that.
All queries in this class and all other nullable enabled EFCore repository classes will make liberal use of the null-forgiving operator "!".
This is done as the code isn't actually executed client side, but only the expressions are interpret and the compiler cannot know that.
This is your only warning/message regarding this topic.
*/
@ -50,7 +50,7 @@ namespace Jellyfin.Server.Implementations.Item;
/// Handles all storage logic for BaseItems.
/// </summary>
public sealed class BaseItemRepository
: IItemRepository, IDisposable
: IItemRepository
{
/// <summary>
/// This holds all the types in the running assemblies
@ -62,7 +62,6 @@ public sealed class BaseItemRepository
private readonly IItemTypeLookup _itemTypeLookup;
private readonly IServerConfigurationManager _serverConfigurationManager;
private readonly ILogger<BaseItemRepository> _logger;
private bool _disposed;
private static readonly IReadOnlyList<ItemValueType> _getAllArtistsValueTypes = [ItemValueType.Artist, ItemValueType.AlbumArtist];
private static readonly IReadOnlyList<ItemValueType> _getArtistValueTypes = [ItemValueType.Artist];
@ -92,17 +91,6 @@ public sealed class BaseItemRepository
_logger = logger;
}
/// <inheritdoc/>
public void Dispose()
{
if (_disposed)
{
return;
}
_disposed = true;
}
/// <inheritdoc />
public void DeleteItem(Guid id)
{

@ -14,7 +14,7 @@ namespace MediaBrowser.Controller.Persistence;
/// <summary>
/// Provides an interface to implement an Item repository.
/// </summary>
public interface IItemRepository : IDisposable
public interface IItemRepository
{
/// <summary>
/// Deletes the item.

Loading…
Cancel
Save