Fix not binding to SQL parameters

Whitespace values weren't being filtered out in advance
Remove the posibility of this happening again by always binding

Should fix #11605
pull/11698/head
Bond_009 2 months ago
parent 26714e2c62
commit dd0ab8ed56

@ -2323,7 +2323,7 @@ namespace Emby.Server.Implementations.Data
columns.Add(builder.ToString());
query.ExcludeItemIds = [..query.ExcludeItemIds, item.Id, ..item.ExtraIds];
query.ExcludeItemIds = [.. query.ExcludeItemIds, item.Id, .. item.ExtraIds];
query.ExcludeProviderIds = item.ProviderIds;
}
@ -2831,7 +2831,7 @@ namespace Emby.Server.Implementations.Data
prepend.Add((ItemSortBy.Random, SortOrder.Ascending));
}
orderBy = query.OrderBy = [..prepend, ..orderBy];
orderBy = query.OrderBy = [.. prepend, .. orderBy];
}
else if (orderBy.Count == 0)
{
@ -5144,7 +5144,7 @@ AND Type = @InternalPersonType)");
list.AddRange(inheritedTags.Select(i => (6, i)));
// Remove all invalid values.
list.RemoveAll(i => string.IsNullOrEmpty(i.Item2));
list.RemoveAll(i => string.IsNullOrWhiteSpace(i.Item2));
return list;
}
@ -5202,12 +5202,6 @@ AND Type = @InternalPersonType)");
var itemValue = currentValueInfo.Value;
// Don't save if invalid
if (string.IsNullOrWhiteSpace(itemValue))
{
continue;
}
statement.TryBind("@Type" + index, currentValueInfo.MagicNumber);
statement.TryBind("@Value" + index, itemValue);
statement.TryBind("@CleanValue" + index, GetCleanValue(itemValue));

Loading…
Cancel
Save