From db10f380d1dcf034da622011d215642298aa6799 Mon Sep 17 00:00:00 2001 From: dkanada Date: Sun, 6 Oct 2019 00:58:27 +0900 Subject: [PATCH 1/2] fix missing image on seasons without posters --- Emby.Server.Implementations/Dto/DtoService.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Emby.Server.Implementations/Dto/DtoService.cs b/Emby.Server.Implementations/Dto/DtoService.cs index a3201f0bc0..c3db0461a7 100644 --- a/Emby.Server.Implementations/Dto/DtoService.cs +++ b/Emby.Server.Implementations/Dto/DtoService.cs @@ -1099,7 +1099,7 @@ namespace Emby.Server.Implementations.Dto Series episodeSeries = null; - if (options.ContainsField(ItemFields.SeriesPrimaryImage)) + //if (options.ContainsField(ItemFields.SeriesPrimaryImage)) { episodeSeries = episodeSeries ?? episode.Series; if (episodeSeries != null) @@ -1143,7 +1143,7 @@ namespace Emby.Server.Implementations.Dto } } - if (options.ContainsField(ItemFields.SeriesPrimaryImage)) + //if (options.ContainsField(ItemFields.SeriesPrimaryImage)) { series = series ?? season.Series; if (series != null) From e006b7f1e1e311f5c4b16b2b954bbc00c6aa2b8e Mon Sep 17 00:00:00 2001 From: dkanada Date: Sun, 6 Oct 2019 01:24:04 +0900 Subject: [PATCH 2/2] add comment explaining a bug fix --- Emby.Server.Implementations/Dto/DtoService.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Emby.Server.Implementations/Dto/DtoService.cs b/Emby.Server.Implementations/Dto/DtoService.cs index c3db0461a7..6c0e32e05b 100644 --- a/Emby.Server.Implementations/Dto/DtoService.cs +++ b/Emby.Server.Implementations/Dto/DtoService.cs @@ -1099,6 +1099,8 @@ namespace Emby.Server.Implementations.Dto Series episodeSeries = null; + // this block will add the series poster for episodes without a poster + // TODO maybe remove the if statement entirely //if (options.ContainsField(ItemFields.SeriesPrimaryImage)) { episodeSeries = episodeSeries ?? episode.Series; @@ -1143,6 +1145,8 @@ namespace Emby.Server.Implementations.Dto } } + // this block will add the series poster for seasons without a poster + // TODO maybe remove the if statement entirely //if (options.ContainsField(ItemFields.SeriesPrimaryImage)) { series = series ?? season.Series;