5677566a41
Enable nullable for more files
1 year ago
c717425549
Remove unnecessary type extension and handle feedback.
2 years ago
92f50054b2
Add explicit mapping instead of reflection to manifest reconciliation.
2 years ago
4a0b135b7a
Merge branch 'jellyfin:master' into whitelist-dlls
2 years ago
7dd4201971
Reconcile pre-packaged meta.json against manifest on install
2 years ago
e74630a613
Use MinBy and MaxBy
2 years ago
a944352aa8
Correct style inconsistencies
2 years ago
677b1f8e34
Remove unnecessary using statements in PluginManager
2 years ago
891b9f7a99
Add DLL whitelist support for plugins
2 years ago
8cabac0cf2
Load all plugin assemblies before attempting to load types
2 years ago
79a7815be7
Use one AssemblyLoadContext per plugin
2 years ago
577d396649
Use custom plugin assembly load context
2 years ago
a48f188874
Use separate assembly load contexts per plugin
2 years ago
dc85d86ea1
Enable in-process restarting
2 years ago
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2 years ago
52194f56b5
Replace != null with is not null
2 years ago
c7d50d640e
Replace == null with is null
2 years ago
d7f0596d5d
Don't auto-update if plugin is pending restart
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
ea8f40e84a
More cleanup
3 years ago
d95c281142
Load all types when checking plugin DLLs
3 years ago
79642af3b8
Fix some warnings
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
c78457e6d3
Minor fixes
3 years ago
0bc0601442
Fix some warnings
4 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
bcba501dfb
minor optimization.
4 years ago
65f880be32
Keep plugin status after update.
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
a6d0db5d04
100% branch coverage for DashboardController
4 years ago
9bfe945f6c
catch http exception and fix possible issues
4 years ago
fb2d178242
add await directive for image download
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
e9030a62fb
remove useless call to dispose
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
454deece13
improve performance in the wrong place
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
64cc5889f2
add suggested changes
4 years ago
b18bb3d0de
update timestamp parse for plugins
4 years ago
9caf311925
handle plugin manifests automatically
4 years ago
13c1c2815f
Add regression test for PluginManager.SaveManifest
4 years ago
311b2f5012
Exclude BOM when writing meta.json plugin manifest
4 years ago
54a3ab15a3
Merge pull request #5005 from jellyfin/bytes
...
JsonSerializer deserialize from bytes where possible
4 years ago
b014f2309d
Update Emby.Server.Implementations/Plugins/PluginManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
677bba742e
Remove try-catch nesting
4 years ago
80f3e20394
Change plugin error message
4 years ago
4adbbb9f51
Catch TypeLoadException during plugin loading
4 years ago
89046e1d97
Bug fixes
4 years ago
1fdd2d6e05
Handle IO errors in LoadManifest
4 years ago
1ea2b200c0
JsonSerializer deserialize from bytes where possible
...
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
| Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 | - | - | 52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 | - | - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 | - | - | 31.27 KB |
```
4 years ago
Bond_009
AmbulantRex
Stepan Goremykin
Patrick Barron
Cody Robibero
cvium
BaronGreenback
dkanada
David Ullmer