When the service should fail to launch Jellyfin, or should Jellyfin crash, the default action is changed from Restart to AppExit. This prevents the service from entering a constant restart due to a permissions issue or similar.
Fixes a syntax error with the NoServiceUninstall section. Moves the detection of an existing Service and datadir further up, so it happens before we decide how the installation will happen. Removed a newline from a comment, and enhanced the existing directory check. Adds an existing folder check, as well as a prompt if the user wants to continue with it or not. Also adds the datadir property to shortcuts.
Should only remove shortcuts if the install type was non-service. On upgrade, check if the install type was non-service, and if so, set the variables correctly and create shortcuts.
Adds the icon as a resource file in the program folder, and uses it for the shortcuts created.
Removes an extra section from the dialog creator file, so NSIS won't show a warning for unused code.
If the user is not installing as a service, then the installer creates a Start Menu shortcut, and a desktop shortcut. Commented out future shortcuts for a tray app.
Fix up the Setup Type dialog, by removing an unused function from the page.
Adds logic to the installer to check for a basic or advanced setup choice. Ensures that the service is only installed if the "advanced" method is chosen. Note - it may be possible to remove some defaults from the .onInit, considering they get set through the program now.
This adds backslashes to escape the `--datadir` path in the Windows Installer. Without this, the path would be dropped at the first space (e.g. `C:\Test Area\Jellyfin` would become `C:\Test`).
Fixes#1773.
* Much better, but still broken
It crashes with two custom pages after one another. (So when the service should be installed).
* Fixed the problems and finished the NSIS installer.
Also ignored some of the artifacts.
* Added changes to CI for setup building.
Consolidate building and fixed git error.
Small CI fixes.
Move UX repo to SourcesDirectory
Fix stupid checkout <> clone error.
Fix typo in PowerShell command.
Artifact publish tasks can not have wildcards.
The service is now completely controlled by nssm as with the install-jellyfin.ps1
The LocalAppData had the global context, its now
Corrected order of Mandatory and Optional components.
Anthony Lavado
Erwin de Haan
crankdoofus