3cf0070287
Escape subtitle extraction input path ( #10992 )
9 months ago
f26fc7dfb2
Merge changes
9 months ago
ce81e2aeab
Add alltilla to CONTRIBUTORS.md
...
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
10 months ago
8fea819b51
Extract all subtitle streams simultaneously
...
Extracting a subtitle stream is a disk I/O bottlenecked operation as
ffmpeg has to read through the whole file, but usually there is nothing
CPU intensive to do.
If a file has multiple subtitle streams, and we want to extract more
of them, extracting them one-by-one results in reading the whole file
again and again.
However ffmpeg can extract multiple streams at once.
We can optimize this by extracting the subtitle streams all at once
when only one of them gets queried, then we will have all of them
cached for later use.
It is useful for people switching subtitles during playback.
It is even more useful for people who extract all the subtitle streams
in advance, for example with the "Subtitle Extract" plugin.
In this case we reduce the extraction time significantly based on the
number of subtitle streams in the files, which can be 5-10 in many
cases.
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
10 months ago
d1677dc680
AsyncKeyedLock migration
11 months ago
635d67d458
Revert "Use System.Net.IPNetwork"
...
This reverts commit 117d05d288da1d412159a29c0cb8d5c8259e48ae.
1 year ago
a9ef103c95
Add IDisposableAnalyzers to more projects
1 year ago
4757ce105b
Use Process.WaitForExitAsync added in .NET 5
1 year ago
62be2a2ea9
Fix subtitle encoder if webvtt is requested
1 year ago
b5f0760db8
Use RegexGenerator where possible
1 year ago
910617bbc3
Remove redundant 'else' keywords
2 years ago
1c0bb828d2
Fix argument is not used in message template warning
2 years ago
81c8890b6d
Fix all warnings in MediaBrowser.MediaEncoding ( #9073 )
2 years ago
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2 years ago
71982c7297
Fix build errors
2 years ago
52194f56b5
Replace != null with is not null
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
4edeccc5e0
Remove redundant using directives
2 years ago
6004060b4e
Fix build errors from new warnings
2 years ago
fdd728e9f8
Merge pull request #8259 from RealGreenDragon/subtitle-extraction-timeout
2 years ago
7391b001ef
increased subtitle extraction timeout to 30 min
2 years ago
3e5cf9395f
Backport pull request #8182 from jellyfin/release-10.8.z
...
Extract external subs from container before determining characterset
Original-merge: 1faee43b11
2 years ago
38eefbbafa
Backport pull request #8087 from jellyfin/release-10.8.z
...
feat: make subtitleeditparser generic
Authored-by: Claus Vium <cvium@users.noreply.github.com>
Merged-by: Bond-009 <bond.009@outlook.com>
Original-merge: 7323ccfc23
2 years ago
3061446c87
Merge pull request #7984 from crobibero/dotnet-6.0.6
...
Upgrade to dotnet 6.0.6, update remaining dependencies
(cherry picked from commit 56e7b323de
2 years ago
e61c80fed7
Merge pull request #7960 from Shadowghost/subrip-encoder-fix
...
(cherry picked from commit ae79bbc34c
2 years ago
eb55f47f2e
Merge pull request #7810 from Bond-009/unaccpattern
...
(cherry picked from commit 5e343d30e1
2 years ago
efcdab116f
Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
...
(cherry picked from commit 60affd0965
3 years ago
dbf9e49258
Increase timeout for subtitle extraction to 30min ( #7153 )
3 years ago
b6489e73ab
Merge pull request #7241 from Bond-009/async5
3 years ago
509d66dcb5
Fix #7147 : Don't return subtitles in mismatched format ( #7149 )
3 years ago
e7be01d7a5
Flush to disk async where possible
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
f91839dd8c
Fix WebVTT region to spec
3 years ago
c26e6d89b4
Move FfmpegException to MediaBrowser.Common
3 years ago
9af16fcb6c
Remove workaround for dotnet/runtime#42790
3 years ago
f31224fa8f
Remove sync FileStream hack
3 years ago
4643fd5dcb
Address comments
3 years ago
13fbfe6091
Target net6.0
3 years ago
a6d1e542e6
Reduce allocations
3 years ago
34b38454e0
Fix SubtitleEncoder and add regression tests
3 years ago
ea3e66e918
Fix namespace
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
0bc0601442
Fix some warnings
4 years ago
26d7fc8280
Enable nullable reference types for MediaBrowser.MediaEncoding.Subtitles
4 years ago
9ed7f429c0
FxCop -> Net Analyzers (part 1)
4 years ago
60ffa6f514
Use FileShare.None when creating files
4 years ago
64730b5661
Merge pull request #5278 from BaronGreenback/STRMFix
...
Fix for #5168
4 years ago
473a995650
Update SubtitleEncoder.cs
4 years ago
felix920506
Mark Cilia Vincenti
Attila Szakacs
Bond_009
sleepycatcoding
Stepan Goremykin
Hannes Braun
Cody Robibero
MagicGreenDragon
Shadowghost
Joshua Boniface
Victor Gambier
SenorSmartyPants
Thibault Nocchi
Dmitry Lyzo
David
Claus Vium
BaronGreenback