Patrick Barron
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
Joshua M. Boniface
0d446c8755
Merge pull request #3609 from Bond-009/warn21
...
Fix warnings
4 years ago
Bill Thornton
e973757485
Simplify logic
4 years ago
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
Bill Thornton
2fa2952791
Skip image processing for live tv sources
4 years ago
Bond_009
7324b44c43
Fix warnings
4 years ago
Patrick Barron
b53bf2cd16
Remove obsolete network path code
4 years ago
crobibero
e152a6c82f
Increase delete logging
4 years ago
Patrick Barron
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
Bond-009
cb193b6afd
Add support for ReadOnlySpan<char> in IgnorePatterns
4 years ago
crobibero
9772749d8f
Add more ignorepatterns and tests
4 years ago
dkanada
bb7444db07
Merge pull request #3439 from cvium/ignore_application_folders
...
Never ignore application folders
4 years ago
crobibero
9eba11379a
catch skia errors when getting image dimensions
4 years ago
Claus Vium
0f07b19ca5
Remove AllowIgnorePath
4 years ago
Claus Vium
9dee1eef83
Never ignore application folders
4 years ago
Bond-009
f75024fade
Fix scan crashed
4 years ago
telans
7f307f9082
brace multiline if statements
4 years ago
telans
8de6452967
fix some documentation periods
4 years ago
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
telans
247f9c61e6
fix SA1513/SA1516
4 years ago
telans
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
telans
3d9049ef08
fix SA1508
4 years ago
telans
acd4389653
fix SA1005
4 years ago
telans
726e116d5b
fix SA1510
4 years ago
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
dkanada
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
4 years ago
Patrick Barron
fc02157b42
Fix build errors
4 years ago
Patrick Barron
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
4 years ago
Bond-009
ad5c41b542
Merge pull request #3258 from aled/2149-fix-a-small-number-of-compile-warnings-1
...
Fix a small number of compile warnings
4 years ago
crobibero
7ed5cf3dca
Force configuration paths to not be ignored.
4 years ago
aled
22a860a806
Fix a small number of compile warnings
4 years ago
Daniyar Itegulov
613748b45d
Make books resumable and have duration of 1 second
4 years ago
crobibero
44957c5a9a
Use typed logger where possible
4 years ago
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
Bond-009
2dbb9d4895
Fix build
4 years ago
Vasily
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
Vasily
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
4 years ago
Vasily
b9618c8c01
Merge pull request #2676 from GranPC/public-pr/blurhash
...
Implement Blurhash generation for images
4 years ago
Vasily
26eef1bbf8
Move logic of computing Blurhash components to ImageProcessor
...
Also rename last few instances of GetImageHash to GetImageBlurHash for clarity
4 years ago
Bond_009
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
Vasily
9208acd5ae
Convert non-local image to local before computing blurhash
4 years ago
Vasily
ed791dee46
Do not compute dimensions or blurhash for remote images
4 years ago
Bond_009
7439e095e2
Merge branch 'master' into nullable3
4 years ago
Vasily
edcfcadcd3
Make sure blurhash is recomputed if image changed or metadata refresh toggled
4 years ago
Vasily
6c9dc04189
Handle errors during blurhash generation so it does not fail the scan
4 years ago
Patrick Barron
eef7cfd912
Make SonarCloud less angry
4 years ago
Patrick Barron
01ce56016a
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
# MediaBrowser.Api/UserService.cs
# MediaBrowser.Controller/Library/IUserManager.cs
4 years ago
Joshua M. Boniface
0be3dfe7c5
Revert "Fix emby/user/public API leaking sensitive data"
4 years ago
Vasily
29443e3681
Apply suggestions from code review
...
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
4 years ago
Vasily
1f83a21288
Rename Hash to BlurHash in all properties and methods for clarity
4 years ago
Vasily
8b517e9bef
Fix nullref for imageProcessor in LibraryManager
4 years ago
Patrick Barron
c464f700db
Remove redundant qualifiers
4 years ago
artiume
0efb81b21e
Add lost+found to ignore list
...
https://forum.jellyfin.org/t/library-not-loading/2086
4 years ago
Vasily
186b7f303c
More small optimizations
4 years ago
Vasily
a226a4ee03
Compute hash only when one is not computed in DB, small optimizations here and there
4 years ago
Vasily
bfb644d5f5
Fix nullref exception
4 years ago
Vasily
02da312f8a
Fix compilation after rebase
4 years ago
Jesús Higueras
fe480caf54
Add endpoint to update all items in library
4 years ago
Jesús Higueras
b9fc0d2628
Add BlurHash support to backend
4 years ago
Vasily
2d2c1d9473
Merge pull request #3099 from rigtorp/ignore-patterns
...
Use glob patterns to ignore files
4 years ago
Erik Rigtorp
f144acdc96
Use glob patterns to ignore files
4 years ago
Patrick Barron
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
4 years ago
artiume
4eb4ad3be7
Update Books Resolver File Types
4 years ago
Patrick Barron
9ad839c776
Initial migration code
4 years ago
Patrick Barron
62420a6eb1
Remove support for injecting ILogger directly
4 years ago
Bond-009
62da4d0e5c
Merge pull request #2492 from Polpetta/fix-api-private-data-leak
...
Fix emby/user/public API leaking sensitive data
4 years ago
Davide Polonio
57cf19f058
Fix variable declaration and follow sonarcloud suggestions
4 years ago
Davide Polonio
472efeeec4
Remove extra line in UserManager
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
Vasily
5922c35d69
Merge pull request #2920 from Bond-009/tests2
...
Add some simple tests
4 years ago
dkanada
97d7ffc458
Merge pull request #2861 from mark-monteiro/fix-auth-response-codes
...
Fix Auth Response Codes
4 years ago
Bond-009
07326c1d9b
Merge branch 'master' into fix-auth-response-codes
4 years ago
Bond_009
c430a7ed8f
Address comments
4 years ago
Mark Monteiro
bc4e72b29b
Create ApplicationHost logger correctly
4 years ago
Mark Monteiro
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
4 years ago
Bond_009
7f4a229cd2
Add some simple tests
4 years ago
randrey
d30fd3b3d2
Changed '\d' to '[0-9]'.
4 years ago
randrey
92f273cb0c
Limit imdbid to 8 digits.
4 years ago
randrey
d7a71cee3c
Fix imdbid regex
4 years ago
Vasily
e1fb24c9ee
Merge pull request #2830 from Bond-009/dvdlib
...
DvdLib: remove dependency on MediaBrowser.Model
4 years ago
Bond-009
bcf53b3226
Merge pull request #2746 from dafo90/master
...
Authentication request log with IP
4 years ago
Bond_009
fc049caba2
Merge branch 'master' into nullable3
4 years ago
Mark Monteiro
9c7b3850f9
Throw AuthenticationException instead of ArgumentNullException when a user does not exist
4 years ago
Mark Monteiro
53380689ad
Return correct status codes for authentication and authorization errors
...
- Use AuthenticatonException to return 401
- Use SecurityException to return 403
- Update existing throws to throw the correct exception for the circumstance
4 years ago
Mark Monteiro
1e1295bebf
Merge remote-tracking branch 'upstream/master' into register-services-correctly
4 years ago
Bond_009
d8a7462205
DvdLib: remove dependency on MediaBrowser.Model
4 years ago
Vasily
06c5b73c15
Merge pull request #2755 from Bond-009/dbcleanup
...
Clean up SqliteItemRepository
4 years ago
dafo90
dd128b5e30
Log message for each exception during login
4 years ago
Vasily
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
4 years ago
dafo90
62b0db59aa
Fix Authentication request log
4 years ago
Bond_009
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
Mark Monteiro
615717e562
Register and construct IUserDataManager and IUserDataRepository correctly
4 years ago
Mark Monteiro
4daa5436fc
Register and construct IUserManager and IUserRepository correctly
4 years ago
Mark Monteiro
fe9f4e06d1
Register and construct LibraryManager correctly
4 years ago
Mark Monteiro
7fd25f94f3
Inject and construct ISearchEngine and IMusicManager correctly
4 years ago
Mark Monteiro
573da63d41
Register and construct IMediaSourceManager correctly
4 years ago
Bond_009
8e7b15285e
Clean up SqliteItemRepository
4 years ago
Didier Dafond
2fb9e36493
Authentication request log with IP
4 years ago
Mark Monteiro
34204046dd
Remove duplicate array of extras directory names
4 years ago
Bond_009
e9d1eabd53
Remove unused usings
5 years ago
Bond-009
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
Mark Monteiro
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
5 years ago
Bond-009
464039043d
Merge pull request #2491 from mark-monteiro/2425-fix-playlists
...
Fix Playlist Deletion
5 years ago
Vasily
13d30a0a79
Merge pull request #2436 from dkanada/music
...
Add config options for MusicBrainz
5 years ago
Davide Polonio
5d760b7ee8
Fix emby/user/public API leaking private data
...
This commit fixes the emby/user/public API that was returning more data
than necessary. Now only the following information are returned:
- the account name
- the primary image tag
- the field hasPassword
- the field hasConfiguredPassword, useful for the first wizard only
(see
https://github.com/jellyfin/jellyfin/issues/880#issuecomment-465370051 )
- the primary image aspect ratio
A new DTO class, PrivateUserDTO has been created, and the route has been
modified in order to return that data object.
5 years ago
Mark Monteiro
1204818698
Clean up and document PlaylistResolver
5 years ago
Mark Monteiro
41a26f8ecd
Correctly resolve playlists that are stored using a directory path
5 years ago
Bond_009
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
dkanada
6715450598
Merge pull request #2427 from Bond-009/minor
...
Minor improvements
5 years ago
dkanada
65a9d618cc
add config options for musicbrainz
5 years ago
Bond_009
adc9fc282c
Minor improvements
5 years ago
Ulrich Wagner
3bd7633cbf
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
a9e744bea0
Curly braces on new lines
5 years ago
Ulrich Wagner
3d9dc59554
Omitting the parameter ExtraChapters
5 years ago
Ulrich Wagner
f4d0fa8dc8
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
d6971581d6
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
0f2ee2686d
Constructor of the LibraryManager takes the mediaEncoder as parameter
5 years ago
Ulrich Wagner
b16ba7d985
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
7005326685
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
4d0ee3f6cc
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
39b6d6586f
Update Emby.Server.Implementations/Library/LibraryManager.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Ulrich Wagner
5fed4d10ab
Only reading the result of GetMediaInfo if it completed successfully
5 years ago
Ulrich Wagner
d7f199bb1c
#2407 : Prefer MP4-Metadata for episodes
5 years ago
Bond-009
d5fcca3d05
Merge branch 'master' into naming
5 years ago
dkanada
fe325a6e73
Merge pull request #2359 from Bond-009/username
...
Allow changing capitalization of usernames
5 years ago
dkanada
692a9bfdd0
update some comments
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
dkanada
afe9ed977b
improve scan progress and fix a few bugs
5 years ago
Bond_009
acc1846e3e
Allow changing capitalization of usernames
5 years ago
Bond_009
dc62e436c4
Clean up Emby.Naming
5 years ago
dkanada
c618f3f8eb
Merge pull request #2257 from Bond-009/cleantests
...
Fix a couple of tests
5 years ago
dkanada
d217f1614e
Merge pull request #2096 from Bond-009/embytv
...
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
Bond_009
abf03f7d3a
Clean up some more
5 years ago
Vasily
dd7feacd34
Merge pull request #2105 from Bond-009/namingtests
...
Add back all old emby tests
5 years ago
Bond_009
bb236b9591
Merge branch 'master' into warn12
5 years ago
Bond_009
e714b9930e
Merge branch 'master' into embytv
5 years ago
Bond_009
b50c4938e1
Merge branch 'master' into namingtests
5 years ago
Bond_009
a253fa616d
Fix build and address comments
5 years ago
dkanada
aca31457c0
merge branch master into media-attachments
5 years ago
dkanada
aac0a1ed26
Merge pull request #2206 from Bond-009/userconfig
...
Delete user config dir on user deletion
5 years ago
dkanada
fb61a1f882
Merge pull request #2150 from Bond-009/releaseerror
...
Enable TreatWarningsAsErrors for some projects
5 years ago
dkanada
529cff3920
Merge pull request #2153 from dkanada/fix-playlist
...
Fix playlist deletion and a few warning fixes
5 years ago
dkanada
c10cb66169
remove directory check
5 years ago
Bond_009
ab57b504fe
Delete user config dir on user deletion
5 years ago
Bond_009
7f5a174dff
Merge branch 'master' into warn12
5 years ago
Bond-009
6b185119aa
Merge branch 'master' into namingtests
5 years ago
dkanada
28e922326d
remove space
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
dkanada
623e85a9e4
add suggested changes
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
dkanada
1b2453b4e9
fix playlist deletion
5 years ago
dkanada
02928128b9
track progress for any item that supports the feature
5 years ago
Bond_009
5a8e972952
Enable TreatWarningsAsErrors for some projects
...
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
5 years ago
Bond_009
2ef4ffd698
More warnings (removed)
5 years ago
dkanada
67922dff50
Merge pull request #2041 from Bond-009/warn11
...
Fix more warnings
5 years ago
Bond-009
affb58ef9e
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
dkanada
dee3076eaf
Merge pull request #1923 from Bond-009/random
...
Don't shuffle some types by default
5 years ago
Bond_009
35151553e3
Add back all old emby tests
5 years ago
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
Bond_009
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
Bond_009
42ffddc269
Fix more warnings
5 years ago
Bond_009
3221e837f9
* Add support for multi segment base urls
...
* Make baseurl case-insensitive
5 years ago
dkanada
51cdc6ea16
Merge pull request #1926 from Bond-009/auth
...
Add clearer exceptions, warnings and docs
5 years ago
Bond_009
d7335f6ae6
Reword exception message
5 years ago
Bond-009
b477b3874e
Fix some warnings
5 years ago
Bond-009
413ae86dbc
Fix easy password
5 years ago
dkanada
f51f59d675
Merge pull request #1965 from Bond-009/dbjson
...
Deserialize with the correct type (and warning fixes)
5 years ago
dkanada
61b9b4046a
Merge pull request #1929 from Narfinger/parser-fix4
...
[Draft][Help wanted] Fix parsing of certain names and adds a default season if no season was found
5 years ago
Andrew Mahone
d73f46dcda
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Andrew Mahone
8b2d7062c4
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Andrew Mahone
193a1fa474
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Narfinger
9cd62d661f
removed restriction to 3 digits in episodenumber and 4 in season numbers
5 years ago
Andrew Mahone
7110069b39
Return list result directly for MediaAttachments.
5 years ago
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
5 years ago
Bond_009
a245f5a0d4
Rewrite hex encoder/decoder
5 years ago
Bond_009
846857b60e
Deserialize with the correct type (and warning fixes)
5 years ago
Bond_009
016be02cd6
More warning fixes
5 years ago
Bond_009
d9a03c9bb1
Fix more warnings
5 years ago
Bond-009
24c076eff3
Update Emby.Server.Implementations/Library/UserViewManager.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
Andrew Mahone
1513c76a3e
Support MediaAttachment retrieval in MediaSourceManager.
5 years ago
Narfinger
4a20260a27
add another parser case and allow parsing of seasonless
...
Add another parser case and we now allow parsing of seasonless series which hopefully should cover more cases of directory structure
5 years ago
Bond_009
fef35d0505
Add clearer exceptions, warnings and docs
5 years ago
Bond_009
bbc0875387
Don't shuffle some types by default
5 years ago
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
5 years ago
Bond-009
6f17a0b7af
Remove legacy auth code ( #1677 )
...
* Remove legacy auth code
* Adds tests so we don't break PasswordHash (again)
* Clean up interfaces
* Remove duplicate code
* Use auto properties
* static using
* Don't use 'this'
* Fix build
5 years ago
Bond-009
221b831bb2
Reset invalid login counter on successfull login
5 years ago
Joshua Boniface
baa30b41de
Add debug logs and try/catch when creating folder
5 years ago
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
5 years ago
Bond_009
efc4805233
Fix login
5 years ago
Bond_009
24fac4b191
Fix UserNotFoundError
5 years ago
Bond_009
8d3b5c851d
Improvements to UserManager
5 years ago
Joshua M. Boniface
a96fa7a5c7
Merge pull request #1397 from Bond-009/passfast
...
Streamline authentication proccess
5 years ago
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
Bond_009
ab7ef9c9cb
Fix style issues
5 years ago
Bond_009
0f897589ed
Streamline authentication proccess
5 years ago
dkanada
9e9952d81f
Merge pull request #1247 from bugfixin/master
...
Adjust detection of 'sample' in filenames to use regex boundaries
5 years ago
Bond_009
d961278b3d
Reduce amount of raw sql
5 years ago
Joshua M. Boniface
687255aa31
Merge pull request #1442 from jellyfin/release-10.3.z
...
Backmerge for Release 10.3.4 and 10.3.5
5 years ago
Joshua M. Boniface
2946ae1009
Revert "Don't set a default reset provider"
...
This reverts commit c230d49d7c
.
This reenables an edge case where an admin might want to reset, with
the default auth provider, the password of an externally-provided
user so they could "unlock" the account while it was failing. There
might be minor security implications to this, but the malicious
actor would need FS access to do it (as they would with any password
resets) so it's probably best to keep it as-is.
Removing this in the first place was due to a misunderstanding
anyways so no harm.
5 years ago
Joshua M. Boniface
4b8f735cb8
Remove superfluous conditional
...
This wasn't needed to prevent updating the policy on-disk from my
tests and can be removed as suggested by @Bond-009
5 years ago
Joshua M. Boniface
c230d49d7c
Don't set a default reset provider
5 years ago
Joshua M. Boniface
20e2cb2d86
Use SecurityException for auth failure
5 years ago
Joshua M. Boniface
b70083f3b3
Apply suggestions from code review
...
Co-Authored-By: Claus Vium <cvium@users.noreply.github.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Joshua M. Boniface
74ef389879
Add nicer log message and comment
5 years ago