0bc0601442
Fix some warnings
4 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
8517b28eba
Make BaseItemDto Guids nullable
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
73f9a6d7d0
Convert array property to IReadOnlyList
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
4 years ago
119f64f5e7
Make some methods async
4 years ago
2b400c99ef
Fix warnings
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
7adac7561a
Use System.Text.Json in LiveTvManager
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
44957c5a9a
Use typed logger where possible
5 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
5 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
5 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
5 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
5 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
eef7cfd912
Make SonarCloud less angry
5 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
9ad839c776
Initial migration code
5 years ago
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
5 years ago
49fe5e0a21
Fix some warnings
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
cb2d99e831
Construct LiveTvDtoService and LiveTvManager correctly
5 years ago
3d5b4f869c
Register ILiveTvManager and IPlaylistManager correctly
5 years ago
3ab50f5a3f
Address comments
5 years ago
7060934792
Fix some warnings in Emby.Server.Implementations
5 years ago
e714b9930e
Merge branch 'master' into embytv
5 years ago
a4ca259a64
Add improved error error for #2141
5 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
a245f5a0d4
Rewrite hex encoder/decoder
5 years ago
d9a03c9bb1
Fix more warnings
5 years ago
bbc0875387
Don't shuffle some types by default
5 years ago
c9820d30ed
Fix multiple mistakes and warnings
5 years ago
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
b44a70ff36
Simplify/remove/clean code
...
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant
And ofc fix some warnings ;)
6 years ago
8d98885cda
Less string allocations
6 years ago
78e4e2ed92
Fix all warnings
6 years ago
1385d89df6
Remove MoreLINQ
6 years ago
8b073e2ba5
Remove unused field
6 years ago
Bond_009
BaronGreenback
crobibero
Matt Montgomery
Patrick Barron
telans
Vasily
Mark Monteiro