814fc6864d
Specify file as concat when extracting attachments
10 months ago
8d40d431e8
Extract and cache all media attachments in bulk ( #11029 )
...
Similar to https://github.com/jellyfin/jellyfin/pull/10884
---
Jellyfin clients need fonts for subtitles, and each font is a separate
attachment, which causes a lot of re-reads of the file. Certain contents,
like anime in a lot of cases, contain 50-80 different attachments.
Spawning 80 ffmpeg processes at the same time on the same file might
cause swapping on slower HDDs and can bring disk subsystem to a crawl.
(For more info, see https://github.com/jellyfin/jellyfin/3215 )
This change helps a lot in this scenario.
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
11 months ago
d1677dc680
AsyncKeyedLock migration
1 year ago
4757ce105b
Use Process.WaitForExitAsync added in .NET 5
1 year ago
b176beb88e
Reduce string allocations
...
Some simple changes to reduce the number of allocated strings
1 year ago
910617bbc3
Remove redundant 'else' keywords
2 years ago
08ce477226
Fix duplicate properties in message template warning
2 years ago
ef3868ff50
Backport pull request #9178 from jellyfin/release-10.8.z
...
Escape the path to pass as a command line argument
Original-merge: 09f1c7f535
2 years ago
b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2 years ago
c7d50d640e
Replace == null with is null
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
d7d36a102a
Fix releasing lock
3 years ago
b4bb82b6d7
Improve code
3 years ago
6904edf68c
add extracting attachments from external subs
3 years ago
ab40554759
add extracting attachments for ffmpeg to burn subs
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
26d7fc8280
Enable nullable reference types for MediaBrowser.MediaEncoding.Subtitles
4 years ago
a6199f821b
Merge pull request #4169 from stanionascu/bdiso-playback
...
Playback (direct-stream/transcode) of BDISO/BDAV containers
4 years ago
e82829c444
Fix nullability errors in MediaBrowser.MediaEncoding
4 years ago
cd4641dca0
Remove PlayableStreamFileNames as unused
...
Since ffmpeg can play and transcode ISO files and BDMV folders directly,
there's no use of that property.
4 years ago
3ad6232973
Add probe / direct-stream / transcoding support for BluRays
...
This commit (and ffmpeg built with libbluray support), adds support
for playback of bluray images (bd-iso) and bluray folders.
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
18efa25a6f
Enable TreatWarningsAsErrors for MediaBrowser.MediaEncoding
5 years ago
3d9049ef08
fix SA1508
5 years ago
44957c5a9a
Use typed logger where possible
5 years ago
4113288278
Fix style issues
5 years ago
7152b55747
Use a separate line for each property initializer
5 years ago
e0f40f57d8
Merge remote-tracking branch 'upstream/master' into remove-common-process
5 years ago
0e195d2e49
Add missing call to ConfigureAwait()
5 years ago
d705931e81
Dispose of process correctly in AttachmentExtractor
5 years ago
48bbcbb426
Use WaitForExitAsync extension method in AttachmentExtractor
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
0d6a4c2909
Fix build
5 years ago
a253fa616d
Fix build and address comments
5 years ago
dee247453e
Throw InvalidOperationException when attachment extraction exits abnormally or doesn't produce output.
5 years ago
7ea05bb86b
Merge branch 'media-attachments' of github.com:Unhelpful/jellyfin into media-attachments
5 years ago
79858eb26c
Remove use of ProcessFactory, as well as arbitrary timeout in AttachmentExtractor.
5 years ago
3a9bf84e3b
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
formatting
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
1eb3df1d6c
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
formatting / style
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
380d023351
Merge branch 'media-attachments' of github.com:Unhelpful/jellyfin into media-attachments
5 years ago
2f728fd2a1
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
formatting
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
2338a53229
Don't user ILoggerFactory.
5 years ago
492bbc9e13
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
String -> string
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
92aae268a3
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
formatting
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
c09eb34708
Check for attachment file before trying to remove it during cleanup.
5 years ago
4f3b883155
Clean up handling of missing source/attachment in AttachmentExtractor.
5 years ago
349310787c
Update MediaBrowser.MediaEncoding/Attachments/AttachmentExtractor.cs
...
formatting
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
28a6718d8e
Return path of extracted attachment, which is always a file, instead of AttachmentInfo with path and protocol.
5 years ago
Cody Robibero
Attila Szakacs
Mark Cilia Vincenti
Bond_009
Stepan Goremykin
Róbert Örn Ketilsson
Nils Fürniß
Joshua M. Boniface
Stanislav Ionascu
telans
Mark Monteiro
Andrew Mahone