1337a0dcec
Code review
4 years ago
ca2b36bdb0
Reduce warnings in Emby.Dlna
4 years ago
6123e2e848
Fix build
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
98ed90c4a2
Merge branch 'master' into event-rewrite-1
4 years ago
2b400c99ef
Fix warnings
4 years ago
09c8597461
inheritdoc
4 years ago
7d2ad3e0fc
Fix DlnaControlResponse string return
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
da9bcc5fb3
Rename IEventManager to IDlnaEventManager
4 years ago
f915c3e5d9
Merge remote-tracking branch 'upstream/master' into api-migration
4 years ago
3a0bccb941
Merge pull request #2957 from crobibero/api-dlna-server
...
Migrate DlnaServerController to Jellyfin.Api
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
3d5f89ebf9
Merge remote-tracking branch 'upstream/api-migration' into api-dlna-server
4 years ago
f516cf9c4c
Merge remote-tracking branch 'upstream/api-migration' into api-dlna
4 years ago
d4092846e4
Optimize Substring and StringBuilder usage
4 years ago
3ff110984a
Merge branch 'master' into readonlyspan
4 years ago
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
8960d6256f
Merge pull request #3659 from Bond-009/stringbuilder
...
Optimize StringBuilder.Append calls
4 years ago
fd82ecd18e
Merge pull request #3595 from Bond-009/xml
...
Improve DescriptionXmlBuilder
4 years ago
89ff865d40
Merge pull request #3508 from BaronGreenback/nullable
...
Part 1: nullable Emby.DLNA
4 years ago
4d681e3cad
Optimize StringBuilder.Append calls
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
65453c0a84
Fix build and more Append calls
4 years ago
39be99504f
Improve DescriptionXmlBuilder
...
* Replace XML escape code with SecurityElement.Escape
* Optimize StringBuilder.Append calls
4 years ago
672a35db94
Update DlnaServerService.cs
4 years ago
f9b0816b80
Changes a suggested.
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
0f696104ac
using missing.
4 years ago
c7c28db17b
Update DlnaServerService.cs
4 years ago
d9f9412955
Update DlnaServerService.cs
4 years ago
6d1b00da64
Use Array.Empty
4 years ago
43221fc26b
Merge branch 'master' into SSDP
4 years ago
7f307f9082
brace multiline if statements
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
8e3d874802
remove regions
4 years ago
215ab39e00
Merge pull request #3342 from BaronGreenback/BugFix2
...
Fix for [DLNA] Many log messages from Media Renderers trying to see old events
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
6d6793151a
Null pointer check added for subscription as 2nd param is false.
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
4d9171f691
Update DlnaEntryPoint.cs
...
Left a _config behind.
4 years ago
5cf44e7736
Removed spaces
4 years ago
93568be3e7
Updates
4 years ago
57d1dbfe7b
undo erroneous changes
5 years ago
44957c5a9a
Use typed logger where possible
5 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
5 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
5 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
5 years ago
9ad839c776
Initial migration code
5 years ago
15634a1913
Merge branch 'master' into websocket
5 years ago
8a69300bf5
Changes styles as suggested by @barronpm
...
Added addtional comments & source type as per intellisense suggestion
change code as per sonacloud
5 years ago
ebd589aa86
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
5 years ago
a3140f83c6
Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
...
This reverts commit 2aaecb8e14
5 years ago
2aaecb8e14
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
5 years ago
4fa6d1ccee
Merge pull request #2940 from balu92/master
...
Fix missing colons
5 years ago
ca4b6836c1
Merge pull request #2906 from randrey/dlna-nullref-fix
...
Fix InvalidOperationException while browsing via DLNA client.
5 years ago
118f30059c
Merge branch 'master' into nullable4
5 years ago
461b298be7
Migrate DlnaServerController to Jellyfin.Api
5 years ago
f5385e4735
Move Emby.Dlna DlnaService.cs to Jellyfin.Api
5 years ago
c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
...
Remove requirement to build web during server builds
5 years ago
c5f163293f
Add <ProjectGuid> properties to all project files
...
This is required for SonarCloud analysis to run
5 years ago
80f5dd1e59
Fixed missing colons
...
some colons were missing from the default ProtocolInfo string
5 years ago
0bef4eef87
Fix InvalidOperationException while browsing via DLNA client.
5 years ago
eba781eac5
Fix DLNA clients displaying wrong album art.
5 years ago
2fcbc2a5b8
Enable nullabe reference types for Emby.Drawing and Jellyfin.Drawing.Skia
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
d5cc10d7e1
Merge pull request #2741 from Bond-009/dlnawarnings2
...
Fix some warnings
5 years ago
64692af1a2
Update Device.cs
5 years ago
91b17e7289
Update Device.cs
5 years ago
4cacfd5997
Update DidlBuilder.cs
5 years ago
ad0e2e42e6
Update Device.cs
5 years ago
3161e85f76
Address comments
5 years ago
f6c9a44703
Update Device.cs
5 years ago
231c1e519f
Update Emby.Dlna.csproj
5 years ago
a37b69a493
Merge pull request #2559 from whooo/295-fix
...
Add descriptive TV episode titles for DLNA browsing
5 years ago
8a566dfe73
Fix build
5 years ago
be8ba96183
Fix some warnings
5 years ago
62a18af17a
Update Emby.Dlna/Main/DlnaEntryPoint.cs
...
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
5 years ago
b63ed35238
Add descriptive TV episode titles for DLNA browsing
...
When browsing TV episodes in Next Up, etc via DLNA a more descriptive
title should be used to easier identify the right episode.
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
241e351a61
Merge branch 'master' into dlnawarnings
5 years ago
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
5 years ago
87d2479b78
Fix warnings
5 years ago
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
5 years ago
d69870680b
Close xmlwriter first
5 years ago
6ee04855cd
Style
5 years ago
ae9c1e29e7
My bad
5 years ago
36d62c3093
Fix?
5 years ago
6b68521bae
Try again
5 years ago
fc578de3b3
Try possible solutions
5 years ago
bade35958a
Fix
5 years ago
3a338c1899
Address comments
5 years ago
c8409d2ea1
Remove FileSystem.GetStream
5 years ago
82112b6788
Improvements to dlna server
...
* Improve response writer
* Add analyzers
* Error on warnings in release mode
* Disable doc warnings
5 years ago
1dd4abebbd
Merge pull request #2297 from Bond-009/asyncio
...
Kestrel doesn't like sync IO operations
5 years ago
5340eb9363
Update Emby.Dlna/Service/BaseControlHandler.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
ac3b958c67
Use async methods
5 years ago
f2eea89ff0
Fix pagination for DLNA root folder list
...
Previously, when responding to a DLNA "Browse" request, the
`StartingIndex` was not respected and all of the root items were
returned each time. This caused infinite loops with in DLNA clients that
ignored the `TotalMatches` data in the response and just continued
asking for the next page until they got an empty response.
This fix makes the root folder list respect the `StartingIndex` and
`RequestedCount` parameters like all other responses.
Fixes issue #2303
5 years ago
2610f377c0
Kestrel doesn't like sync IO operations
5 years ago
976459d3e8
Rewrite WebSocket handling code
5 years ago
fdbb329118
Remove StringHelper functions
5 years ago
49330e3082
Fix a couple of TODOs
5 years ago
dee3076eaf
Merge pull request #1923 from Bond-009/random
...
Don't shuffle some types by default
5 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
94edb5b9f9
Add else
5 years ago
a6f883345f
Reduce #lines
5 years ago
3221e837f9
* Add support for multi segment base urls
...
* Make baseurl case-insensitive
5 years ago
69d76af054
dlna GetPathValue
...
Forgot to update this last time, just copied the code from `MediaBrowser.Api/BaseApiService.cs`
5 years ago
5ee070eb29
Remove leading / from baseurl
5 years ago
d161b9cbfc
Fix GetPathValue function for DLNA service
5 years ago
0b02c77691
Merge pull request #1864 from Bond-009/installationmanager
...
Improve IInstallationManager interface
5 years ago
983d38a43b
Merge branch 'master' into installationmanager
5 years ago
b0a25c4237
Use Mono.Nat Nuget package
5 years ago
d529f81cd9
Improve IInstallationManager interface
5 years ago
a245f5a0d4
Rewrite hex encoder/decoder
5 years ago
bbc0875387
Don't shuffle some types by default
5 years ago
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
5 years ago
3deeca43a1
- use streamInfo.StartPositionTicks if provided over userdata.PlaybackPositionTicks when creating the Samsung Bookmark Info
5 years ago
237db8ae92
Clean up livestreaming code
5 years ago
bb04545068
Merge pull request #1614 from Bond-009/docs2
...
Document all public/internal members of Emby.Drawing
5 years ago
838e5d05d5
Document all public/internal members of Emby.Drawing
...
Forces all new public/internal members to be documented.
Enables TreatWarningsAsErrors for Emby.Drawing
5 years ago
5eaf5465a5
Check checksum for plugin downloads
...
* Compare the MD5 checksum when downloading plugins
* Reduced log spam due to http requests
* Removed 'GetTempFileResponse' function from HttpClientManager
* Fixed caching for HttpClientManager
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
8b1bd7ac6b
Use a dictionary to look up mimetypes
5 years ago
ddd1a282ea
Remove IpAddressInfo and IpEndPointInfo classes
5 years ago
b1bd062709
Properly set content type
5 years ago
d405a400aa
Fixes issues with HttpClientManager
5 years ago
87c8f19f19
Move DLNA thumbnail element to after larger image elements
6 years ago
608fd873de
Optimize images with image_optim
6 years ago
d623f616fa
Improved dispose method
6 years ago
fc8de8aead
Check if disposed first
6 years ago
21cc38fcf4
Adjusted AssemblyCopyright attribute values.
6 years ago
ee7bf86e0f
Adjusted the Product Name so the User Agent is correct/better.
6 years ago
297f25cfc2
Merge pull request #1059 from Bond-009/os
...
Remove EnvironmentInfo
6 years ago
3ddbda9aca
Merge branch 'master' into xml
6 years ago
decaffed86
Remove EnvironmentInfo
...
This moved the last bit of usefulness of EnvironmentInfo into a static
class.
6 years ago
e04a152ed0
Merge pull request #996 from Bond-009/libscan
...
Reduce the amount of exceptions thrown
6 years ago
75996476a7
Merge pull request #1061 from Bond-009/dead
...
Remove dead code
6 years ago
37ea50a572
Reduce the amount of exceptions thrown
6 years ago
0abe57e930
Merge remote-tracking branch 'remotes/upstream/master' into kestrel_poc
6 years ago
65c0b486aa
Remove dead code
...
What it says on the tin
6 years ago
8c609bc9ce
Reduce aspnet imports
6 years ago
ffd6dac03a
Remove useless comments
6 years ago
a9302b8b53
Remove useless abstraction around XmlReaderSettings
...
This removes the amount of stuff that needs to be passed around
Also removes some unneeded `ManagedFileSystem` usage
6 years ago
318e0d4a24
Add GetValueOrDefault dictionary extension
6 years ago
040871459b
Remove some unused references
6 years ago
9993dafe54
Don't mix LINQ and roreach loops for readability
6 years ago
27e7e792b3
Replace some usage of QueryParamCollection
6 years ago
91afaaf8fe
Cleanup in QueryParamCollection
6 years ago
333bd2107a
Remove HttpUtility
6 years ago
0c49079c16
Update comments for DLNA IPv6
6 years ago
1eb26bdf08
Ignore IPv6 DLNA devices
...
DLNA is not ready for IPv6 now, uncomment the code will be fine.
6 years ago
cbd0e71c07
Send DLNA devices message to only the matched interface
...
This will be the right way for multiple interfaces, or the client will
receive all devices message with different IP addresses and could not
detect which one could access.
And provide one option DlnaOptions.SendOnlyMatchedHost to fallback to old
behaviour if this commit missed something.
6 years ago
2db1826ed8
Enable DLNA multi socket binding for linux
...
If not, DLNA on multiple interfaces not works for linux, for
example ZerotierOne VPN.
6 years ago
cf4e64f430
Add option to toggle if ignore virtual interfaces
...
Some VPN like ZerotierOne owns IP address but no gateway, and there is no
good idea in NetworkManager.GetIPsDefault() to filter such virtual interfaces,
so just provide one option to let user decide it.
6 years ago
6c6e9ca9f2
Merge pull request #889 from Bond-009/xmlex
...
Fix uncaught xml error
6 years ago
a35ea49c99
Merge remote-tracking branch 'upstream/release-10.2.z' into newmaser
6 years ago
7bb8985f11
Fix race condition in adding dlna devices to session when the device is discovered repeatedly
6 years ago
a82303ccd1
Fix uncaught xml error
6 years ago
81a8ebde22
Move to Microsoft.Extensions.DependencyInjection
...
This PR replaces SimpleInjector with
Microsoft.Extensions.DependencyInjection.
6 years ago
be89a5e719
Don't rename method
6 years ago
84d56976ba
Some small changes in Device.cs and DidlBuilder.cs
...
Device.cs:
* Improve dispose function
* Style fixes
* Remove unused field
DidlBuilder.cs:
* Remove unused field
* Replace giant if chain with a switch statement
6 years ago
0ef2b46106
Remove custom Threading
6 years ago
c4f51e16a5
Merge pull request #736 from Bond-009/startasync
...
Start startup tasks async
6 years ago
c713824bf9
Merge pull request #734 from Bond-009/culture
...
Fix more analyzer warnings
6 years ago
8985fb8d58
Remove support for games as a media type
6 years ago
1ea219bf3f
Merge branch 'master' into culture
6 years ago
ffcf6bdd3a
Merge pull request #713 from EraYaN/fix-emtpy-statement
...
Fix empty statement in DidlBuilder.cs
6 years ago
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
6 years ago
85a58fd655
Start startup tasks async
6 years ago
a709cbdc64
Fix more analyzer warnings
6 years ago
05fd76c0fa
Merge pull request #723 from Bond-009/dbperf
...
Minor improvements to db code
6 years ago
7165868509
Merge pull request #709 from Bond-009/null
...
Fix always null expressions
6 years ago
07f163a4c3
Minor improvements to db code
6 years ago
883575893b
Change image dimentions from double to int
...
Rename ImageSize -> ImageDimensions
6 years ago
e8f6a61131
Fix empty statement in DidlBuilder.cs
6 years ago
8af256f9c2
Fix always null expressions
6 years ago
722120af74
Remove conditions that are always true/false
6 years ago
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
6 years ago
8de4eb7d19
Rename ApplicationSemanticVersion to ApplicationVersion
6 years ago
924ec0c191
Revert Jellyfin.Versioning, Update all versions and user agents.
6 years ago
bb8df8dfa0
Updates reported version in `System/Info*` set of endpoints.
...
Added ProductName and ServerVersion to API.
Added build version and build step. Addressed issues wtih indentation.
Made the BuildVersion an actual object. This lets up link to the github page of that commit.
Fixed class method type and styled link.
Fixed languages and split out the information in the UI.
Moved update-version script and gave it executable permissions. Windows correctly finds the .bat file. And linux takes the one without extension.
Removed tempfiles from replace sessions from csproj.
Updated version generation scripts. Will also work with pre existing version files. (Source tarballs etc.)
Added simple replace for ssh github links.
Add execute rights to update-version.
Wrapped long line in ApplicationHost.cs
Fixed some small issues.
Fixed some small issues, and flipped some if's around.
Converted parameter names to camelBack casing.
Sealed the attribute class.
Removed MPLv2 license.
Fixed file headers.
Added newline.
Moved links in *.csproj files as well.
Fix issues caused by rebase auto merging.
Removed default constructor and added init values to properties, also hid the Remote value form API.
6 years ago
c5430f86b0
Fixed csproj and xml identation.
6 years ago
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
6 years ago
e867446437
ReSharper format: conform inline 'out' parameters.
6 years ago
65bd052f3e
ReSharper conform to 'var' settings
6 years ago
a36658f6f0
ReSharper Reformat: Properties to expression bodied form.
6 years ago
089ad8e7c2
Find+Sed BOM removal *.xml,*.csproj,*,json,*.sln,*.txt
6 years ago
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
6 years ago
David
Bond_009
Patrick Barron
crobibero
Patrick Barron
Joshua M. Boniface
BaronGreenback
telans
dkanada
Vasily
Mark Monteiro
Unknown
randrey
a1
Erik Larsson
Claus Vium
Carey Metcalfe
marius
bugfixin
Andrew Rabert
Erwin de Haan
Claus Vium
Xu Fasheng
Anders Thomsen
Andrew Rabert
William Taylor