b366dc2e6e
Use ArgumentException.ThrowIfNullOrEmpty
2 years ago
52194f56b5
Replace != null with is not null
2 years ago
c7d50d640e
Replace == null with is null
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
efcdab116f
Merge pull request #7529 from Shadowghost/strm-ffprobe-external-fix
...
(cherry picked from commit 60affd0965
3 years ago
75475285da
Fix supportsTranscoding not reflecting user permissions sometimes
3 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
1c14c86b20
Fix some warnings
3 years ago
7bfc6b5679
Remove more warnings
3 years ago
4dfb7b18ae
Add some docs and tests
3 years ago
876a902356
Fix warnings in Library
3 years ago
ff328fefc5
Replace GetDirectStreamProviderByUniqueId with GetLiveStreamInfoByUniqueId
3 years ago
026a7af0e8
Don't throw when livestream file isn't found
3 years ago
1603d1928e
Kill ProgressiveFileCopier and seek to end for ongoing livetv
3 years ago
71ab4a5754
Fix it for real(tm) this time
3 years ago
8dc0911374
Fix log message
3 years ago
e3dac4fda2
Use async FileStreams where it makes sense
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
42a2cc1747
Remove some unnecessary allocations
4 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
4 years ago
608cba817c
Reduce some allocations with the magic of spans etc.
4 years ago
8933389753
Respect user settings for transcode and remux
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
043d045448
Put json serializer options in private field
4 years ago
2a574914ea
Use streams instead of strings
4 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
4db5700e18
Don't take a lock if there's no intention to manipulate the list of open streams. Instead, use a ConcurrentDictionary so that, in those situations, thread-safe access to the dictionary is ensured.
4 years ago
01e781035f
Fix warnings
4 years ago
7324b44c43
Fix warnings
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
9ad839c776
Initial migration code
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
573da63d41
Register and construct IMediaSourceManager correctly
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
d217f1614e
Merge pull request #2096 from Bond-009/embytv
...
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
bb236b9591
Merge branch 'master' into warn12
5 years ago
e714b9930e
Merge branch 'master' into embytv
5 years ago
a253fa616d
Fix build and address comments
5 years ago
aca31457c0
merge branch master into media-attachments
5 years ago
2ef4ffd698
More warnings (removed)
5 years ago
Bond_009
Cody Robibero
jakobkukla
Patrick Barron
cvium
David
Ryan Petris
telans
Mark Monteiro
dkanada