608cba817c
Reduce some allocations with the magic of spans etc.
3 years ago
851f610e11
Changed other method to match for consistency.
3 years ago
bc1cc2d04a
Remove unused using directives
3 years ago
80877aa945
Cleaned up "value assigned is not used in any execution path"
3 years ago
631df8c560
Merge pull request #5520 from Bond-009/hdhomerun2
3 years ago
aa76957338
Remove useless code
3 years ago
32853ca244
Add 'group-title' channel parsing
3 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
3 years ago
f9640f4366
Rewrite HdHomerunManager.ParseReturnMessage
3 years ago
e8b18e5f8f
Add test for HdHomerunManager.ParseReturnMessage
3 years ago
f5789483fd
Add test for HdHomerunManager.WriteSetMessage
3 years ago
b755c25217
Merge pull request #5220 from Bond-009/hdhomerun
3 years ago
ece0d67f99
Use FileShare.Read for log files
3 years ago
eca3b37d6e
Use FileShare.Read to fix HdHomeRun
3 years ago
60ffa6f514
Use FileShare.None when creating files
3 years ago
1c74e2f40e
Fix build
3 years ago
b1fe28d0a6
Use GetEncodingOptions where possible
3 years ago
eba859e33e
Minor improvements
3 years ago
13d65318eb
Merge pull request #5223 from Bond-009/minor10
...
Minor improvements
3 years ago
e9f22303a4
Properly forward cancellationTokens
3 years ago
65bab55ca0
Minor improvements
3 years ago
e1bc322b70
Add test for WriteGetMessage
3 years ago
3a9fcb6abd
Rewrite packet writing code for HdHomerun
3 years ago
aea1c4f310
Merge pull request #5142 from M0ssTee/updateRegex
...
Replaced /d with [0-9], see issue #2923
3 years ago
54a3ab15a3
Merge pull request #5005 from jellyfin/bytes
...
JsonSerializer deserialize from bytes where possible
3 years ago
8f88d0d2cb
Update Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
3 years ago
8c640a1492
Replaced /d with [0-9], see issue #2923
3 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
1ea2b200c0
JsonSerializer deserialize from bytes where possible
...
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
| Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 | - | - | 52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 | - | - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 | - | - | 31.27 KB |
```
4 years ago
054adf6379
Merge pull request #4853 from Ullmie02/servicestack-json
4 years ago
3dec1fd6b2
Use UTF8 encoding and async correctly
4 years ago
21fd124bca
Code revie
4 years ago
f73bb92ce3
Remove manual N/A removal and write directly to stream
4 years ago
043d045448
Put json serializer options in private field
4 years ago
e835dfb27d
Use sync string instead of file
4 years ago
2a574914ea
Use streams instead of strings
4 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
c0c0eaec05
new List(int) does not pre-allocate indicies like Arrays, it merely sets the initial capacity.
4 years ago
f322866127
Merge pull request #4737 from crobibero/missing-ensure-success
4 years ago
a9aafbaf5a
Don't throw exception unless needed
4 years ago
c0fde3496c
Add tests for HdHomerunHost.TryGetTunerHostInfo
4 years ago
514d95e5aa
Add tests for HdHomerunHost.GetLineup
4 years ago
e6650651b3
Merge pull request #4738 from jellyfin/tests8
...
Add tests for HdHomerunHost.GetModelInfo
4 years ago
7027561e19
Add tests for HdHomerunHost.GetModelInfo
4 years ago
b6ecaccf92
Merge pull request #4730 from crobibero/base-item-dto-guid-nullable
...
Don't serialize empty GUID to null
4 years ago
e621244405
Add missing EnsureSuccessStatusCode
4 years ago
26e5aacb90
Fix JsonConverter recursion
4 years ago
8517b28eba
Make BaseItemDto Guids nullable
4 years ago
66a1880a58
Add number to bool json converter
4 years ago
e4fd61411f
Minor improvements
4 years ago
0a35f35311
Merge pull request #4591 from jellyfin/schedulesdirect
...
Clean up SchedulesDirect
4 years ago
9169a28df1
Merge pull request #4588 from jellyfin/hex
...
Remove Hex class as the BCL has one now
4 years ago
81ca6cb47c
Clean up SchedulesDirect
4 years ago
38932fc7d1
Schedules Direct requires the hex to be lowercase
4 years ago
8c8a71692e
Remove Hex class as the BCL has one now
4 years ago
0acea5b077
Don't throw null reference if ContentType is null.
4 years ago
2c9e355e42
Merge branch 'master' into NetworkPR2
4 years ago
d5eb7e786f
Merge pull request #4182 from ryanpetris/fix-hdhomerun
...
Fix HD Home Run streaming
4 years ago
8f25eaeb9d
Update Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
616caca2b7
Added more comments.
4 years ago
7a6063ed41
Merge branch 'master' into NetworkPR2
4 years ago
e21e00cad5
Merge remote-tracking branch 'upstream/master' into no-scaling
4 years ago
a3e47f3e4e
Updated to latest Unstable.
4 years ago
e51ddd326c
Fixes spelling.
4 years ago
38c3b6fcd3
Fix build and thread detection logic
4 years ago
4b1c9dc9ea
Pass cancellation where possible
4 years ago
94cae4f145
Specify threads to ffmpeg properly
4 years ago
d66f88672c
Merge branch 'master' into NetworkPR2
4 years ago
8204b25a56
Merge branch 'master' into fix-hdhomerun
4 years ago
81d5eb4db5
Return a Task object and discard it instead of using async void.
4 years ago
e66d79fc0c
Merge remote-tracking branch 'upstream/master' into http-exception
4 years ago
95a2de757f
remove custom HttpException
4 years ago
c4bb32f259
Access last element by index where possible
4 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
73f9a6d7d0
Convert array property to IReadOnlyList
4 years ago
e9d35cb2ca
Switching to the more efficient Hex.Encode function
4 years ago
866c41519f
Perform hashing of Password for Schedules Direct on server
4 years ago
082705c0d8
Merge pull request #4410 from crobibero/m3u-user-agent
...
Set UserAgent when getting M3u playlist
4 years ago
ec245dce90
Merge branch 'master' into NetworkPR2
4 years ago
b4d52d8009
Apply patch
4 years ago
5d88e61076
Merge remote-tracking branch 'upstream/master' into livetv-ts-fix
4 years ago
6205fb4b6a
Merge pull request #4341 from Bond-009/minor6
...
Minor improvements
4 years ago
6763d456ff
Set UserAgent when getting M3u playlist
4 years ago
83af636c61
Updated with new NetManager
4 years ago
0c674b496f
Add stream disposal comment.
4 years ago
3568c5f39b
Fix early filestream close
4 years ago
0b5ddc90ff
Merge branch 'master' into NetworkPR2
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
6f9beef732
Fix SA1012 and SA1013 warnings
4 years ago
53af1e3455
Updatig netcollection & re-inserting BOM
4 years ago
fcd1b2f0e4
Merged with latest master
4 years ago
7775066475
Merge pull request #4236 from ConfusedPolarBear/warnings1
...
Fix some warnings
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
3fa3a9d57a
Preemptively throw a LiveTvConflictException when the tracked live streams for a given device/tuner will exceed the number of supported streams.
4 years ago
361f51ac94
Use TcpClient.Connect().
4 years ago
0496e18179
Fix HD Home Run streaming.
...
* Use LocalEndPoint instead of RemoteEndPoint when determining local address.
* HdHomerunUdpStream.StartStreaming is meant to run until stream is closed, however HdHomerunUdpStream.Open needs to return as soon as stream is open to send stream url back to client. Therefore, StartStreaming should not be awaited on.
* TcpClient(IPEndPoint) treats endpoint as the local endpoint; use TcpClient(string, int) instead as it treats endpoint as the remote endpoint.
4 years ago
38b8110a3e
Removing blank lines.
4 years ago
b44455ad0d
Update based on PR1 changes.
4 years ago
9ef79d190b
Large number of files
4 years ago
384ab39f5b
Fix some warnings
4 years ago
23df4991b6
Use proper buffer size
4 years ago
2a8653b309
Merge remote-tracking branch 'upstream/master' into http-client-migrate
4 years ago
ae8ff1ca54
last time I swear
4 years ago
4d4dc0b555
Remove ResponseHeadersRead in SchedulesDirect
4 years ago
d8a0edc511
Revert "Remove ResponseHeadersRead where applicable"
...
This reverts commit 85844a84b6
4 years ago
85844a84b6
Remove ResponseHeadersRead where applicable
4 years ago
b111b9e2c9
Fix styling
4 years ago
e1d0b430d9
Remove HttpRequestOptions
4 years ago
4038d15c83
Properly migrate all HttpCompletionOption
4 years ago
e653eef44f
Fix some warnings
4 years ago
8d592777c4
change to using declaration
4 years ago
6ae4da709e
migrate to IHttpClientFactory in M3UTunerHost
4 years ago
5b93b3b15e
migrate to IHttpClientFactory in M3uParser
4 years ago
af9ebef577
migrate to IHttpClientFactory in SharedHttpStream
4 years ago
96fdee38cb
migrate to IHttpClientFactory in HdHomerunHost
4 years ago
97cc3d54bb
migrate to IHttpClientFactory in XmlTvListingsProvider
4 years ago
652e688cc1
migrate to IHttpClientFactory in SchedulesDirect
4 years ago
50a1e35765
migrate to IHttpClientFactory in EmbyTV
4 years ago
804b0fc034
migrate to IHttpClientFactory in DirectRecorder
4 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
4 years ago
119f64f5e7
Make some methods async
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
98ed90c4a2
Merge branch 'master' into event-rewrite-1
4 years ago
68edccd9f4
More warn
4 years ago
e77a45adcf
Minor change
4 years ago
2b400c99ef
Fix warnings
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
70e56314d7
Minor fixes to LiveTvMediaSourceProvider
4 years ago
8373d6297c
Fix MemoryCache usage
4 years ago
5c65abcd94
Clean up TunerHost classes
4 years ago
b7421db5fe
Merge pull request #3578 from barronpm/displaypreferences-efcore
...
Migrate Display Preferences to EF Core
4 years ago
d7287a05ad
Merge pull request #3684 from Bond-009/warn22
...
Fix warnings
4 years ago
01e781035f
Fix warnings
4 years ago
3ff110984a
Merge branch 'master' into readonlyspan
4 years ago
3d69cea1c9
Merge branch 'master' into displaypreferences-efcore
4 years ago
7adac7561a
Use System.Text.Json in LiveTvManager
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
afe09612e8
fix SA1119
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
4 years ago
7a115024aa
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# MediaBrowser.Controller/Library/ILibraryManager.cs
# MediaBrowser.Providers/Users/UserMetadataService.cs
4 years ago
22a860a806
Fix a small number of compile warnings
4 years ago
57d1dbfe7b
undo erroneous changes
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
4 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
7439e095e2
Merge branch 'master' into nullable3
4 years ago
eef7cfd912
Make SonarCloud less angry
4 years ago
01ce56016a
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
# MediaBrowser.Api/UserService.cs
# MediaBrowser.Controller/Library/IUserManager.cs
4 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
4 years ago
c464f700db
Remove redundant qualifiers
4 years ago
668a7b97c7
Merge pull request #3072 from JustAMan/fix-dead-livetv
...
Re-raise the exception that caused LiveTV stream to not open
4 years ago
c70e38288c
Apply suggestions from code review
...
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
4 years ago
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
4 years ago
f08830ea00
Merge pull request #2774 from mark-monteiro/simplify-https-config
...
Simplify HTTPS Properties
4 years ago
9ad839c776
Initial migration code
4 years ago
62420a6eb1
Remove support for injecting ILogger directly
4 years ago
43c22a5822
Add GetLoopbackHttpApiUrl() helper method to replace forceHttps functionality
...
Also refactor to use return a Uri instead of a string and use UriBuilder under the hood
4 years ago
3401d55f41
Fixed yet another case of hanging on a bad stream
4 years ago
a517bd2e52
Re-raise the exception that caused LiveTV stream to not open
4 years ago
f502c89331
Merge pull request #2798 from JustAMan/fix-livetv-again
...
Make localhost LiveTV restreams always use plain HTTP port
4 years ago
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
4 years ago
eda208e258
Merge pull request #2829 from Bond-009/warn19
...
Fix some warnings
4 years ago
fc049caba2
Merge branch 'master' into nullable3
4 years ago
9728aa8b0a
Merge branch 'master' into register-services-correctly
4 years ago
4113288278
Fix style issues
4 years ago
7152b55747
Use a separate line for each property initializer
4 years ago
49fe5e0a21
Fix some warnings
4 years ago
e85f9f5613
Make localhost LiveTV restreams always use plain HTTP port
4 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
658e963e93
replace 'try-finally' with 'using' where appropriate
4 years ago
cb2d99e831
Construct LiveTvDtoService and LiveTvManager correctly
4 years ago
3d5b4f869c
Register ILiveTvManager and IPlaylistManager correctly
4 years ago
e0f40f57d8
Merge remote-tracking branch 'upstream/master' into remove-common-process
4 years ago
2be394089e
Enable Microsoft.CodeAnalysis.FxCopAnalyzers for Jellyfin.Common
4 years ago
f31efce52d
Merge branch 'master' into usings
4 years ago
3ab50f5a3f
Address comments
4 years ago
7447ea8960
Make sure Process objects are all disposed correctly
4 years ago
b947d98266
Delete unnecessary ProcessFactory abstraction
4 years ago
ee2f911a2b
Remove unnecessary CommonProcess abstraction
4 years ago
e9d1eabd53
Remove unused usings
4 years ago
94fe9b8f6d
Merge branch 'master' into warn17
4 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
4 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
4 years ago
184ad29f3f
Address comments
4 years ago
7060934792
Fix some warnings in Emby.Server.Implementations
4 years ago
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
4 years ago
87d2479b78
Fix warnings
4 years ago
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
4 years ago
c8409d2ea1
Remove FileSystem.GetStream
5 years ago
cvium
BaronGreenback
Bond-009
LIAUD
David
dkanada
M0ssTee
Ryan Petris
Claus Vium
crobibero
Joshua M. Boniface
Fernando Fernández
Neil Burrows
Anthony Lavado
Jan-Pieter Baert
Matt Montgomery
Patrick Barron
Patrick Barron
telans
aled
Vasily
Mark Monteiro
Vasily