a8ed753f6c
FxCop -> Net Analyzers (part 2)
3 years ago
ece0d67f99
Use FileShare.Read for log files
3 years ago
60ffa6f514
Use FileShare.None when creating files
3 years ago
1c74e2f40e
Fix build
3 years ago
1ea2b200c0
JsonSerializer deserialize from bytes where possible
...
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
| Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 | - | - | 52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 | - | - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 | - | - | 31.27 KB |
```
4 years ago
3dec1fd6b2
Use UTF8 encoding and async correctly
4 years ago
21fd124bca
Code revie
4 years ago
f73bb92ce3
Remove manual N/A removal and write directly to stream
4 years ago
043d045448
Put json serializer options in private field
4 years ago
e835dfb27d
Use sync string instead of file
4 years ago
2a574914ea
Use streams instead of strings
4 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
e21e00cad5
Merge remote-tracking branch 'upstream/master' into no-scaling
4 years ago
38c3b6fcd3
Fix build and thread detection logic
4 years ago
4b1c9dc9ea
Pass cancellation where possible
4 years ago
94cae4f145
Specify threads to ffmpeg properly
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
23df4991b6
Use proper buffer size
4 years ago
2a8653b309
Merge remote-tracking branch 'upstream/master' into http-client-migrate
4 years ago
4038d15c83
Properly migrate all HttpCompletionOption
4 years ago
e653eef44f
Fix some warnings
4 years ago
8d592777c4
change to using declaration
4 years ago
50a1e35765
migrate to IHttpClientFactory in EmbyTV
4 years ago
804b0fc034
migrate to IHttpClientFactory in DirectRecorder
4 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
2b400c99ef
Fix warnings
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
403cd3205f
Merge pull request #3254 from crobibero/ilogger
...
Use typed logger where possible
4 years ago
22a860a806
Fix a small number of compile warnings
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
4 years ago
7439e095e2
Merge branch 'master' into nullable3
4 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
4 years ago
43c22a5822
Add GetLoopbackHttpApiUrl() helper method to replace forceHttps functionality
...
Also refactor to use return a Uri instead of a string and use UriBuilder under the hood
4 years ago
fc049caba2
Merge branch 'master' into nullable3
4 years ago
4113288278
Fix style issues
4 years ago
7152b55747
Use a separate line for each property initializer
4 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
658e963e93
replace 'try-finally' with 'using' where appropriate
4 years ago
e0f40f57d8
Merge remote-tracking branch 'upstream/master' into remove-common-process
4 years ago
2be394089e
Enable Microsoft.CodeAnalysis.FxCopAnalyzers for Jellyfin.Common
4 years ago
3ab50f5a3f
Address comments
4 years ago
7447ea8960
Make sure Process objects are all disposed correctly
4 years ago
b947d98266
Delete unnecessary ProcessFactory abstraction
4 years ago
ee2f911a2b
Remove unnecessary CommonProcess abstraction
4 years ago
94fe9b8f6d
Merge branch 'master' into warn17
4 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
4 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
4 years ago
7060934792
Fix some warnings in Emby.Server.Implementations
4 years ago
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
4 years ago
87d2479b78
Fix warnings
4 years ago
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
4 years ago
c8409d2ea1
Remove FileSystem.GetStream
5 years ago
e714b9930e
Merge branch 'master' into embytv
5 years ago
fdbb329118
Remove StringHelper functions
5 years ago
5a8e972952
Enable TreatWarningsAsErrors for some projects
...
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
5 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
b477b3874e
Fix some warnings
5 years ago
d9a03c9bb1
Fix more warnings
5 years ago
bbc0875387
Don't shuffle some types by default
5 years ago
c9820d30ed
Fix multiple mistakes and warnings
5 years ago
8fe7b6551f
Rewrite `ItemDataProvider` to be more robust
...
* Stop locking 2+ times per operation
* Don't clone the list multiple times
* Keep the lock for the duration of the operation
5 years ago
cb393c215a
Merge pull request #1686 from Bond-009/warn7
...
More warning fixes
5 years ago
e4f893a0eb
More warning fixes
5 years ago
0aaaaab7a0
Fix invalid arg for
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
d405a400aa
Fixes issues with HttpClientManager
5 years ago
b44a70ff36
Simplify/remove/clean code
...
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant
And ofc fix some warnings ;)
5 years ago
1fef8bf266
Merge pull request #1060 from Bond-009/assinfo
...
Remove redundant class AssemblyInfo
5 years ago
37ea50a572
Reduce the amount of exceptions thrown
5 years ago
e91dd14b31
Remove redundent class AssemblyInfo
5 years ago
73c1cdb32a
Avoid exceptions due to folder and file not found
...
1) Use function to return path to temp transcode path which has benefit of creating temp folder if not exists, thereby avoiding the exception when GetFilePaths is used.
2) Check json files exists before attempting to read from it. Avoids having to mask FileNotFound exceptions when debugging.
5 years ago
a6a4cd5667
Removed some unused fields
5 years ago
0ef2b46106
Remove custom Threading
5 years ago
0b3e6548db
Merge pull request #797 from Bond-009/warnings
...
Fix all warnings
6 years ago
c4f51e16a5
Merge pull request #736 from Bond-009/startasync
...
Start startup tasks async
6 years ago
78e4e2ed92
Fix all warnings
6 years ago
5ac6d0ae59
Fix more warnings
6 years ago
1ea219bf3f
Merge branch 'master' into culture
6 years ago
581a7fe078
Unwrapped `MoveDirectory`, `DirectoryExists`, `FileExists` & removed `MoveFile`
6 years ago
a430568082
Unwrapped `OpenRead` and `CopyFile`
6 years ago
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
6 years ago
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
6 years ago
85a58fd655
Start startup tasks async
6 years ago
a709cbdc64
Fix more analyzer warnings
6 years ago
fd7f420af2
Remove remnants of system events
6 years ago
722120af74
Remove conditions that are always true/false
6 years ago
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
6 years ago
49b61f238e
Merge branch 'dev' into reformat
...
# Conflicts:
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
# Emby.Server.Implementations/LiveTv/LiveTvManager.cs
# Emby.Server.Implementations/Security/MBLicenseFile.cs
# Emby.Server.Implementations/Security/PluginSecurityManager.cs
# Emby.Server.Implementations/Security/RegRecord.cs
# MediaBrowser.Api/PluginService.cs
# MediaBrowser.Api/System/SystemService.cs
# MediaBrowser.Common/Security/IRequiresRegistration.cs
# MediaBrowser.Common/Security/ISecurityManager.cs
# MediaBrowser.Common/Security/PaymentRequiredException.cs
# MediaBrowser.Model/Entities/MBRegistrationRecord.cs
# MediaBrowser.Model/Entities/PluginSecurityInfo.cs
# deployment/win-generic/build-jellyfin.ps1
6 years ago
22a64f37f5
More cleaning
6 years ago
0e422a33d6
Some code style clean up
6 years ago
eca3c099d9
removed a bunch of validation, security, registration, premiere, whatever bs
6 years ago
e867446437
ReSharper format: conform inline 'out' parameters.
6 years ago
65bd052f3e
ReSharper conform to 'var' settings
6 years ago
Bond_009
David
Fernando Fernández
crobibero
Patrick Barron
telans
dkanada
aled
Vasily
Mark Monteiro
Anthony Lavado
PloughPuff
Claus Vium
Joshua M. Boniface
Erwin de Haan