4d681e3cad
Optimize StringBuilder.Append calls
4 years ago
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
4 years ago
65453c0a84
Fix build and more Append calls
4 years ago
39be99504f
Improve DescriptionXmlBuilder
...
* Replace XML escape code with SecurityElement.Escape
* Optimize StringBuilder.Append calls
4 years ago
672a35db94
Update DlnaServerService.cs
4 years ago
f9b0816b80
Changes a suggested.
4 years ago
ab396225ea
Migrate Display Preferences to EF Core
4 years ago
0f696104ac
using missing.
4 years ago
c7c28db17b
Update DlnaServerService.cs
4 years ago
d9f9412955
Update DlnaServerService.cs
4 years ago
6d1b00da64
Use Array.Empty
4 years ago
43221fc26b
Merge branch 'master' into SSDP
4 years ago
7f307f9082
brace multiline if statements
4 years ago
98db8f72e0
fix SA1503 for one line if statements
4 years ago
8e3d874802
remove regions
4 years ago
215ab39e00
Merge pull request #3342 from BaronGreenback/BugFix2
...
Fix for [DLNA] Many log messages from Media Renderers trying to see old events
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
6d6793151a
Null pointer check added for subscription as 2nd param is false.
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
726e116d5b
fix SA1510
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
4d9171f691
Update DlnaEntryPoint.cs
...
Left a _config behind.
4 years ago
5cf44e7736
Removed spaces
4 years ago
93568be3e7
Updates
4 years ago
57d1dbfe7b
undo erroneous changes
5 years ago
44957c5a9a
Use typed logger where possible
5 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
5 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
5 years ago
7439e095e2
Merge branch 'master' into nullable3
5 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
5 years ago
c464f700db
Remove redundant qualifiers
5 years ago
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
5 years ago
9ad839c776
Initial migration code
5 years ago
15634a1913
Merge branch 'master' into websocket
5 years ago
8a69300bf5
Changes styles as suggested by @barronpm
...
Added addtional comments & source type as per intellisense suggestion
change code as per sonacloud
5 years ago
ebd589aa86
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
5 years ago
a3140f83c6
Revert "Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored."
...
This reverts commit 2aaecb8e14
5 years ago
2aaecb8e14
Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.
...
Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).
Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)
All these changes are related.
Changes
1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed #986 mod - as this was part of the issue of #2986 . Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
5 years ago
4fa6d1ccee
Merge pull request #2940 from balu92/master
...
Fix missing colons
5 years ago
ca4b6836c1
Merge pull request #2906 from randrey/dlna-nullref-fix
...
Fix InvalidOperationException while browsing via DLNA client.
5 years ago
118f30059c
Merge branch 'master' into nullable4
5 years ago
461b298be7
Migrate DlnaServerController to Jellyfin.Api
5 years ago
f5385e4735
Move Emby.Dlna DlnaService.cs to Jellyfin.Api
5 years ago
c0b3c11b2e
Merge pull request #2846 from jellyfin/azure
...
Remove requirement to build web during server builds
5 years ago
c5f163293f
Add <ProjectGuid> properties to all project files
...
This is required for SonarCloud analysis to run
5 years ago
80f5dd1e59
Fixed missing colons
...
some colons were missing from the default ProtocolInfo string
5 years ago
0bef4eef87
Fix InvalidOperationException while browsing via DLNA client.
5 years ago
eba781eac5
Fix DLNA clients displaying wrong album art.
5 years ago
2fcbc2a5b8
Enable nullabe reference types for Emby.Drawing and Jellyfin.Drawing.Skia
5 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
d5cc10d7e1
Merge pull request #2741 from Bond-009/dlnawarnings2
...
Fix some warnings
5 years ago
64692af1a2
Update Device.cs
5 years ago
91b17e7289
Update Device.cs
5 years ago
4cacfd5997
Update DidlBuilder.cs
5 years ago
ad0e2e42e6
Update Device.cs
5 years ago
3161e85f76
Address comments
5 years ago
f6c9a44703
Update Device.cs
5 years ago
231c1e519f
Update Emby.Dlna.csproj
5 years ago
a37b69a493
Merge pull request #2559 from whooo/295-fix
...
Add descriptive TV episode titles for DLNA browsing
5 years ago
8a566dfe73
Fix build
5 years ago
be8ba96183
Fix some warnings
5 years ago
62a18af17a
Update Emby.Dlna/Main/DlnaEntryPoint.cs
...
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
5 years ago
b63ed35238
Add descriptive TV episode titles for DLNA browsing
...
When browsing TV episodes in Next Up, etc via DLNA a more descriptive
title should be used to easier identify the right episode.
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
241e351a61
Merge branch 'master' into dlnawarnings
5 years ago
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
5 years ago
87d2479b78
Fix warnings
5 years ago
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
5 years ago
d69870680b
Close xmlwriter first
5 years ago
6ee04855cd
Style
5 years ago
ae9c1e29e7
My bad
5 years ago
36d62c3093
Fix?
5 years ago
6b68521bae
Try again
5 years ago
fc578de3b3
Try possible solutions
5 years ago
bade35958a
Fix
5 years ago
3a338c1899
Address comments
5 years ago
c8409d2ea1
Remove FileSystem.GetStream
5 years ago
82112b6788
Improvements to dlna server
...
* Improve response writer
* Add analyzers
* Error on warnings in release mode
* Disable doc warnings
5 years ago
1dd4abebbd
Merge pull request #2297 from Bond-009/asyncio
...
Kestrel doesn't like sync IO operations
5 years ago
5340eb9363
Update Emby.Dlna/Service/BaseControlHandler.cs
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
ac3b958c67
Use async methods
5 years ago
f2eea89ff0
Fix pagination for DLNA root folder list
...
Previously, when responding to a DLNA "Browse" request, the
`StartingIndex` was not respected and all of the root items were
returned each time. This caused infinite loops with in DLNA clients that
ignored the `TotalMatches` data in the response and just continued
asking for the next page until they got an empty response.
This fix makes the root folder list respect the `StartingIndex` and
`RequestedCount` parameters like all other responses.
Fixes issue #2303
5 years ago
2610f377c0
Kestrel doesn't like sync IO operations
5 years ago
976459d3e8
Rewrite WebSocket handling code
5 years ago
fdbb329118
Remove StringHelper functions
5 years ago
49330e3082
Fix a couple of TODOs
5 years ago
dee3076eaf
Merge pull request #1923 from Bond-009/random
...
Don't shuffle some types by default
5 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
94edb5b9f9
Add else
5 years ago
a6f883345f
Reduce #lines
5 years ago
3221e837f9
* Add support for multi segment base urls
...
* Make baseurl case-insensitive
5 years ago
69d76af054
dlna GetPathValue
...
Forgot to update this last time, just copied the code from `MediaBrowser.Api/BaseApiService.cs`
5 years ago
5ee070eb29
Remove leading / from baseurl
5 years ago
d161b9cbfc
Fix GetPathValue function for DLNA service
5 years ago
Bond_009
BaronGreenback
Patrick Barron
Cody Robibero
telans
dkanada
Vasily
Joshua M. Boniface
Mark Monteiro
Unknown
randrey
a1
Erik Larsson
Claus Vium
Carey Metcalfe