2e338f74ec
Fix (another) ArgumentNullException while scanning music
...
```
[2024-07-17 14:31:18.202 +02:00] [ERR] [19] MediaBrowser.Providers.Music.AudioMetadataService: Error in "Probe Provider"
System.ArgumentNullException: Value cannot be null. (Parameter 'value')
at System.ArgumentNullException.Throw(String paramName)
at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)
at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
at MediaBrowser.Model.Entities.ProviderIdsExtensions.SetProviderId(IHasProviderIds instance, String name, String value) in /home/loma/dev/jellyfin/MediaBrowser.Model/Entities/ProviderIdsExtensions.cs:line 121
at MediaBrowser.Model.Entities.ProviderIdsExtensions.SetProviderId(IHasProviderIds instance, MetadataProvider provider, String value) in /home/loma/dev/jellyfin/MediaBrowser.Model/Entities/ProviderIdsExtensions.cs:line 151
at MediaBrowser.Providers.MediaInfo.AudioFileProber.FetchDataFromTags(Audio audio, MediaInfo mediaInfo, MetadataRefreshOptions options, Boolean tryExtractEmbeddedLyrics) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 330
at MediaBrowser.Providers.MediaInfo.AudioFileProber.FetchAsync(Audio audio, MediaInfo mediaInfo, MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 139
at MediaBrowser.Providers.MediaInfo.AudioFileProber.Probe[T](T item, MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 105
at MediaBrowser.Providers.Manager.MetadataService`2.RunCustomProvider(ICustomMetadataProvider`1 provider, TItemType item, String logName, MetadataRefreshOptions options, RefreshResult refreshResult, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 800
```
8 months ago
60c45d6273
Use complete paths in BD info
...
This way we don't need to find the complete path later
9 months ago
e063fcb036
Backport pull request #12166 from jellyfin/release-10.9.z
...
Fix HDR detection for 4K Blu-Ray BDMVs
Original-merge: 30fc089dd5
9 months ago
ea7e834ae1
Backport pull request #12126 from jellyfin/release-10.9.z
...
Try to add extracted lyrics during scanning
Original-merge: 25f02658f0
9 months ago
2599babe31
Backport pull request #11859 from jellyfin/release-10.9.z
...
Use music metadata from ffprobe when TagLib fails
Original-merge: b8a0cf6a9e
10 months ago
2af1ae5d8a
Backport pull request #11792 from jellyfin/release-10.9.z
...
Improve reliability of HasChanged check
Original-merge: b2d54b82fa
10 months ago
4385430f05
Backport pull request #11621 from jellyfin/release-10.9.z
...
Handle exception for unexpected audio file YEAR tag values
Original-merge: d5dc4435d9
10 months ago
cf483203f5
Fix external LRC files being incorrectly overwritten during the initial scan ( #11480 )
11 months ago
88a38a61b5
Improve audio normalization
...
* Move calculation of LUFS to a scheduled task as it's pretty slow
* Correctly calculate album LUFS
* Don't try to convert replaygain tags to LUFS values
11 months ago
428283f787
Always scan ReplayGain tag ( #11418 )
11 months ago
3936fc9f25
Don't run ffprobe a second time for music file ( #11419 )
11 months ago
d402005d32
fix: fallback to artist if album artist not provided
12 months ago
ab731d9212
Fix track MBID in audio metadata ( #11301 )
12 months ago
b6d130ae2d
Merge pull request #11155 from sel10ut/bugfix/fix-releasedate-tag
...
Fix parsing of audio PremiereDate property
1 year ago
368a1b385a
fix: fallback to TagLib date parsing if ffprobe fails
...
Bring back hardcoded PremiereDate with correctly parsed year from TagLib, if ffprobe cannot get it
1 year ago
e9caa65eba
fix: change parsing of audio title tag
1 year ago
1236bb298c
fix: correct parsing of audio release date property
...
Read full date from ffmpeg probe.
1 year ago
35df0486f5
Merge pull request #11081 from crobibero/embedded-lyrics
...
Save embedded lyrics when probing audio
1 year ago
5a4aff36c1
Merge pull request #11079 from crobibero/bdinfo-codec
...
Always use ffmpeg codec for bluray
1 year ago
169e0dcb11
Save embedded lyrics when probing audio
1 year ago
ac33d1593a
oops
1 year ago
5a652360c3
Update AudioFileProber.cs
1 year ago
ddf8f7d636
Update AudioFileProber.cs
1 year ago
f3c333f4d5
Merge branch 'master' into bhowe34/fix-replace-missing-metadata-for-music
1 year ago
c603cd2e4e
Always use ffmpeg codec for bluray
1 year ago
54eb81395e
Merge branch 'master' into bhowe34/fix-replace-missing-metadata-for-music
1 year ago
0bc41c015f
Store lyrics in the database as media streams ( #9951 )
1 year ago
7b5c41c2a5
Add option to use replaygain tags for audio ( #10566 )
...
* Add option to use replaygain tags for audio
* Change regex to be specific
* Use ffprobe for faster metadata grabs
* Change regex to .Match
1 year ago
7f1fec688c
check ReplaceAllMetadata option and name field lock
1 year ago
ddcd29f17e
Update MediaBrowser.Providers/MediaInfo/AudioFileProber.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
1 year ago
de91a213a1
Update MediaBrowser.Providers/MediaInfo/AudioFileProber.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
1 year ago
81d642abe3
Removing unnecesary empty and null validations
1 year ago
eb41cd51ea
Using TryGetProviderId and adding an empty validation
1 year ago
01bbc7d117
Correcting according to the comments provided
1 year ago
d1cc56f78c
Fix: "Feature 'replace missing metadata' overwrites existing metadata that does exist" for music
1 year ago
b62b0ec2b5
Fix warnings
1 year ago
892973a9e3
Merge branch 'master' into media-type
1 year ago
8d7e4229ca
Merge branch 'master' into fix-resharper-warnings
...
# Conflicts:
# Emby.Server.Implementations/Net/SocketFactory.cs
# RSSDP/SsdpCommunicationsServer.cs
# RSSDP/SsdpDeviceLocator.cs
# RSSDP/SsdpDevicePublisher.cs
1 year ago
2920611ffc
Convert string MediaType to enum MediaType
1 year ago
c707baed83
Jellyfin.Drawing minor improvements
...
Reduce duplicate/dead code
1 year ago
8ea812b65d
Reduce string literal length by using verbatim string
1 year ago
d6b557d9ee
Move declaration closer to usage
1 year ago
debbfaa502
Fix MJPEG video is recognized as embedded image ( #10173 )
...
fixes 1d729b2
2 years ago
18a311d32f
== null -> is null
2 years ago
d92e9ae85e
Enable nullable for more files and add tests
...
Adds basic tests for FFProbeVideoInfo.CreateDummyChapters
Fixed error message CreateDummyChapters instead of reporting the total minutes it only reported the minute component
2 years ago
956e3dab43
fix: accessing Standard* of a Process requires manually disposing them afterwards ( #10125 )
2 years ago
66ff724acf
Fix the probing of m4a metadata
...
The composer is not set in some of my m4a files. For some reason
TagLibSharp returns the composer as an empty string in this case. This
causes an exception in PeopleHelper.AddPerson, and thus probing fails.
IMHO we can simply ignore empty values.
Fixes : #10061
2 years ago
b5f0760db8
Use RegexGenerator where possible
2 years ago
603fce59df
Audio normalization ( #9222 )
...
Co-authored-by: Joe Rogers <1337joe@users.noreply.github.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
2 years ago
89be3aa37f
Convert Person.Type to use PersonKind enum ( #9487 )
2 years ago
Bond_009
gnattu
Shadowghost
nfmccrina
Cody Robibero
Dominik Krivohlavek
sel10ut
Brian Howe
TelepathicWalrus
GinoGinocchio
GinoGinocchio
Stepan Goremykin
Nyanmisaka
Claus Vium
Jan Müller