655208d375
Now parse date in header correctly as being in UTC
5 years ago
93649ad77b
Merge remote-tracking branch 'upstream/master' into simplify-https-config
5 years ago
07326c1d9b
Merge branch 'master' into fix-auth-response-codes
5 years ago
7f4a229cd2
Add some simple tests
5 years ago
d62bd7fecd
fix spelling error
5 years ago
6b959f40ac
Fix build
5 years ago
f055995a1f
Use System.Buffers in RangeRequestWriter
5 years ago
95dc99fdbd
Update Emby.Server.Implementations/HttpServer/HttpResultFactory.cs
...
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
9df49cc796
Make Last-Modified and If-Modified-Since headers follow the spec
5 years ago
8b4b4b4127
Do not return the exception message to the client for AuthenticationExceptions
5 years ago
a8c3951c17
Only show developer exception page for 500 server exceptions
...
Other response codes should be returned as normal
5 years ago
53380689ad
Return correct status codes for authentication and authorization errors
...
- Use AuthenticatonException to return 401
- Use SecurityException to return 403
- Update existing throws to throw the correct exception for the circumstance
5 years ago
6d35dd6b32
Clean up SecurityException
...
- Remove unused SecurityExceptionType
- Add missing constructor for InnerException
- Add missing documentation
5 years ago
3bdb5e80a5
More consise error messages
5 years ago
058c35e739
Fix log highlithing
5 years ago
30f4392872
Fix condition flipped by https://github.com/jellyfin/jellyfin/pull/2635
5 years ago
61d9c9df5b
Addressing review feedback
5 years ago
71d8e66d9f
Add logging of URL being processed when logging an error
...
This might help diagnosing stuff like "Operation was cancelled"
5 years ago
387fa474aa
Document HTTPS configuration options
5 years ago
ca71ac72ab
Replace EnableHttps and SupportsHttps with ListenWithHttps and CanConnectWithHttps
5 years ago
de634203d8
Put Boolean operators at beginning of lines instead of the end
5 years ago
eadad73117
Merge branch 'master' into use-development-exception-page
5 years ago
123bfbcf19
Merge remote-tracking branch 'upstream/master' into use-development-exception-page
5 years ago
5b1091db27
Merge remote-tracking branch 'upstream/master' into do-not-instantiate-services-at-startup
5 years ago
f31efce52d
Merge branch 'master' into usings
5 years ago
e9d1eabd53
Remove unused usings
5 years ago
72c822513f
Create ServiceController via DI instead of manual construction
5 years ago
dc140429fe
Do not create unnecessary instances of IService at server startup
5 years ago
842ec04828
Do not handle exceptions manually when in development mode
5 years ago
92628c4033
Clean up HTTP listener exception handling
5 years ago
e2685c51ec
Merge remote-tracking branch 'upstream/master' into support-running-without-web-content
5 years ago
6fbdf0d6a2
Construct ApplicationHost with DI framework instead of manually
5 years ago
94fe9b8f6d
Merge branch 'master' into warn17
5 years ago
3f4b9e9a81
Add new 'nowebcontent' configuration flag
5 years ago
3043b7323b
Use constants for settings keys
5 years ago
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
7060934792
Fix some warnings in Emby.Server.Implementations
5 years ago
c751ba9f70
Fix build
5 years ago
c8409d2ea1
Remove FileSystem.GetStream
5 years ago
ee964f8a58
Don't log message info
5 years ago
d01ba49be3
Fix space
5 years ago
f89e18ea26
Improve error handling
5 years ago
bdd823d22f
Handle unexpected disconnect
5 years ago
8865b3ea3d
Remove dead code and improve logging
5 years ago
4d311870d2
Fix websocket handling
5 years ago
5ca68f9623
Fix nullref exception and added logging
5 years ago
976459d3e8
Rewrite WebSocket handling code
5 years ago
2ef4ffd698
More warnings (removed)
5 years ago
affb58ef9e
Apply suggestions from code review
...
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
5 years ago
42ffddc269
Fix more warnings
5 years ago
5263aaa026
Merge pull request #1503 from cvium/webapi_v2
...
Move StartupWizard to ASP.NET Web Api
5 years ago
2af5922af0
Fix review comments
5 years ago
27e3cf1558
Move appbuilder and service collection to Jellyfin.Server
5 years ago
3f651de24c
Add authentication and remove versioning
5 years ago
b477b3874e
Fix some warnings
5 years ago
b14d6d0417
Fix GetPathValue function
5 years ago
6b6fede2e0
Address review comments
5 years ago
82f8345aa5
Log to debug all HTTP 500 response urls
5 years ago
1176749f14
Merge pull request #1863 from joshuaboniface/fix-baseurl-issues
...
Fix inconsistent BaseUrl behavior
6 years ago
b96079fee6
Make NormalizeUrlPath static
6 years ago
03450f383f
Fix template for logging
6 years ago
8109c7eb30
Always log at least error message when error happens during request processing
6 years ago
33b69a7099
Set response length and mime type correctly when reporting an error
6 years ago
2a79ae0a6e
Normalize baseUrl behaviour
...
Fully normalizes the baseUrl behaviour to better match how this sort of
feature works in other programs.
1. The baseUrl is always appended to paths, even the built-in `/emby`
and `/mediabrowser` paths.
2. The baseUrl is set statically at class instance creation, to ensure
it persists through changes until the next restart.
3. Configuration is normalized using a function when set, to ensure it's
in a standard `/mypath` format with leading `/`.
4. Cleans up the conditionals around default redirects. For sanity after
changing the URL, it will match *any* path that doesn't match the
current baseUrl and redirect it back to the main page (with baseUrl).
5. Adds a second method, NormalizeUrlPath, to avoid lots of `+ "/" +`
string manipulations which are unclean - we should always have a leading
slash.
6. Sets the default baseUrl to an empty string to avoid unexpected
behaviour, though this would be worked-around automatically.
7. Adds some debug logs whenever a URL is normalized, to help track down
issues with this code (if any arise).
6 years ago
fc99f1f563
Merge pull request #1785 from dkanada/compat
...
Add mediabrowser route back for now
6 years ago
b5b7db1f32
add an exception to logging
6 years ago
ab7e697f30
add mediabrowser route back for now
6 years ago
c9820d30ed
Fix multiple mistakes and warnings
6 years ago
74864832ca
Set log level to debug for HTTP range requests
...
This removes some spam when a DLNA renderer uses byte seeking.
6 years ago
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
6 years ago
97d6c2db6b
keep old base url for now
6 years ago
d521e5c36a
add base url to server configuration
6 years ago
c987203f5a
remove old routes from http server
6 years ago
9fff4b060e
Replace custom code with Asp.Net Core code
6 years ago
0e6417c9fa
Set log level to debug for HTTP range requests
6 years ago
ce1fa42f9d
Merge branch 'master' into tasks
6 years ago
2bc378a9c3
Merge pull request #1337 from jellyfin/release-10.3.z
...
Backmerge for 10.3.2 release
6 years ago
61d7bed181
Merge pull request #1304 from jellyfin/release-10.3.z
...
Backmerge 10.3.1
6 years ago
71479286e9
Fix #1234
6 years ago
28c2ac528d
Re-add content length, semi revert of changes in #1010 ( #1287 )
...
* Re-add content length, semi revert of changes in #1010
6 years ago
a8da122fb3
Merge pull request #1252 from jellyfin/release-10.3.z
...
Backmerge release 10.3.0
6 years ago
250e0c75df
Add MethodNotAllowedException with code 405
6 years ago
c3532b92f7
Merge pull request #1158 from Bond-009/httpclean
...
Reduce complexity http routes
6 years ago
a332092769
Reduce complexity http routes
6 years ago
b44a70ff36
Simplify/remove/clean code
...
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant
And ofc fix some warnings ;)
6 years ago
2696ac5eac
Lower the amount of running tasks
6 years ago
4cd8903abc
Fix default value for Expires header
6 years ago
e64aaebbac
Improvements around streams
...
* Use ArrayPool instead of allocating new buffers each time
* Remove NetworkStream copy
* Remove some dead code
6 years ago
e3b844b5aa
Add urlprefixes during init
6 years ago
3fa43a1e08
Don't set status code if response is closed
6 years ago
dfff68b2f4
Make SkipLogExtensions static
6 years ago
bba049c987
Make FileSystem readonly
6 years ago
446f9bf81f
Remove more Content-Length references
6 years ago
913e80fd55
Add ProcessWebSocketRequest to IHttpListener
6 years ago
9a4a01fb0e
Fix DI in FileWriter.TransmitFile
6 years ago
78742b8e4c
Switch to HeaderNames instead of hardcoded strings (and other header related fixes)
6 years ago
bc00617df7
Remove unused Brotli compressor
6 years ago
51648a2a21
Remove unused _listener
6 years ago
0250204f14
Expand todo
6 years ago
9020f68ce1
Use QueryHelpers.AddQueryString
6 years ago
e823c11b46
Add certificate to https and minor cleanup
6 years ago
fb1de5a921
Remove more cruft and add the beginnings of a socket middleware
6 years ago
c0b95dbc79
Fix query log for real
6 years ago
647adc51c8
Fix query log
6 years ago
27e7e792b3
Replace some usage of QueryParamCollection
6 years ago
333bd2107a
Remove HttpUtility
6 years ago
848cfc32cc
More cleanup
6 years ago
e342b7bc71
Extend the IHttpServer interface to avoid the typecasting
6 years ago
f1c93ae618
Remove SetContentLength and company
6 years ago
4e8de67aca
Remove SocketSharp from Jellyfin.Server and some other cleanup
6 years ago
a85488cd20
Fix websockets array index out of bounds and some cleanup
6 years ago
f3e7bc0573
Replace some todos with http extensions and prepare some socket work
6 years ago
852460b991
kestrel init
6 years ago
4db31acff9
Begin removing System.Net sources
6 years ago
0804bed66d
Log time in a standardized way
6 years ago
0f9006c81f
Use stopwatch for more accurate measurements and reduce log spam
...
DateTime.Now is suitible for small timespans
Replaced the needlessly complex and verbose logging for the httpserver
6 years ago
89d4ce309d
Merge pull request #848 from Bond-009/perf
...
Minor changes to reduce allocations
6 years ago
13f2783a8e
Merge pull request #887 from wtayl0r/replace-primitives-with-iconfiguration
...
Replace primitive injection with IConfiguration
6 years ago
18ae107ce4
Removed unnecessary configuration options and reduced primitive dependencies
6 years ago
c720504e39
Drop ETag and use Last-Modified header ( #890 )
...
Drop ETag and use Last-Modified since performance is much better
6 years ago
3f13851be5
Address comments
6 years ago
8d98885cda
Less string allocations
6 years ago
a709cbdc64
Fix more analyzer warnings
6 years ago
df5e87409a
Fix trim input
6 years ago
94789860b1
Trim quotes from If-None-Match
6 years ago
fd6d35e1d0
Remove unconditional caching, modified since header and use ETags
6 years ago
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
6 years ago
b35dcbb9f0
Remove MediaBrowser.Text since it violates licenses and is overall hacky
6 years ago
e63b18f17d
Reformat JustAMan review second pass changes.
6 years ago
d116efe1f7
Merge branch 'dev' into reformat
6 years ago
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
6 years ago
d0980f0da5
Update HttpListenerHost.cs
6 years ago
900dc851e6
Merge branch 'dev' into cleanup
6 years ago
49b61f238e
Merge branch 'dev' into reformat
...
# Conflicts:
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
# Emby.Server.Implementations/LiveTv/LiveTvManager.cs
# Emby.Server.Implementations/Security/MBLicenseFile.cs
# Emby.Server.Implementations/Security/PluginSecurityManager.cs
# Emby.Server.Implementations/Security/RegRecord.cs
# MediaBrowser.Api/PluginService.cs
# MediaBrowser.Api/System/SystemService.cs
# MediaBrowser.Common/Security/IRequiresRegistration.cs
# MediaBrowser.Common/Security/ISecurityManager.cs
# MediaBrowser.Common/Security/PaymentRequiredException.cs
# MediaBrowser.Model/Entities/MBRegistrationRecord.cs
# MediaBrowser.Model/Entities/PluginSecurityInfo.cs
# deployment/win-generic/build-jellyfin.ps1
6 years ago
eca3c099d9
removed a bunch of validation, security, registration, premiere, whatever bs
6 years ago
e867446437
ReSharper format: conform inline 'out' parameters.
6 years ago
65bd052f3e
ReSharper conform to 'var' settings
6 years ago
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
6 years ago
c5c7a3c4ee
Visual Studio Reformat: Emby.Server.Implementations Part De-H
6 years ago
e2751d42e8
Merge branch 'dev' into code-cleanup
6 years ago
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
6 years ago
bd169e4fd4
remove trailing whitespace
6 years ago
07a8e49c4b
Cleanup some small things
6 years ago
a997bb609f
Remove unnecessary using statements
6 years ago
391b48614d
Remove FireEventIfNotNull
...
It's a pretty useless "helper" class
6 years ago
ea4c914123
Fix exception logging
6 years ago
0c1b9d3bff
Rebase
6 years ago
b7ebb67cbb
Remove the need for NullLogger
6 years ago
0f8b3c6347
Use Microsoft.Extensions.Logging abstraction
6 years ago
ab8df3741d
Fixes possible NullReferenceException
6 years ago
Vasily
Mark Monteiro
Bond-009
dkanada
Vasily
Claus Vium
Joshua Boniface
Erik Larsson
Claus Vium
Bill Thornton
William Taylor
Erwin de Haan
hawken