c7d50d640e
Replace == null with is null
2 years ago
556cc8062d
Investigate some TODO comments
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
7d48f97db9
Fix regression in DlnaHttpClient
...
```
[18:53:50] [ERR] [25] Emby.Dlna.Main.DlnaEntryPoint: Error updating device info for 192.168.1.21 - Sonos Connect:Amp Berging
System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Http.StringContent'.
at System.Net.Http.HttpContent.CheckDisposed()
at System.Net.Http.HttpContent.CopyToAsync(Stream stream, TransportContext context, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendRequestContentAsync(HttpRequestMessage request, HttpContentWriteStream stream, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at Emby.Dlna.PlayTo.DlnaHttpClient.SendRequestAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/DlnaHttpClient.cs:line 47
at Emby.Dlna.PlayTo.Device.GetTransportInfo(TransportCommands avCommands, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 705
at Emby.Dlna.PlayTo.Device.TimerCallback(Object sender) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 521
```
2 years ago
33611614ed
Merge pull request #7433 from Bond-009/ssdphttpclient
2 years ago
38102499cb
Merge pull request #7947 from nyanmisaka/video-range-condition
...
(cherry picked from commit f1d56aa5ce
2 years ago
5b4e14940e
Fix format string
2 years ago
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2 years ago
cafeedcadf
Rework SsdpHttpClient
2 years ago
03f1eff21a
Implement TransportState according to spec ( #7426 )
2 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2 years ago
1c14c86b20
Fix some warnings
2 years ago
e7be01d7a5
Flush to disk async where possible
2 years ago
05836c8cd3
Fix warning SA1414 and CA1849
2 years ago
ea8f40e84a
More cleanup
2 years ago
b50c3852ef
Remove unused dependencies
3 years ago
9234e5bf80
Remove all instances of en-US culture
3 years ago
ec45808275
SsdpHttpClient: Ensure successful status code before reading response
3 years ago
45f478f63e
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
# MediaBrowser.Controller/Library/IUserManager.cs
# MediaBrowser.Controller/Security/IAuthenticationRepository.cs
# MediaBrowser.Controller/Session/ISessionManager.cs
3 years ago
501de7b6dc
Enable nullable in more files
3 years ago
be88efce3c
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
# Emby.Server.Implementations/Security/AuthenticationRepository.cs
# Emby.Server.Implementations/Session/SessionManager.cs
# Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
# MediaBrowser.Controller/Library/IUserManager.cs
# MediaBrowser.Controller/Net/ISessionContext.cs
3 years ago
75704effae
Merge pull request #5659 from ssenart/feature/5644-dlna_next_track
3 years ago
2f9034c94b
Update Emby.Dlna/PlayTo/Device.cs
3 years ago
e134a3677c
Apply suggestions from code review
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
3 years ago
a225f34796
Merge branch 'master' into authenticationdb-efcore
...
# Conflicts:
# Jellyfin.Api/Helpers/RequestHelpers.cs
3 years ago
06caee28b7
Enable nullable reference types for Emby.Dlna
3 years ago
f4a59c92e6
Merge pull request #5826 from BaronGreenback/ssdpFix
...
PlayTo Fix: Use external ip not internal interface
3 years ago
184e05aeb6
Merge pull request #5681 from BaronGreenback/ContentFeatureOptimization
...
Various DLNA Optimizations
3 years ago
bc1cc2d04a
Remove unused using directives
3 years ago
3199d1c902
Fix: PlayTo using external ip not internal
3 years ago
8607b52541
Make device/session code async
3 years ago
4f387dca6e
Merge pull request #5598 from cvium/fix_hls_default_values
3 years ago
d9a50cb510
Various DLNA Optimizations
3 years ago
3164781ce0
[5644] [DLNA] [Music] Next track command from any DLNA device does not do anything.
3 years ago
ec113816aa
[5644] [DLNA] [Music] Next track command from any DLNA device does not do anything.
3 years ago
a7c82b2681
[5644] [DLNA] [Music] Next track command from any DLNA device does not do anything.
3 years ago
74e14b4ca5
fix isdirectstream default
3 years ago
7dedeb6c79
change HLS endpoint defaults to false
3 years ago
4bd345fbab
DLNA Exception catching
3 years ago
e8413ed8c0
Use XDocument.LoadAsync instead of XDocument.Parse
3 years ago
d819a1d928
Remove Content-Length header from DLNA HEAD request ( #5335 )
3 years ago
40b9e7592f
Fix build
3 years ago
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
3 years ago
13d65318eb
Merge pull request #5223 from Bond-009/minor10
...
Minor improvements
3 years ago
e9f22303a4
Properly forward cancellationTokens
3 years ago
65bab55ca0
Minor improvements
3 years ago
e81b7c8f4f
reverted
3 years ago
828a9b7c75
rollback
3 years ago
13012bfa27
Fix bug in GetItemId
3 years ago
16d092a8a7
Fixed encoding issue
3 years ago
Bond_009
Cody Robibero
Claus Vium
cvium
Patrick Barron
BaronGreenback
Stéphane Senart
dkanada