Bond_009
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
4 years ago
David
043d045448
Put json serializer options in private field
4 years ago
David
2a574914ea
Use streams instead of strings
4 years ago
David
196388d607
Remove custom Json serializer from Emby.Server.Implementations
4 years ago
Bond_009
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
Ryan Petris
4db5700e18
Don't take a lock if there's no intention to manipulate the list of open streams. Instead, use a ConcurrentDictionary so that, in those situations, thread-safe access to the dictionary is ensured.
4 years ago
Bond_009
01e781035f
Fix warnings
4 years ago
Bond_009
7324b44c43
Fix warnings
4 years ago
telans
247f9c61e6
fix SA1513/SA1516
4 years ago
telans
3d9049ef08
fix SA1508
4 years ago
telans
acd4389653
fix SA1005
4 years ago
telans
726e116d5b
fix SA1510
4 years ago
Patrick Barron
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
crobibero
44957c5a9a
Use typed logger where possible
5 years ago
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
5 years ago
Bond_009
7439e095e2
Merge branch 'master' into nullable3
5 years ago
Patrick Barron
c464f700db
Remove redundant qualifiers
5 years ago
Patrick Barron
9ad839c776
Initial migration code
5 years ago
Bond_009
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
5 years ago
Mark Monteiro
573da63d41
Register and construct IMediaSourceManager correctly
5 years ago
Bond_009
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
5 years ago
dkanada
d217f1614e
Merge pull request #2096 from Bond-009/embytv
...
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
Bond_009
bb236b9591
Merge branch 'master' into warn12
5 years ago
Bond_009
e714b9930e
Merge branch 'master' into embytv
5 years ago
Bond_009
a253fa616d
Fix build and address comments
5 years ago
dkanada
aca31457c0
merge branch master into media-attachments
5 years ago
Bond_009
2ef4ffd698
More warnings (removed)
5 years ago
Bond_009
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
Bond_009
42ffddc269
Fix more warnings
5 years ago
Andrew Mahone
d73f46dcda
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Andrew Mahone
8b2d7062c4
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Andrew Mahone
193a1fa474
Update Emby.Server.Implementations/Library/MediaSourceManager.cs
...
docs
Co-Authored-By: Bond-009 <bond.009@outlook.com>
5 years ago
Andrew Mahone
7110069b39
Return list result directly for MediaAttachments.
5 years ago
Andrew Mahone
1600d5b53f
Merge remote-tracking branch 'origin/master' into media-attachments-clean
5 years ago
Bond_009
d9a03c9bb1
Fix more warnings
5 years ago
Andrew Mahone
1513c76a3e
Support MediaAttachment retrieval in MediaSourceManager.
5 years ago
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
Claus Vium
0ef2b46106
Remove custom Threading
6 years ago
Bond-009
2a1f6361a5
Merge branch 'master' into locale
6 years ago
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
6 years ago
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
6 years ago
Bond_009
51edd5d067
Reworked LocalizationManager to load data async
6 years ago
Bond_009
722120af74
Remove conditions that are always true/false
6 years ago
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
6 years ago
Erwin de Haan
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
6 years ago
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
6 years ago
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
6 years ago
Erwin de Haan
58b582bdcb
Visual Studio Reformat: Emby.Server.Implementations Part I-Lib
6 years ago
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
6 years ago
Bond_009
59d8d9a82c
Fix nullrefexception in SubtitleEncoder
6 years ago