a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
bd9a940fed
Declare VirtualInterfaceNames as string array for consistency
2 years ago
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2 years ago
59a86568d9
Cleanup and fixes
2 years ago
cea8e8bbf6
Fix logging output
2 years ago
b5c1d6129e
Remove more unused network configuration parameters
2 years ago
f6e41269d9
Enforce interface bindings on SSDP, add Loopback to LAN if no LAN defined
2 years ago
358642c2d9
Fix build, fix loopback binding, exclude unsupported IPs from bind
2 years ago
2d3a16ad0f
Simplify code
2 years ago
8075cb4e99
Cleanup and sort NetworkConfiguration
2 years ago
2281b8c997
Move away from using Collection, simplify code, add proper ordering
2 years ago
64ffd5fd95
Move subnet parser to NetworkExtensions
2 years ago
997aa3f1e7
Fix build
2 years ago
066db8ac7f
Migrate NetworkManager and Tests to native .NET IP objects
2 years ago
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 ( #7726 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 years ago
94a69c8a8b
Merge pull request #7549 from cvium/fix_isinlocalnetwork
...
(cherry picked from commit bdb85aeecf
3 years ago
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
...
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers ) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases )
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406 )
---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
3cb49d6df0
Fix option to disable server discovery
3 years ago
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
3 years ago
cbfa355e31
Update StyleCop
3 years ago
0485ff1899
Create a store key constant for network
3 years ago
1c47211a9e
Merge remote-tracking branch 'BaronGreenback/TVFix' into TVFix
3 years ago
f03e77a4d5
Merge branch 'master' into TVFix
3 years ago
5eda5eb636
Merge pull request #6486 from fredriklindberg/support-forwarded-headers-for-api-url
3 years ago
13fbfe6091
Target net6.0
3 years ago
90174f68e2
Dynamically populate LocalAddress based on HTTP request
...
Support populating the LocalAddress field in the system info
endpoint based on the x-forwarded-host and x-forwarded-proto header.
The x-forwarded-host header must contain both the host and port for
the url to be properly constructed.
Behind network configuration option that is disabled by default.
3 years ago
4f51a22081
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
3 years ago
ffe5ae8056
Merge branch 'master' into TVFix
3 years ago
c07e83fdf8
Invert code and style analysis configuration ( #6334 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
3 years ago
7936ea59eb
Changed selection method
4 years ago
eeb5d4bd1e
Merge pull request #5842 from BaronGreenback/optimization
...
Code Clean up: Group Methods
4 years ago
5741fa7dfa
Fix url for LiveTV
4 years ago
bc1cc2d04a
Remove unused using directives
4 years ago
bb6fddde9a
Group Methods
4 years ago
0b774eac12
Enables the ability to bind to loopback address. ( #5773 )
4 years ago
19e7ebb279
Merge pull request #5416 from BaronGreenback/SubnetOverlappFix
4 years ago
5d16d1f66d
Merge branch 'master' into RemoteAccessFix
4 years ago
4c7680e186
Merge remote-tracking branch 'upstream/master' into SubnetOverlappFix
4 years ago
6087831aa6
Fixed selection of correct interface ip
4 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
4 years ago
4cf88f67ba
Update NetworkManager.cs
4 years ago
3fa84500cf
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
f66cb9777d
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
3fdf0de6e3
Fix remote access
4 years ago
2fe26ef136
removed parameter preset
4 years ago
9ed7f429c0
FxCop -> Net Analyzers (part 1)
4 years ago
a031f7e410
Fix for multiple ip's in the same subnet per interface.
4 years ago
5942948714
Kestrel workaround
4 years ago
dedc94ec91
correction of ip6 loopback
4 years ago
cc19d281e7
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
d99d95422e
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
4 years ago
039a4fb22d
renamed method
4 years ago
b5c6e5fb97
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
f67137004c
Update Jellyfin.Networking/Manager/NetworkManager.cs
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
ff7cae8a13
renamed method
4 years ago
5756c6dbad
Merge branch 'master' into bindfix
4 years ago
cb09096a59
optimized
4 years ago
b03bd7a299
Fix testing
4 years ago
605bd80251
Fix for ignoreVirtualInterfaces
4 years ago
14bd4a110f
Merge pull request #4978 from BaronGreenback/MultipeProxies
4 years ago
9db8a4d88d
reverted
4 years ago
82d365045a
Removed systemIp6 functionality.
4 years ago
6a7623da02
Simplified Code
4 years ago
08e83cfa54
Remove additional debug logging.
4 years ago
35a30c9d09
Impliments KnownNetworks and KnownProxies
4 years ago
a664aac881
optimization
4 years ago
90d72d6628
Update NetworkManager.cs
...
Changed split character
4 years ago
ccc1b8bf92
Merge pull request #4729 from BaronGreenback/19.0RC---Fix-networkInterfaceFix
4 years ago
d96c8d7efd
Remove todo
4 years ago
41218c5613
fix ssl certificate cannot be saved
4 years ago
acc45b7307
Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
4 years ago
e34adc12d9
reverted change.
4 years ago
d69f2d7d7f
DNLA over HTTP only
4 years ago
abacae4520
Update NetworkManager.cs
...
Changed logging type.
4 years ago
e4fd61411f
Minor improvements
4 years ago
50e375020a
[Fix] NetworkManager binding to [::] ( #4549 )
...
* Autodiscovery enable/disable patch
* Fixed [::] issue on bind. Altered test.
* Update UdpServerEntryPoint.cs
* Update Jellyfin.Networking.Tests.csproj
* Update Jellyfin.Networking.Tests.csproj
* Update INetworkManager.cs
4 years ago
33f6b13d4f
Moved INetworkManager
4 years ago
124bd4c2c0
Networking: 1 - Network Manager ( #4124 )
...
* NetworkManager
* Config file with additional options.
* Update Jellyfin.Networking/Manager/INetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/INetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Model/Configuration/ServerConfiguration.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Model/Configuration/ServerConfiguration.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Model/Configuration/ServerConfiguration.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Split function.
* Update Jellyfin.Networking/Manager/INetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* fixed iterations
* Update Jellyfin.Networking.csproj
* Update NetworkManager.cs
* Updated to NetCollection 1.03.
* Update ServerConfiguration.cs
* Update StartupController.cs
* Update INetworkManager.cs
Removed public
* Update INetworkManager.cs
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Updated comment
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/INetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Remove mono code.
Removed forced chromecast option
* Inverted if
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Moved config into a separate container
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Changed sortedList to dictionary.
* Update INetworkManager.cs
Changed UpdateSettings param type
* Update NetworkManager.cs
* Update NetworkManager.cs
* Update NetworkManager.cs
* Update NetworkConfiguration.cs
* Update INetworkManager.cs
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update MediaBrowser.Model/Configuration/ServerConfiguration.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Model/Configuration/ServerConfiguration.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Updated changes github didn't update.
* Fixed compilation.
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Removed read locking.
* Update NetworkManager.cs
Changed configuration event to NamedConfigurationUpdated
* updated comment
* removed whitespace
* Updated NetCollection to 1.0.6
Updated DXCopAnalyser to 3.3.1
* removed NetCollection
* Update NetworkManager.cs
* Update NetworkExtensions.cs
* Update NetworkExtensions.cs
Removed function.
* Update NetworkExtensions.cs
* Update NetworkManager.cs
Changed ToString() to AsString() as native collection formats incorrectly.
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update NetworkExtensions.cs
* Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
* Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
* Update Jellyfin.Networking/Configuration/NetworkConfiguration.cs
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
* updated
* Replaced NetCollection with Collection<IPObject>
* Update MediaBrowser.Common/Net/NetworkExtensions.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Model/Configuration/PathSubstitution.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/NetworkExtensions.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPHost.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* Update MediaBrowser.Common/Net/IPObject.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
* updated comments.
* Updated comments / changes as suggested by @crobibero.
* Split function as suggested
* Fixed null ref.
* Updated comment.
* Updated cs to .net5
* Fixed issue with PublishedServerUrl
* Fixes
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Restored locking
* optimisation
* Added comment
* updates.
* updated.
* updates
* updated.
* Update IPHost.cs
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
* Update NetworkManager.cs
* Removed whitespace.
* Added debug logging
* Added debug.
* Update Jellyfin.Networking/Manager/NetworkManager.cs
Co-authored-by: Bond-009 <bond.009@outlook.com>
* Replaced GetAddressBytes
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
Co-authored-by: h1dden-da3m0n <33120068+h1dden-da3m0n@users.noreply.github.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
4 years ago
Bond_009
Shadowghost
luz paz
dependabot[bot]
Cody Robibero
cvium
Claus Vium
Fredrik Lindberg
Rich Lander
BaronGreenback
Joshua M. Boniface
nyanmisaka