d280dc6554
Reduce log spam
...
Fixes #7801
1 year ago
52194f56b5
Replace != null with is not null
1 year ago
c7d50d640e
Replace == null with is null
1 year ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
5732e6188c
Fix some warnings
2 years ago
ea8f40e84a
More cleanup
2 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
4ba9b6c305
Fix warnings in ScheduledTasks
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
6f8ccab788
Move non-jellyfin extensions to separate project
3 years ago
0bc0601442
Fix some warnings
3 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
3 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
3 years ago
f2c10471bf
Code Clean up: Use Pattern Matching ( #5838 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
3 years ago
bc1cc2d04a
Remove unused using directives
3 years ago
42bcf171d9
Use sync Serialize when writing scheduled tasks to disk
3 years ago
a8ed753f6c
FxCop -> Net Analyzers (part 2)
3 years ago
54a3ab15a3
Merge pull request #5005 from jellyfin/bytes
...
JsonSerializer deserialize from bytes where possible
3 years ago
1752423e52
Open FileStream with FileMode.Create instead of FileMode.OpenOrCreate
...
> The OpenWrite method opens a file if one already exists for the file path,
or creates a new file if one does not exist. For an existing file,
it does not append the new text to the existing text. Instead,
it overwrites the existing characters with the new characters.
If you overwrite a longer string
(such as "This is a test of the OpenWrite method") with a shorter string
(such as "Second run"), the file will contain a mix of the strings
("Second runtest of the OpenWrite method").
Ref: https://docs.microsoft.com/en-us/dotnet/api/system.io.file.openwrite?view=net-5.0#remarks
3 years ago
1ea2b200c0
JsonSerializer deserialize from bytes where possible
...
This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
| Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 | - | - | 52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 | - | - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 | - | - | 31.27 KB |
```
3 years ago
3dec1fd6b2
Use UTF8 encoding and async correctly
3 years ago
21fd124bca
Code revie
3 years ago
043d045448
Put json serializer options in private field
3 years ago
e835dfb27d
Use sync string instead of file
3 years ago
2a574914ea
Use streams instead of strings
3 years ago
f38970cbd3
Remove xml docs
3 years ago
196388d607
Remove custom Json serializer from Emby.Server.Implementations
3 years ago
d4e568c8bf
Replace Task.WaitAll with Task.Wait
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
4 years ago
ab2147751f
Make MediaBrowser.MediaEncoding warnings free
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
9018f8d8be
Add full stop at end of comments (SA1629)
4 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
b477b3874e
Fix some warnings
5 years ago
6032f31aa6
Use CultureInvariant string conversion for Guids
5 years ago
d0f2b3a747
Merge branch 'master' into startuptasks
5 years ago
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
5 years ago
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
5 years ago
a05d803d4c
Fix crash when trying to deserialize a non-existing scheduled task
5 years ago
ffe79c8982
Check if file exists instead of catching exceptions
5 years ago
08b63a7c11
Remove unused function
...
RunStartupTasks never executes because "startuptasks.txt" is never
created
5 years ago
fd7f420af2
Remove remnants of system events
5 years ago
65bd052f3e
ReSharper conform to 'var' settings
5 years ago
0efc699e3d
Visual Studio Reformat: Emby.Server.Implementations Part S-S
5 years ago
e9519de07d
Fixed removed start tag of XMLComment.
5 years ago
Bond_009
Patrick Barron
Cody Robibero
BaronGreenback
cvium
dkanada
David
telans
Vasily
Erwin de Haan