gnattu
162ea38a95
Check MaxAudioChannels for directAudioStream candidates ( #12319 )
...
* Check MaxAudioChannels for directAudioStream candidates
The current stream builder logic does not check the channel limit when determining if the audio stream can be directly used, and this can cause some undesired effects:
- A high channel count surround sound stream might be picked even if a stereo one exists when the user requires stereo audio.
- The user's preferred audio codec might not be respected during the downmix because the requested codec is now forced to be the same as the original source.
Signed-off-by: gnattu <gnattuoc@me.com>
* Fix unit test
Signed-off-by: gnattu <gnattuoc@me.com>
* Set correct transcode reason and target channels for unit test
Signed-off-by: gnattu <gnattuoc@me.com>
* Match old stream selection behavior
Signed-off-by: gnattu <gnattuoc@me.com>
* Fix reason matching
Signed-off-by: gnattu <gnattuoc@me.com>
---------
Signed-off-by: gnattu <gnattuoc@me.com>
6 months ago
Cody Robibero
e731250342
Lowercase MediaStreamProtocol for backwards compatibility
11 months ago
Niels van Velzen
407cf5d0bf
Add MediaStreamProtocol enum ( #10153 )
...
* Add MediaStreamProtocol enum
* Add default handling for enum during deserialization
---------
Co-authored-by: Cody Robibero <cody@robibe.ro>
11 months ago
Dmitry Lyzo
e1ba9c0f42
test: drop default flag from second audio track
...
To test more general situation.
Add another HEVC test file with old logic.
11 months ago
Dmitry Lyzo
47b583456a
test: collect candidate audio streams if no audio index is specified
...
To be consistent with the logic of StreamBuilder.
11 months ago
Dmitry Lyzo
07b9c85f14
test: discard webm from test mkvs if there is an unsupported codec ( #10999 )
...
To comply 39088b5ad2
, ba877283a1
12 months ago
Dmitry Lyzo
ca280279da
test: add more audio tests
1 year ago
Dmitry Lyzo
8c29fa422a
test: fix tizen profile
1 year ago
Dmitry Lyzo
d92f2ac31c
test: fix remux tests
...
This partially reverts commit 2d8f7b46f1
1 year ago
Bond-009
3087881d93
Merge pull request #10056 from Bond-009/nullable2
1 year ago
Lehonti Ramos
bc959270b7
Removed nesting levels through block-scoped `using` statement ( #10025 )
...
Co-authored-by: John Doe <john@doe>
Co-authored-by: Lehonti Ramos <lehonti@ramos>
1 year ago
Bond_009
5677566a41
Enable nullable for more files
2 years ago
Stepan Goremykin
890fe183cf
Use default instead of zero for TranscodeReason
2 years ago
Stepan Goremykin
7d7e177265
Remove redundant casts
2 years ago
Dmitry Lyzo
28b98cacc8
Backport pull request #9051 from jellyfin/release-10.8.z
...
Fix transcode reasons
Original-merge: 1dea309ae4
Merged-by: Joshua M. Boniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2 years ago
Shadowghost
697efec86e
Cleanup and refactor streambuilder
2 years ago
Bond_009
52194f56b5
Replace != null with is not null
2 years ago
Bond_009
c7d50d640e
Replace == null with is null
2 years ago
Bond_009
556cc8062d
Investigate some TODO comments
2 years ago
Dmitry Lyzo
c7a9759a76
fix tests
2 years ago
Joshua M. Boniface
2d8f7b46f1
Merge pull request #7699 from Shadowghost/streambuilder-fix
...
(cherry picked from commit b46d61dfdf
)
Signed-off-by: crobibero <cody@robibe.ro>
3 years ago
Cody Robibero
688553b9a8
Merge pull request #7537 from dmitrylyzo/fix-streambuilder
...
(cherry picked from commit 5833c70725
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
3 years ago
Cody Robibero
1960b5bdce
Merge pull request #7523 from crobibero/null-stream
...
Allow media without streams to playback
(cherry picked from commit 577325b788
)
Signed-off-by: crobibero <cody@robibe.ro>
3 years ago
Bond-009
bb7068cb63
Move StreamBuilderTests to correct project ( #7461 )
3 years ago
Bond_009
39931fe3ad
Add regression test for ContainerProfile.ContainsContainer
4 years ago