556cc8062d
Investigate some TODO comments
2 years ago
c6bf6e00de
Remove unnecessary ToList usage
2 years ago
14027f962c
Merge pull request #6751 from Bond-009/tests12
...
Fix DLNA UpdateProfile test
2 years ago
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2 years ago
7d48f97db9
Fix regression in DlnaHttpClient
...
```
[18:53:50] [ERR] [25] Emby.Dlna.Main.DlnaEntryPoint: Error updating device info for 192.168.1.21 - Sonos Connect:Amp Berging
System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Http.StringContent'.
at System.Net.Http.HttpContent.CheckDisposed()
at System.Net.Http.HttpContent.CopyToAsync(Stream stream, TransportContext context, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendRequestContentAsync(HttpRequestMessage request, HttpContentWriteStream stream, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at Emby.Dlna.PlayTo.DlnaHttpClient.SendRequestAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/DlnaHttpClient.cs:line 47
at Emby.Dlna.PlayTo.Device.GetTransportInfo(TransportCommands avCommands, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 705
at Emby.Dlna.PlayTo.Device.TimerCallback(Object sender) in /home/loma/dev/jellyfin/Emby.Dlna/PlayTo/Device.cs:line 521
```
2 years ago
33611614ed
Merge pull request #7433 from Bond-009/ssdphttpclient
2 years ago
9ec2870b10
Fix various typos
...
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2 years ago
a99e87a00c
Merge pull request #7954 from cvium/fix_7953_dlna_url
...
(cherry picked from commit 2c0c3eb3ee
2 years ago
38102499cb
Merge pull request #7947 from nyanmisaka/video-range-condition
...
(cherry picked from commit f1d56aa5ce
2 years ago
5b4e14940e
Fix format string
2 years ago
0e1a41f7e9
Merge pull request #7868 from cvium/disable_dlna
...
(cherry picked from commit aa0f6cb5eb
2 years ago
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438
3 years ago
812841d01e
Bump StyleCop.Analyzers from 1.2.0-beta.406 to 1.2.0-beta.435 ( #7726 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 years ago
dc8fdb154a
get DLNA profile in XML request, correctly format UUID
3 years ago
dde984bd0e
Bump StyleCop.Analyzers from 1.2.0-beta.376 to 1.2.0-beta.406
...
Bumps [StyleCop.Analyzers](https://github.com/DotNetAnalyzers/StyleCopAnalyzers ) from 1.2.0-beta.376 to 1.2.0-beta.406.
- [Release notes](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases )
- [Commits](https://github.com/DotNetAnalyzers/StyleCopAnalyzers/compare/1.2.0-beta.376...1.2.0-beta.406 )
---
updated-dependencies:
- dependency-name: StyleCop.Analyzers
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
3 years ago
09e897d372
Clean up DLNA profile code
3 years ago
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
3 years ago
cafeedcadf
Rework SsdpHttpClient
3 years ago
03f1eff21a
Implement TransportState according to spec ( #7426 )
3 years ago
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
3 years ago
1c14c86b20
Fix some warnings
3 years ago
b6489e73ab
Merge pull request #7241 from Bond-009/async5
3 years ago
e7be01d7a5
Flush to disk async where possible
3 years ago
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
3 years ago
a60cb280a3
Properly populate QueryResult
3 years ago
05836c8cd3
Fix warning SA1414 and CA1849
3 years ago
77c615ba42
Error on SA1316
3 years ago
8952819494
remove unnecessary ToList in DlnaManager
3 years ago
ea8f40e84a
More cleanup
3 years ago
cbfa355e31
Update StyleCop
3 years ago
b880dc8a4a
Use our own Contains extension
3 years ago
32629cd7da
Use BaseItemKind where possible
3 years ago
0485ff1899
Create a store key constant for network
3 years ago
5b7e8a27fb
Fix creating DLNA profiles
3 years ago
93fd1c7075
Fix
3 years ago
b50c3852ef
Remove unused dependencies
3 years ago
a774d1fa10
- flush the XmlWriter before calling the StringBuilder ToString() method
3 years ago
4c88bf3fe3
Merge pull request #6808 from cvium/dlnope_never_again
3 years ago
efa76c0b63
Remove unused field
3 years ago
3f09fb8d70
length
3 years ago
1d19a5be61
Fix some warnings
...
down to 580
3 years ago
c3523e7cf7
Merge pull request #5905 from BaronGreenback/TVFix
...
Fix for Livetv and DLNA when bind interfaces specified.
3 years ago
a90735bc5a
Last small fixes
3 years ago
37a04d5dbf
Reduce indentation
3 years ago
e1f7f1405e
Use GetOrderBy in GetChildrenSorted
3 years ago
6985a4f255
Fix SortCriteria and refactor SetSorting
3 years ago
53c16c2342
Build an array instead of using LINQ
3 years ago
c1c77c8762
comments
3 years ago
2b02b53fc0
Merge branch 'master' into dlnope_never_again
3 years ago
996500b2f8
review stuff
3 years ago
Bond_009
ignacio laborde
Claus Vium
luz paz
Cody Robibero
Joshua M. Boniface
dependabot[bot]
InvoxiPlayGames
cvium
Marius Luca