f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2 years ago
adad13b865
Remove some dead code
2 years ago
1c14c86b20
Fix some warnings
2 years ago
2dcb2f8a9f
Ban the usage of Task.Result
...
If the calling function can't be made async easily you can still use
.GetAwaiter().GetResult(), which is way easier to find in the future
2 years ago
a60cb280a3
Properly populate QueryResult
2 years ago
7bfc6b5679
Remove more warnings
2 years ago
b880dc8a4a
Use our own Contains extension
2 years ago
32629cd7da
Use BaseItemKind where possible
2 years ago
5726535a26
Fix some warnings
...
609 left
3 years ago
637e86478f
Fix some warnings
3 years ago
cba07b1ca6
Remove more and more warnings
3 years ago
0bc0601442
Fix some warnings
3 years ago
7e8428e588
Enable nullable reference types for Emby.Server.Implementations
3 years ago
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
3 years ago
a9b497720d
Use JsonSerializer.SerializeToUtf8Bytes when doing a round trip
...
This test uses a very small object (CountryInfo), using a bigger object
would increase the difference in allocated memory.
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
[Host] : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method | Mean | Error | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------- |-----------:|---------:|---------:|-------:|------:|------:|----------:|
| RoundTripBytes | 932.0 ns | 5.09 ns | 4.25 ns | 0.1173 | - | - | 368 B |
| RoundTripString | 1,114.8 ns | 22.19 ns | 23.74 ns | 0.1469 | - | - | 464 B |
```
3 years ago
8517b28eba
Make BaseItemDto Guids nullable
3 years ago
bc7359f87d
Use string.Split(char) where possible instead of string.Split(char[])
4 years ago
73f9a6d7d0
Convert array property to IReadOnlyList
4 years ago
49569ca0a0
Use nameof where possible
4 years ago
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
4 years ago
9fa4fff15d
Merge branch 'master' into event-rewrite-1
...
# Conflicts:
# Emby.Dlna/Emby.Dlna.csproj
# Emby.Dlna/Eventing/DlnaEventManager.cs
# Emby.Dlna/Service/BaseService.cs
# Emby.Server.Implementations/ScheduledTasks/ScheduledTaskWorker.cs
# MediaBrowser.Controller/Subtitles/SubtitleDownloadEventArgs.cs
4 years ago
119f64f5e7
Make some methods async
4 years ago
2b400c99ef
Fix warnings
4 years ago
ca1f15af19
Move GenericEventArgs to Jellyfin.Data.Events
4 years ago
7adac7561a
Use System.Text.Json in LiveTvManager
4 years ago
247f9c61e6
fix SA1513/SA1516
4 years ago
3d9049ef08
fix SA1508
4 years ago
acd4389653
fix SA1005
4 years ago
42b4f0aa2e
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
4 years ago
44957c5a9a
Use typed logger where possible
4 years ago
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
4 years ago
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
4 years ago
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
4 years ago
7439e095e2
Merge branch 'master' into nullable3
4 years ago
eef7cfd912
Make SonarCloud less angry
4 years ago
10e381f66f
Fix some 'bugs' flagged by sonarcloud
4 years ago
c464f700db
Remove redundant qualifiers
4 years ago
9ad839c776
Initial migration code
4 years ago
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
4 years ago
49fe5e0a21
Fix some warnings
4 years ago
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
4 years ago
cb2d99e831
Construct LiveTvDtoService and LiveTvManager correctly
4 years ago
3d5b4f869c
Register ILiveTvManager and IPlaylistManager correctly
4 years ago
3ab50f5a3f
Address comments
4 years ago
7060934792
Fix some warnings in Emby.Server.Implementations
4 years ago
e714b9930e
Merge branch 'master' into embytv
4 years ago
a4ca259a64
Add improved error error for #2141
4 years ago
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
5 years ago
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
5 years ago
Bond_009
Cody Robibero
cvium
BaronGreenback
Matt Montgomery
Patrick Barron
telans
Vasily
Mark Monteiro