You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Attila Szakacs c693da94ce Fix parallel use of not thread-safe SubtitleFormat instance ... `SubtitleFormat`'s `LoadSubtitle()` function is not thread-safe. A `SubtitleEditParser` instance's `Parse()` function can be called from multiple threads at the same time. `SubtitleFormat`s are cached in the constructor of each `SubtitleEditParser`, and the same instances are used for each possibly parallel `Parse()` function call, which causes subtitle parse problems. This patch modifies the code, so we only cache the extension -> `SubtitleFormat` type/class mapping and create a new `SubtitleFormat` instance in each `Parse()` call, so no `SubtitleFormat` instance is accessed from multiple threads. Fixes #12113 Kudos for everyone investigating the issue there, most notably @RenV123 for PoC-ing the solution. Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>		1 month ago
..
AssWriter.cs	Use RegexGenerator where possible	2 years ago
ISubtitleParser.cs	…
ISubtitleWriter.cs	…
JsonWriter.cs	…
SrtWriter.cs	Use RegexGenerator where possible	2 years ago
SsaWriter.cs	Use RegexGenerator where possible	2 years ago
SubtitleEditParser.cs	Fix parallel use of not thread-safe SubtitleFormat instance	1 month ago
SubtitleEncoder.cs	Solve CodeQL issue	5 months ago
SubtitleFormatExtensions.cs	Add subtitle parser errors to log if available (#12479)	6 months ago
TtmlWriter.cs	Use RegexGenerator where possible	2 years ago
VttWriter.cs	Use RegexGenerator where possible	2 years ago