From 3dc7b8e04e5fb0c00697165960beec5f24d0c4f8 Mon Sep 17 00:00:00 2001
From: sct <ryan@sct.dev>
Date: Mon, 31 Mar 2025 16:06:05 +0900
Subject: [PATCH] fix: dont show play on plex buttons when plex is disabled

---
 server/lib/availabilitySync.ts        |  2 +-
 server/lib/watchlistsync.ts           | 12 ++++++++++++
 src/components/IssueDetails/index.tsx |  6 ++++--
 src/components/MovieDetails/index.tsx |  2 ++
 src/components/TvDetails/index.tsx    |  3 ++-
 5 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/server/lib/availabilitySync.ts b/server/lib/availabilitySync.ts
index 38f3fa38..f5bb3aff 100644
--- a/server/lib/availabilitySync.ts
+++ b/server/lib/availabilitySync.ts
@@ -45,7 +45,7 @@ class AvailabilitySync {
       if (admin?.plexToken) {
         this.plexClient = new PlexAPI({ plexToken: admin.plexToken });
       } else {
-        logger.error('An admin is not configured.');
+        logger.warn('Plex is not configured. Skipping availability sync.');
       }
 
       for await (const media of this.loadAvailableMediaPaginated(pageSize)) {
diff --git a/server/lib/watchlistsync.ts b/server/lib/watchlistsync.ts
index 0fd90f64..9fdbcdcd 100644
--- a/server/lib/watchlistsync.ts
+++ b/server/lib/watchlistsync.ts
@@ -17,6 +17,18 @@ class WatchlistSync {
   public async syncWatchlist() {
     const userRepository = getRepository(User);
 
+    const admin = await userRepository.findOne({
+      select: { id: true, plexToken: true },
+      where: { id: 1 },
+    });
+
+    if (!admin?.plexToken) {
+      logger.warn('Skipping watchlist sync for admin without plex token', {
+        label: 'Plex Watchlist Sync',
+      });
+      return;
+    }
+
     // Get users who actually have plex tokens
     const users = await userRepository
       .createQueryBuilder('user')
diff --git a/src/components/IssueDetails/index.tsx b/src/components/IssueDetails/index.tsx
index 171f90a8..da5e58cb 100644
--- a/src/components/IssueDetails/index.tsx
+++ b/src/components/IssueDetails/index.tsx
@@ -8,6 +8,7 @@ import IssueComment from '@app/components/IssueDetails/IssueComment';
 import IssueDescription from '@app/components/IssueDetails/IssueDescription';
 import { issueOptions } from '@app/components/IssueModal/constants';
 import useDeepLinks from '@app/hooks/useDeepLinks';
+import useSettings from '@app/hooks/useSettings';
 import { Permission, useUser } from '@app/hooks/useUser';
 import globalMessages from '@app/i18n/globalMessages';
 import Error from '@app/pages/_error';
@@ -76,6 +77,7 @@ const isMovie = (movie: MovieDetails | TvDetails): movie is MovieDetails => {
 
 const IssueDetails = () => {
   const { addToast } = useToasts();
+  const { currentSettings } = useSettings();
   const router = useRouter();
   const intl = useIntl();
   const [showDeleteModal, setShowDeleteModal] = useState(false);
@@ -361,7 +363,7 @@ const IssueDetails = () => {
               </div>
             </div>
             <div className="mt-4 mb-6 flex flex-col space-y-2">
-              {issueData?.media.plexUrl && (
+              {currentSettings.plexLoginEnabled && issueData?.media.plexUrl && (
                 <Button
                   as="a"
                   href={plexUrl}
@@ -599,7 +601,7 @@ const IssueDetails = () => {
             </div>
           </div>
           <div className="mt-4 mb-6 flex flex-col space-y-2">
-            {issueData?.media.plexUrl && (
+            {currentSettings.plexLoginEnabled && issueData?.media.plexUrl && (
               <Button
                 as="a"
                 href={plexUrl}
diff --git a/src/components/MovieDetails/index.tsx b/src/components/MovieDetails/index.tsx
index 11b2a775..1c8d97c7 100644
--- a/src/components/MovieDetails/index.tsx
+++ b/src/components/MovieDetails/index.tsx
@@ -154,6 +154,7 @@ const MovieDetails = ({ movie }: MovieDetailsProps) => {
   const mediaLinks: PlayButtonLink[] = [];
 
   if (
+    settings.currentSettings.plexLoginEnabled &&
     plexUrl &&
     hasPermission([Permission.REQUEST, Permission.REQUEST_MOVIE], {
       type: 'or',
@@ -167,6 +168,7 @@ const MovieDetails = ({ movie }: MovieDetailsProps) => {
   }
 
   if (
+    settings.currentSettings.plexLoginEnabled &&
     settings.currentSettings.movie4kEnabled &&
     plexUrl4k &&
     hasPermission([Permission.REQUEST_4K, Permission.REQUEST_4K_MOVIE], {
diff --git a/src/components/TvDetails/index.tsx b/src/components/TvDetails/index.tsx
index 1b0b3c66..83d83a52 100644
--- a/src/components/TvDetails/index.tsx
+++ b/src/components/TvDetails/index.tsx
@@ -149,7 +149,7 @@ const TvDetails = ({ tv }: TvDetailsProps) => {
 
   const mediaLinks: PlayButtonLink[] = [];
 
-  if (plexUrl) {
+  if (settings.currentSettings.plexLoginEnabled && plexUrl) {
     mediaLinks.push({
       text: intl.formatMessage(messages.playonplex),
       url: plexUrl,
@@ -158,6 +158,7 @@ const TvDetails = ({ tv }: TvDetailsProps) => {
   }
 
   if (
+    settings.currentSettings.plexLoginEnabled &&
     settings.currentSettings.series4kEnabled &&
     plexUrl4k &&
     hasPermission([Permission.REQUEST_4K, Permission.REQUEST_4K_TV], {