From 51b05cd8fbb5d332807d8c00b2ffb7b10c3d0179 Mon Sep 17 00:00:00 2001 From: Danshil Kokil Mungur Date: Fri, 27 Jan 2023 04:48:40 +0400 Subject: [PATCH] fix(build): update usage of publish snap action (#3272) * fix(build): use env variable to login with snapcraft 7 * refactor(build): replace deprecated set-output command in GHA * fix(build): use correct environment variable for output * style(build): run prettier --- .github/workflows/ci.yml | 4 ++-- .github/workflows/preview.yml | 2 +- .github/workflows/release.yml | 11 ++++++----- .github/workflows/snap.yaml | 11 ++++++----- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 05db03e1..8c670f6b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,9 +94,9 @@ jobs: run: | failures=(neutral, skipped, timed_out, action_required) if [[ ${array[@]} =~ $WORKFLOW_CONCLUSION ]]; then - echo ::set-output name=status::failure + echo "status=failure" >> $GITHUB_OUTPUT else - echo ::set-output name=status::$WORKFLOW_CONCLUSION + echo "status=$WORKFLOW_CONCLUSION" >> $GITHUB_OUTPUT fi - name: Post Status to Discord uses: sarisia/actions-status-discord@v1 diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 6e0d8f3d..e1e93de0 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -14,7 +14,7 @@ jobs: uses: actions/checkout@v3 - name: Get the version id: get_version - run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/} + run: echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT - name: Set up QEMU uses: docker/setup-qemu-action@v2 - name: Set up Docker Buildx diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 839b2245..22c81513 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -67,9 +67,9 @@ jobs: run: | git fetch --prune --tags if [[ $GITHUB_REF == refs/tags/* || $GITHUB_REF == refs/heads/master ]]; then - echo ::set-output name=RELEASE::stable + echo "RELEASE=stable" >> $GITHUB_OUTPUT else - echo ::set-output name=RELEASE::edge + echo "RELEASE=edge" >> $GITHUB_OUTPUT fi - name: Set Up QEMU uses: docker/setup-qemu-action@v2 @@ -91,8 +91,9 @@ jobs: snap: ${{ steps.build.outputs.snap }} - name: Publish Snap Package uses: snapcore/action-publish@v1 + env: + SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAP_LOGIN }} with: - store_login: ${{ secrets.SNAP_LOGIN }} snap: ${{ steps.build.outputs.snap }} release: ${{ steps.prepare.outputs.RELEASE }} @@ -109,9 +110,9 @@ jobs: run: | failures=(neutral, skipped, timed_out, action_required) if [[ ${array[@]} =~ $WORKFLOW_CONCLUSION ]]; then - echo ::set-output name=status::failure + echo "status=failure" >> $GITHUB_OUTPUT else - echo ::set-output name=status::$WORKFLOW_CONCLUSION + echo "status=$WORKFLOW_CONCLUSION" >> $GITHUB_OUTPUT fi - name: Post Status to Discord uses: sarisia/actions-status-discord@v1 diff --git a/.github/workflows/snap.yaml b/.github/workflows/snap.yaml index bf00e04d..880c1d9e 100644 --- a/.github/workflows/snap.yaml +++ b/.github/workflows/snap.yaml @@ -35,9 +35,9 @@ jobs: run: | git fetch --prune --unshallow --tags if [[ $GITHUB_REF == refs/tags/* || $GITHUB_REF == refs/heads/master ]]; then - echo ::set-output name=RELEASE::stable + echo "RELEASE=stable" >> $GITHUB_OUTPUT else - echo ::set-output name=RELEASE::edge + echo "RELEASE=edge" >> $GITHUB_OUTPUT fi - name: Set Up QEMU uses: docker/setup-qemu-action@v2 @@ -57,8 +57,9 @@ jobs: snap: ${{ steps.build.outputs.snap }} - name: Publish Snap Package uses: snapcore/action-publish@v1 + env: + SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.SNAP_LOGIN }} with: - store_login: ${{ secrets.SNAP_LOGIN }} snap: ${{ steps.build.outputs.snap }} release: ${{ steps.prepare.outputs.RELEASE }} @@ -75,9 +76,9 @@ jobs: run: | failures=(neutral, skipped, timed_out, action_required) if [[ ${array[@]} =~ $WORKFLOW_CONCLUSION ]]; then - echo ::set-output name=status::failure + echo "status=failure" >> $GITHUB_OUTPUT else - echo ::set-output name=status::$WORKFLOW_CONCLUSION + echo "status=$WORKFLOW_CONCLUSION" >> $GITHUB_OUTPUT fi - name: Post Status to Discord uses: sarisia/actions-status-discord@v1