From 860d71ed69a69a1a3f74b79290ef471e04f57a6b Mon Sep 17 00:00:00 2001 From: sct Date: Mon, 18 Jan 2021 02:40:03 +0000 Subject: [PATCH] fix(frontend): clarify which fields are required in radarr/sonarr modals closes #575 --- src/components/Settings/RadarrModal/index.tsx | 61 +++++++++-------- src/components/Settings/SonarrModal/index.tsx | 68 ++++++++++--------- 2 files changed, 71 insertions(+), 58 deletions(-) diff --git a/src/components/Settings/RadarrModal/index.tsx b/src/components/Settings/RadarrModal/index.tsx index fde94a28..db8f2807 100644 --- a/src/components/Settings/RadarrModal/index.tsx +++ b/src/components/Settings/RadarrModal/index.tsx @@ -286,7 +286,7 @@ const RadarrModal: React.FC = ({ type="checkbox" id="isDefault" name="isDefault" - className="form-checkbox h-6 w-6 text-indigo-600 transition duration-150 ease-in-out rounded-md" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" /> @@ -296,9 +296,10 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.servername)} + *
-
+
= ({ setIsValidated(false); setFieldValue('name', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.name && touched.name && ( -
{errors.name}
+
{errors.name}
)}
@@ -324,10 +325,11 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.hostname)} + *
-
- +
+ {values.ssl ? 'https://' : 'http://'} = ({ setIsValidated(false); setFieldValue('hostname', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-r-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 form-input rounded-r-md sm:text-sm sm:leading-5" />
{errors.hostname && touched.hostname && ( -
{errors.hostname}
+
{errors.hostname}
)}
@@ -353,6 +355,7 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.port)} + *
= ({ setIsValidated(false); setFieldValue('port', e.target.value); }} - className="rounded-md shadow-sm form-input block w-24 transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="block w-24 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md shadow-sm form-input sm:text-sm sm:leading-5" /> {errors.port && touched.port && ( -
{errors.port}
+
{errors.port}
)}
@@ -387,7 +390,7 @@ const RadarrModal: React.FC = ({ setIsValidated(false); setFieldValue('ssl', !values.ssl); }} - className="form-checkbox h-6 w-6 rounded-md text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" /> @@ -397,9 +400,10 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.apiKey)} + *
-
+
= ({ setIsValidated(false); setFieldValue('apiKey', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.apiKey && touched.apiKey && ( -
{errors.apiKey}
+
{errors.apiKey}
)}
@@ -427,7 +431,7 @@ const RadarrModal: React.FC = ({ {intl.formatMessage(messages.baseUrl)}
-
+
= ({ setIsValidated(false); setFieldValue('baseUrl', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.baseUrl && touched.baseUrl && ( -
{errors.baseUrl}
+
{errors.baseUrl}
)}
@@ -453,15 +457,16 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.qualityprofile)} + *
-
+
{errors.activeProfileId && touched.activeProfileId && ( -
+
{errors.activeProfileId}
)} @@ -496,15 +501,16 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.rootfolder)} + *
-
+
{errors.rootFolder && touched.rootFolder && ( -
+
{errors.rootFolder}
)} @@ -537,14 +543,15 @@ const RadarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.minimumAvailability)} + *
-
+
@@ -554,7 +561,7 @@ const RadarrModal: React.FC = ({
{errors.minimumAvailability && touched.minimumAvailability && ( -
+
{errors.minimumAvailability}
)} @@ -572,7 +579,7 @@ const RadarrModal: React.FC = ({ type="checkbox" id="is4k" name="is4k" - className="form-checkbox h-6 w-6 rounded-md text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" />
diff --git a/src/components/Settings/SonarrModal/index.tsx b/src/components/Settings/SonarrModal/index.tsx index 0fbedc64..3181eb33 100644 --- a/src/components/Settings/SonarrModal/index.tsx +++ b/src/components/Settings/SonarrModal/index.tsx @@ -295,7 +295,7 @@ const SonarrModal: React.FC = ({ type="checkbox" id="isDefault" name="isDefault" - className="form-checkbox rounded-md h-6 w-6 text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" />
@@ -305,9 +305,10 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.servername)} + *
-
+
= ({ setIsValidated(false); setFieldValue('name', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.name && touched.name && ( -
{errors.name}
+
{errors.name}
)}
@@ -333,10 +334,11 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.hostname)} + *
-
- +
+ {values.ssl ? 'https://' : 'http://'} = ({ setIsValidated(false); setFieldValue('hostname', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-r-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 form-input rounded-r-md sm:text-sm sm:leading-5" />
{errors.hostname && touched.hostname && ( -
{errors.hostname}
+
{errors.hostname}
)}
@@ -362,6 +364,7 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.port)} + *
= ({ setIsValidated(false); setFieldValue('port', e.target.value); }} - className="rounded-md shadow-sm form-input block w-24 transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="block w-24 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md shadow-sm form-input sm:text-sm sm:leading-5" /> {errors.port && touched.port && ( -
{errors.port}
+
{errors.port}
)}
@@ -396,7 +399,7 @@ const SonarrModal: React.FC = ({ setIsValidated(false); setFieldValue('ssl', !values.ssl); }} - className="form-checkbox rounded-md h-6 w-6 text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" />
@@ -406,9 +409,10 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.apiKey)} + *
-
+
= ({ setIsValidated(false); setFieldValue('apiKey', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.apiKey && touched.apiKey && ( -
{errors.apiKey}
+
{errors.apiKey}
)}
@@ -436,7 +440,7 @@ const SonarrModal: React.FC = ({ {intl.formatMessage(messages.baseUrl)}
-
+
= ({ setIsValidated(false); setFieldValue('baseUrl', e.target.value); }} - className="flex-1 form-input block w-full min-w-0 rounded-md transition duration-150 ease-in-out sm:text-sm sm:leading-5 bg-gray-700 border border-gray-500" + className="flex-1 block w-full min-w-0 transition duration-150 ease-in-out bg-gray-700 border border-gray-500 rounded-md form-input sm:text-sm sm:leading-5" />
{errors.baseUrl && touched.baseUrl && ( -
{errors.baseUrl}
+
{errors.baseUrl}
)}
@@ -462,15 +466,16 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.qualityprofile)} + *
-
+
{errors.activeProfileId && touched.activeProfileId && ( -
+
{errors.activeProfileId}
)} @@ -505,15 +510,16 @@ const SonarrModal: React.FC = ({ className="block text-sm font-medium leading-5 text-gray-400 sm:mt-px" > {intl.formatMessage(messages.rootfolder)} + *
-
+
{errors.rootFolder && touched.rootFolder && ( -
+
{errors.rootFolder}
)} @@ -548,13 +554,13 @@ const SonarrModal: React.FC = ({ {intl.formatMessage(messages.animequalityprofile)}
-
+
{errors.activeAnimeProfileId && touched.activeAnimeProfileId && ( -
+
{errors.activeAnimeProfileId}
)} @@ -592,13 +598,13 @@ const SonarrModal: React.FC = ({ {intl.formatMessage(messages.animerootfolder)}
-
+
{errors.activeAnimeRootFolder && touched.activeAnimeRootFolder && ( -
+
{errors.rootFolder}
)} @@ -638,7 +644,7 @@ const SonarrModal: React.FC = ({ type="checkbox" id="is4k" name="is4k" - className="form-checkbox h-6 w-6 rounded-md text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" />
@@ -654,7 +660,7 @@ const SonarrModal: React.FC = ({ type="checkbox" id="enableSeasonFolders" name="enableSeasonFolders" - className="form-checkbox h-6 w-6 rounded-md text-indigo-600 transition duration-150 ease-in-out" + className="w-6 h-6 text-indigo-600 transition duration-150 ease-in-out rounded-md form-checkbox" />