From 89287af096218f8a7e3d03fc1976fb2f37d3e91c Mon Sep 17 00:00:00 2001 From: Ryan Cohen Date: Mon, 6 Nov 2023 18:48:02 +0900 Subject: [PATCH] build: use node 18 (#3675) --- .github/workflows/ci.yml | 2 +- .github/workflows/preview.yml | 2 +- Dockerfile | 7 ++++--- Dockerfile.local | 2 +- snap/snapcraft.yaml | 4 ++-- 5 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f4dbce35..2be6b2e0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: name: Lint & Test Build if: github.event_name == 'pull_request' runs-on: ubuntu-22.04 - container: node:20.9-alpine + container: node:18.18-alpine steps: - name: Checkout uses: actions/checkout@v3 diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index e1e93de0..33064429 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -8,7 +8,7 @@ on: jobs: build_and_push: name: Build & Publish Docker Preview Images - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - name: Checkout uses: actions/checkout@v3 diff --git a/Dockerfile b/Dockerfile index 85b70306..fee2e976 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.9-alpine AS BUILD_IMAGE +FROM node:18.18-alpine AS BUILD_IMAGE WORKDIR /app @@ -8,7 +8,8 @@ ENV TARGETPLATFORM=${TARGETPLATFORM:-linux/amd64} RUN \ case "${TARGETPLATFORM}" in \ 'linux/arm64' | 'linux/arm/v7') \ - apk add --no-cache python3 make g++ \ + apk add --no-cache python3 make g++ && \ + ln -s /usr/bin/python3 /usr/bin/python \ ;; \ esac @@ -32,7 +33,7 @@ RUN touch config/DOCKER RUN echo "{\"commitTag\": \"${COMMIT_TAG}\"}" > committag.json -FROM node:20.9-alpine +FROM node:18.18-alpine WORKDIR /app diff --git a/Dockerfile.local b/Dockerfile.local index 0edc660b..7efa68b5 100644 --- a/Dockerfile.local +++ b/Dockerfile.local @@ -1,4 +1,4 @@ -FROM node:20.9-alpine +FROM node:18.18-alpine COPY . /app WORKDIR /app diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml index 1010d6d3..3c7718a3 100644 --- a/snap/snapcraft.yaml +++ b/snap/snapcraft.yaml @@ -16,9 +16,9 @@ architectures: parts: overseerr: plugin: nodejs - nodejs-version: '20.9.0' + nodejs-version: '18.8.2' nodejs-package-manager: 'yarn' - nodejs-yarn-version: v1.22.17 + nodejs-yarn-version: v1.22.19 build-packages: - git - on arm64: