From dc23d7698fff004dfbd6e03daf985b10c94dbfc7 Mon Sep 17 00:00:00 2001
From: TheCatLady <52870424+TheCatLady@users.noreply.github.com>
Date: Sun, 17 Oct 2021 17:05:48 -0400
Subject: [PATCH] fix: correctly set opacity when checkbox disabled

---
 .../Settings/SettingsUsers/index.tsx          | 21 ++-----------------
 src/i18n/locale/en.json                       |  1 -
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/src/components/Settings/SettingsUsers/index.tsx b/src/components/Settings/SettingsUsers/index.tsx
index b7771a3e0..9ffffaa79 100644
--- a/src/components/Settings/SettingsUsers/index.tsx
+++ b/src/components/Settings/SettingsUsers/index.tsx
@@ -28,8 +28,6 @@ const messages = defineMessages({
   defaultPermissions: 'Default Permissions',
   defaultPermissionsTip: 'Initial permissions assigned to new users',
   signinMethods: 'Sign-In Methods',
-  plexSigninHoverTip:
-    'To disable Plex OAuth, email notifications must be enabled and the server owner must have a password configured for their account.',
   passwordSignin: '{applicationTitle} Password',
   validationSigninMethods: 'At least one sign-in method must be selected',
 });
@@ -75,7 +73,7 @@ const SettingsUsers = () => {
 
   const allowPlexSigninDisable =
     ownerData?.hasPassword &&
-    settings.currentSettings.applicationUrl &&
+    !!settings.currentSettings.applicationUrl &&
     settings.currentSettings.emailEnabled;
 
   return (
@@ -162,10 +160,7 @@ const SettingsUsers = () => {
                     <div className="form-input-area max-w-xl space-y-1.5">
                       <div
                         className={`relative flex items-start ${
-                          ownerData?.hasPassword &&
-                          settings.currentSettings.emailEnabled
-                            ? ''
-                            : 'opacity-50'
+                          allowPlexSigninDisable ? '' : 'opacity-50'
                         }`}
                       >
                         <div className="flex h-6 items-center">
@@ -177,23 +172,11 @@ const SettingsUsers = () => {
                               setFieldValue('plexLogin', !values.plexLogin);
                             }}
                             disabled={!allowPlexSigninDisable}
-                            title={
-                              !allowPlexSigninDisable
-                                ? intl.formatMessage(
-                                    messages.plexSigninHoverTip
-                                  )
-                                : undefined
-                            }
                           />
                         </div>
                         <label
                           htmlFor="plexLogin"
                           className="ml-3 block text-sm font-semibold leading-6 text-white"
-                          title={
-                            !allowPlexSigninDisable
-                              ? intl.formatMessage(messages.plexSigninHoverTip)
-                              : undefined
-                          }
                         >
                           Plex OAuth
                         </label>
diff --git a/src/i18n/locale/en.json b/src/i18n/locale/en.json
index 3e35a16a8..877262871 100644
--- a/src/i18n/locale/en.json
+++ b/src/i18n/locale/en.json
@@ -686,7 +686,6 @@
   "components.Settings.SettingsUsers.newPlexLogin": "Enable New Plex Sign-Ins",
   "components.Settings.SettingsUsers.newPlexLoginTip": "Allow Plex users with access to the media server to sign in without being imported",
   "components.Settings.SettingsUsers.passwordSignin": "{applicationTitle} Password",
-  "components.Settings.SettingsUsers.plexSigninHoverTip": "To disable Plex OAuth, email notifications must be enabled and the server owner must have a password configured for their account.",
   "components.Settings.SettingsUsers.signinMethods": "Sign-In Methods",
   "components.Settings.SettingsUsers.toastSettingsFailure": "Something went wrong while saving settings.",
   "components.Settings.SettingsUsers.toastSettingsSuccess": "User settings saved successfully!",