From c05d73a84bfe8798f2b56ba2cb49d5b16cd1fc90 Mon Sep 17 00:00:00 2001
From: Robert Dailey <github@rdailey.me>
Date: Sun, 15 Jan 2023 10:45:27 -0600
Subject: [PATCH] refactor: Remove redundant config validation

Validation already happens in ConfigParser, then SyncProcessor does not
need to do it as well.
---
 .../Services/Processors/SyncProcessor.cs             | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/src/Recyclarr.TrashLib/Services/Processors/SyncProcessor.cs b/src/Recyclarr.TrashLib/Services/Processors/SyncProcessor.cs
index 844a2419..489df647 100644
--- a/src/Recyclarr.TrashLib/Services/Processors/SyncProcessor.cs
+++ b/src/Recyclarr.TrashLib/Services/Processors/SyncProcessor.cs
@@ -1,6 +1,5 @@
 using System.Diagnostics.CodeAnalysis;
 using Flurl.Http;
-using JetBrains.Annotations;
 using Recyclarr.Common.Extensions;
 using Recyclarr.TrashLib.Config;
 using Recyclarr.TrashLib.Config.Parsing;
@@ -14,13 +13,11 @@ using Spectre.Console;
 
 namespace Recyclarr.TrashLib.Services.Processors;
 
-[UsedImplicitly]
 [SuppressMessage("Design", "CA1031:Do not catch general exception types")]
 public class SyncProcessor : ISyncProcessor
 {
     private readonly IAnsiConsole _console;
     private readonly ILogger _log;
-    private readonly ConfigValidationExecutor _validator;
     private readonly IConfigurationFinder _configFinder;
     private readonly IConfigurationLoader _configLoader;
     private readonly ServiceProcessorFactory _factory;
@@ -28,14 +25,12 @@ public class SyncProcessor : ISyncProcessor
     public SyncProcessor(
         IAnsiConsole console,
         ILogger log,
-        ConfigValidationExecutor validator,
         IConfigurationFinder configFinder,
         IConfigurationLoader configLoader,
         ServiceProcessorFactory factory)
     {
         _console = console;
         _log = log;
-        _validator = validator;
         _configFinder = configFinder;
         _configLoader = configLoader;
         _factory = factory;
@@ -105,13 +100,6 @@ public class SyncProcessor : ISyncProcessor
                 }
 
                 PrintProcessingHeader(service.ToString(), config);
-
-                if (!_validator.Validate(config))
-                {
-                    // Useful logs are printed in the Validate method
-                    continue;
-                }
-
                 using var processor = _factory.CreateProcessor<TConfig>(config);
                 await processor.Value.Process(config, settings);
             }